From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE8DEC3DA7F for ; Wed, 31 Jul 2024 19:56:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dyM0aahj5f/ZqujH5rL+/VP2LuHSbK4HqlZzEsmA8Ks=; b=TgDxCK97u39NFrCZU+o3NabL40 5ZqVAmXEge9S5ofxddCjrcbKczk28GLPRsd5qequR/szYdxmWviSFdPBSkjpwxg3aE5NM94TikWFI DLa08oVqQEOOMvBQmoneJh8z/edtDB5nw7WJKy8yE93ZMxRG23ZtLDZIaQbK+BiPfibNHJEDE8FgY tHHXchd5JIvOjOzBpwOCMRFAtxTSGC471G0Wwq9BFif0RDpaOa83zzEpIrK+PQM5XWbi2YSQEksJ2 KsoRW3bJPSYI/IBIx4zwZI97jU5MITfJ3MqBD08Z52luKupfDV3sCtQJUdRErdKnZCz4dbauAatnz fPSjapBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZFR5-00000002NiQ-0fXK; Wed, 31 Jul 2024 19:56:35 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZFQb-00000002Ndc-0ozf for linux-arm-kernel@lists.infradead.org; Wed, 31 Jul 2024 19:56:07 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 854BECE131D; Wed, 31 Jul 2024 19:56:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7742C116B1; Wed, 31 Jul 2024 19:56:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722455762; bh=o8N+u0byDeedT1YKt9nGlaJQnl4BOMWVYyEe55Z9/Ig=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ANt9xDQn4Gb2H/+k7BQBmKlegDc9USQMvOgq9Dr07ezmC41r62uKt+3Sp8UFHdhvB 4zMkm9qW7I1j0d+u98xdzUcCQbYBG53O9hvA5mTWax+Peo71wjaAqMff3ER+uSrAKz pqwQCee70uVSGJj0zBD/XDtqeTGBYI3VEwgyIGR7M9OF6tF/qKBKnTdZTVKsE7O5Id 4oSRNEK2hYpUjhefsXiOdKf+nTmGkAWXSNAzD2QwvIGrnXJrjJY73F9YYFgjX9ZMOs oZFBxurb1Ax9D+zZMjjm4TsoUmnd3LOEYof/7iFKNWuGc8YuMg5zsAu3GifIGLrB98 1PWq7+dReq2jw== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sZFQW-00H6l8-OW; Wed, 31 Jul 2024 20:56:00 +0100 Date: Wed, 31 Jul 2024 20:55:59 +0100 Message-ID: <87wml149ps.wl-maz@kernel.org> From: Marc Zyngier To: Mark Brown Cc: Oliver Upton , James Morse , Suzuki K Poulose , Catalin Marinas , Will Deacon , Fuad Tabba , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] KVM: arm64: Fix outdated comment about incomplete FGT bitmask definitions In-Reply-To: <20240731-kvm-arm64-fgt-doc-v1-1-abb364f8fe57@kernel.org> References: <20240731-kvm-arm64-fgt-doc-v1-0-abb364f8fe57@kernel.org> <20240731-kvm-arm64-fgt-doc-v1-1-abb364f8fe57@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: broonie@kernel.org, oliver.upton@linux.dev, james.morse@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, tabba@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240731_125605_484771_DA58F686 X-CRM114-Status: GOOD ( 14.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 31 Jul 2024 19:58:37 +0100, Mark Brown wrote: > > Comments in the code say that our definitions for the FGT registers are not > the generated ones and are updated only as far as DDI0487 J.a however in > commit 9ff67dd26a9e ("KVM: arm64: Use generated FGT RES0 bits instead of > specifying them") we updated to use the generated definitions, and as of > the release of DDI0487 K.a the XML in DD0601 is in sync with the ARM. s/ARM/ARM ARM/. Which revision of the XML? K.a and the latest version of the XML are definitely not in sync. Also, please make use of punctuation. I can't parse this *single* sentence as it stands. > Remove the outdated comment about divergence. > > Fixes: 9ff67dd26a9e ("KVM: arm64: Use generated FGT RES0 bits instead of specifying them") Definitely *not* a fix. M. -- Without deviation from the norm, progress is not possible.