From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2613C4828D for ; Wed, 7 Feb 2024 14:56:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=47BYzVQ0UkJVpChLnEMyxyms2Ki209WHbG7Nn5Ng8Zo=; b=F6rfxotGXkEL4O vKPw7t4ge6WCKz6QSqW0ZiBvO3po33x+sPv5rSzerSiBQb1SXTVTo8d2WSNpfSWXsMC4sAQW+IthO szkjHJ66H9dXcVAnM1IQ1WIhfZ6Z9ZBbf3XCJw3rsrvoYIhwWeqsKQEYBjfrph9gZ3mRgtlaM8ndk 80m8RvmxOsyXDHBgIDpljs9gp5ImcjAD1AcbU58bciOuNXBD54L4oAv+7cRza4LIquD7wEX9WhTdy TWDif+W5PIhegxRBpOQNYUPrnNDfsL+wwH0/Twakp8cIYLeEfHkRK1VfGr7LfTN4f7vozoqqg7UE9 vwC5pMvRYoacypLGMZtw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXjLk-0000000B0Hn-09DR; Wed, 07 Feb 2024 14:56:32 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rXjLh-0000000B0GC-09dh; Wed, 07 Feb 2024 14:56:30 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id CF798CE1917; Wed, 7 Feb 2024 14:56:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2521EC433C7; Wed, 7 Feb 2024 14:56:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707317784; bh=nCxQ8fGvuEcmb7qfNQBjMnRhra6lyUgdE8qqI+GeNOE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=EfZIOFsbNQM3dkm04/Qj0EZ243NsK9ajRBm2H+sB5OzsyUN3vEQGbDwa9uZSqeTEE 5lcSSmrbC1fbtfZPkKSWg/wBOGX6FpSUT8bQuVjHFV504oi1/pOInXJgvi1r6CxC2+ pyMsS4DAJ6599icKOl/tyHmpN3d1F0hHFSinMRK1oSoXzhg6KZB3YyjfnQC3oxqCWk oRD2sL03j4bxIvU1rtzlXwbY2Vpw523rOqsLdVCICdyyKlfSVk4tNp80EvfqlAOtNp d7tZMtmpWdgAGmHo+jo+2G//1pnIfsHzLQdUjIynAJOYoB7aavvW3fi4GQsPcqPez1 WiL4bNo+KjxaQ== From: Kalle Valo To: "Colin King (gmail)" Cc: Felix Fietkau , Lorenzo Bianconi , Ryder Lee , Shayne Chen , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH][next] mt76: Remove redundant assignment to variable tidno References: <20240207131113.2450297-1-colin.i.king@gmail.com> <87il30h03n.fsf@kernel.org> <13e2f96c-2434-4266-8a5e-25b267d1fb0e@gmail.com> Date: Wed, 07 Feb 2024 16:56:20 +0200 In-Reply-To: <13e2f96c-2434-4266-8a5e-25b267d1fb0e@gmail.com> (Colin King's message of "Wed, 7 Feb 2024 14:53:51 +0000") Message-ID: <87wmrgpbl7.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240207_065629_271862_6A88764B X-CRM114-Status: UNSURE ( 7.90 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org "Colin King (gmail)" writes: > On 07/02/2024 13:31, Kalle Valo wrote: >> Colin Ian King writes: >> >>> The variable tidno is being assigned a value that is not being read >>> and is being re-assigned a new value a few statements later. >>> The assignment is redundant and can be removed. >>> >>> Cleans up clang scan warning: >>> drivers/net/wireless/mediatek/mt76/agg-rx.c:125:5: warning: Value stored >>> to 'tidno' during its initialization is never read [deadcode.DeadStores] >>> >>> Signed-off-by: Colin Ian King >> "wifi:" missing from title. >> > does this require a V2? Up to Felix, my guess is that he can add it during commit. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel