From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21434C27C76 for ; Wed, 25 Jan 2023 10:01:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V/igKGuVt9ScZ7r8dxArequvSzXx+10PG4XRA4Myr3c=; b=TAluugV9uaNN5e yni4+oi+h9oR2QE/UgNgcDGE1ff5eA2jCNRsYN7nBr3SvQvX2Ze44c7GjtD9g+WZEvY0iexrnQCUE BrEZfPjeGLUk2O7wO9ZNd/UcU6HV16QsZ7GxSzdEEEuWwnNDvFdJ/4DrORVYCXnvCZ6HhU90gIHJh ZmrwCLJYB9WutkmXqS5G0huMclBUvLVEaNV9angr774MKPjwYosEYnDA5AJGcvh5FsSiqGWVSLdx8 vkt9Icyyq09EZNOm920e1e0JkMut17m4vstIfRfPtdUcB7wuqiN6tKtjo8Vk7OIuC/cG8pRkEI9LW 658Md8xHLp0br+X373SQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKcZd-006mWV-K5; Wed, 25 Jan 2023 10:00:11 +0000 Received: from sender4-op-o14.zoho.com ([136.143.188.14]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKcUz-006kgM-49 for linux-arm-kernel@lists.infradead.org; Wed, 25 Jan 2023 09:55:22 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1674640517; cv=none; d=zohomail.com; s=zohoarc; b=lgOSlRFjiTeXa1ZiN0Sh5q2BNXtuIw1nkHYqh6Cne9vaO7pk8dCW1x1knI7VU7IhgwjIlDY1gSBM24Muw30HLmFpYM4w5hGTQzutF4lMgeh97Rj5ZTqQenGdZia6gfJ+Zdh4j0+b0UHLHixr5iSLtvPcMACiNFd/26FJulMgCgY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1674640517; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=GxhsZuLW1aUUdsIzkDgq7YtS68/mjfyyTwcISg+gePc=; b=F5dsF2CihVBrWMGwf1Hzr0xnW89rx2OEbQ9vMdxa4tj3XKiac2EH3/M6LsGyUh+OkgBuKvgQ4elsqhFVLjb6p/pUflgKdBsAJMEUm+EBicd+ZX1CAEvO7gLfa/O9gOsfUYM9TDtqxzbl73UR/TLF8WieIJC0MjI+5B920DG06WY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=linux.beauty; spf=pass smtp.mailfrom=me@linux.beauty; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1674640517; s=zmail; d=linux.beauty; i=me@linux.beauty; h=Date:Date:Message-ID:From:From:To:To:Cc:Cc:Subject:Subject:In-Reply-To:References:MIME-Version:Content-Type:Message-Id:Reply-To; bh=GxhsZuLW1aUUdsIzkDgq7YtS68/mjfyyTwcISg+gePc=; b=t7IMeHM8eXXlOe/+x22OEMDUS/bjYxO9RZy7BxQdzpDLZNuloE0YQJOgm2ZEc3xh 7WZ9xErJN9/r6zArxEZ+A7Cse7ze2vLqk/TLfUgegdQQmp/JRy2awfqjR+H+Fs66n76 PW5YudxpvvVsI6SfdWD/jHVSlKEuCp0R4mWGLJ7w= Received: from lchen-xiaoxin.linux.beauty (221.225.241.248 [221.225.241.248]) by mx.zohomail.com with SMTPS id 1674640515886204.08088684860002; Wed, 25 Jan 2023 01:55:15 -0800 (PST) Date: Wed, 25 Jan 2023 17:54:28 +0800 Message-ID: <87wn5bgcrv.wl-me@linux.beauty> From: Li Chen To: Krzysztof Kozlowski Cc: Li Chen , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , "moderated list:ARM/Ambarella SoC support" , "open list:SERIAL DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: Re: [PATCH 09/15] dt-bindings: serial: add support for Ambarella In-Reply-To: References: <20230123073305.149940-1-lchen@ambarella.com> <20230123073305.149940-10-lchen@ambarella.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-ZohoMailClient: External X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230125_015521_286543_194FDDBD X-CRM114-Status: GOOD ( 19.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof Kozlowski, Sorry for my late reply. On Mon, 23 Jan 2023 16:11:52 +0800, Krzysztof Kozlowski wrote: > > On 23/01/2023 08:32, Li Chen wrote: > > Add compatible for Ambarella. > > > > Signed-off-by: Li Chen > > Change-Id: I32513d98f52af0311dfb55dd5c4739a58f6b9fc1 > > --- > > .../bindings/serial/ambarella_uart.yaml | 57 +++++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 58 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/serial/ambarella_uart.yaml > > > > diff --git a/Documentation/devicetree/bindings/serial/ambarella_uart.yaml b/Documentation/devicetree/bindings/serial/ambarella_uart.yaml > > new file mode 100644 > > index 000000000000..238d68078270 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/serial/ambarella_uart.yaml > > @@ -0,0 +1,57 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/serial/ambarella_uart.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Ambarella S6LM SoC UART Controller > > + > > +maintainers: > > + - Li Chen > > + > > +properties: > > + compatible: > > + const: ambarella,uart > > + > > + reg: > > + maxItems: 1 > > + > > + amb,ignore-fe: > > + description: | > > + ignore frame error report for CV2/CV22/CV25/S6LM because it's > > + checked too strict so that normal stop may be treated as frame error. > > Missing type. I don't understand why this is property of DT. Ok, I will add "type: boolean" to it. > Anyway several problems mentioned earlier, please fix. Well noted. Regards, Li _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel