From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Michael Walle <michael@walle.cc>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jason Cooper <jason@lakedaemon.net>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Michael Walle <michael@walle.cc>
Subject: Re: [PATCH 2/2] ARM: dts: kirkwood: lsxl: remove first ethernet port
Date: Fri, 02 Sep 2022 16:16:15 +0200 [thread overview]
Message-ID: <87wnaleua8.fsf@BL-laptop> (raw)
In-Reply-To: <20220816001026.830127-2-michael@walle.cc>
Michael Walle <michael@walle.cc> writes:
> Both the Linkstation LS-CHLv2 and the LS-XHL have only one ethernet
> port. This has always been wrong, i.e. the board code used to set up
> both ports, but the driver will play nice and return -ENODEV if the
> assiciated PHY is not found. Nevertheless, it is wrong. Remove it.
>
> Fixes: 876e23333511 ("ARM: kirkwood: add gigabit ethernet and mvmdio device tree nodes")
> Signed-off-by: Michael Walle <michael@walle.cc>
Applied on mvebu/dt
Thanks,
Gregory
> ---
> arch/arm/boot/dts/kirkwood-lsxl.dtsi | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/arch/arm/boot/dts/kirkwood-lsxl.dtsi b/arch/arm/boot/dts/kirkwood-lsxl.dtsi
> index 321a40a98ed2..88b70ba1c8fe 100644
> --- a/arch/arm/boot/dts/kirkwood-lsxl.dtsi
> +++ b/arch/arm/boot/dts/kirkwood-lsxl.dtsi
> @@ -218,22 +218,11 @@ hdd_power: regulator@2 {
> &mdio {
> status = "okay";
>
> - ethphy0: ethernet-phy@0 {
> - reg = <0>;
> - };
> -
> ethphy1: ethernet-phy@8 {
> reg = <8>;
> };
> };
>
> -ð0 {
> - status = "okay";
> - ethernet0-port@0 {
> - phy-handle = <ðphy0>;
> - };
> -};
> -
> ð1 {
> status = "okay";
> ethernet1-port@0 {
> --
> 2.30.2
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-02 14:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 0:10 [PATCH 1/2] ARM: dts: kirkwood: lsxl: fix serial line Michael Walle
2022-08-16 0:10 ` [PATCH 2/2] ARM: dts: kirkwood: lsxl: remove first ethernet port Michael Walle
2022-08-19 0:24 ` Andrew Lunn
2022-09-02 14:16 ` Gregory CLEMENT [this message]
2022-08-19 0:28 ` [PATCH 1/2] ARM: dts: kirkwood: lsxl: fix serial line Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnaleua8.fsf@BL-laptop \
--to=gregory.clement@bootlin.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).