From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: "Marek Behún" <kabel@kernel.org>, linux-arm-kernel@lists.infradead.org
Cc: pali@kernel.org, "Josef Schlehofer" <josef.schlehofer@nic.cz>,
"Marek Behún" <kabel@kernel.org>
Subject: Re: [PATCH mvebu/dt 2/2] ARM: dts: turris-omnia: enable LED controller node
Date: Mon, 18 Jul 2022 12:43:04 +0200 [thread overview]
Message-ID: <87wncar9af.fsf@BL-laptop> (raw)
In-Reply-To: <20220704113622.18887-2-kabel@kernel.org>
Marek Behún <kabel@kernel.org> writes:
> The LED controller node is disabled because the leds-turris-omnia driver
> does not support setting the LED blinking to be controlled by the MCU.
>
> The patches for that have now been sent [1], so let's enable the node.
>
> [1] https://lore.kernel.org/linux-leds/20220704105955.15474-1-kabel@kernel.org/T/
>
> Signed-off-by: Marek Behún <kabel@kernel.org>
Applied on mvebu/dt
Thanks,
Gregory
> ---
> arch/arm/boot/dts/armada-385-turris-omnia.dts | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index 1583c4b14ae8..d1e0db6e5730 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -191,15 +191,13 @@ led-controller@2b {
> reg = <0x2b>;
> #address-cells = <1>;
> #size-cells = <0>;
> + status = "okay";
>
> /*
> * LEDs are controlled by MCU (STM32F0) at
> * address 0x2b.
> *
> - * The driver does not support HW control mode
> - * for the LEDs yet. Disable the LEDs for now.
> - *
> - * Also LED functions are not stable yet:
> + * LED functions are not stable yet:
> * - there are 3 LEDs connected via MCU to PCIe
> * ports. One of these ports supports mSATA.
> * There is no mSATA nor PCIe function.
> @@ -210,7 +208,6 @@ led-controller@2b {
> * B. Again there is no such function defined.
> * For now we use LED_FUNCTION_INDICATOR
> */
> - status = "disabled";
>
> multi-led@0 {
> reg = <0x0>;
> --
> 2.35.1
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-18 10:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 11:36 [PATCH mvebu/dt 1/2] ARM: dts: turris-omnia: configure LED[0] pin function to link/activity Marek Behún
2022-07-04 11:36 ` [PATCH mvebu/dt 2/2] ARM: dts: turris-omnia: enable LED controller node Marek Behún
2022-07-18 10:43 ` Gregory CLEMENT [this message]
2022-07-18 10:42 ` [PATCH mvebu/dt 1/2] ARM: dts: turris-omnia: configure LED[0] pin function to link/activity Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wncar9af.fsf@BL-laptop \
--to=gregory.clement@bootlin.com \
--cc=josef.schlehofer@nic.cz \
--cc=kabel@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=pali@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).