From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 967B4C4338F for ; Thu, 12 Aug 2021 14:47:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 514D86108C for ; Thu, 12 Aug 2021 14:47:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 514D86108C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dy2a2oU7iasat1mVjJW7Y3WDkLZNe7jp8z3lxQSPow0=; b=eV4ly18aRQwBi+ L07Cjg4euY0OUZQOgKOg0q8A0egtYgaGxoAfkbLTvhEd+fSpne/dNdDpN1+kHqhES5vAH3gm9WtGi L6pvkkSAAoKjxREGYb4pQzw/Diaoz9NxILBWm36LwvkvI/fi61uL1AJ5rsq4QYTWkK296JW6eNNUO i5oGoOQrIn8L/+QKjwrS+ZrnwsbsNlvH4OcAPJ3f/L6uSd/Ws63q0jEUIbDL/yeCiws83aAup1vEt 8/SC4moDzk6QDPyuzG4Vlego8KhQEsOLpbtzJIAy0yOcwrGq+n8eYjfa7KvmQDCnd1RGUfMud4tMq Ner7XXRWuVY+xl4CyqtQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEBy2-00ATqi-3C; Thu, 12 Aug 2021 14:45:58 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mEBxy-00ATq3-D8 for linux-arm-kernel@lists.infradead.org; Thu, 12 Aug 2021 14:45:55 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4AE93610A4; Thu, 12 Aug 2021 14:45:53 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mEBxv-004Zhc-8x; Thu, 12 Aug 2021 15:45:51 +0100 Date: Thu, 12 Aug 2021 15:45:50 +0100 Message-ID: <87wnoq90wx.wl-maz@kernel.org> From: Marc Zyngier To: Valentin Schneider Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Lorenzo Pieralisi , Vincenzo Frascino Subject: Re: [PATCH v3 05/13] genirq: Let purely flow-masked ONESHOT irqs through unmask_threaded_irq() In-Reply-To: <875ywa944c.mognet@arm.com> References: <20210629125010.458872-1-valentin.schneider@arm.com> <20210629125010.458872-6-valentin.schneider@arm.com> <87bl639l8n.wl-maz@kernel.org> <875ywa944c.mognet@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: valentin.schneider@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, tglx@linutronix.de, lorenzo.pieralisi@arm.com, vincenzo.frascino@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210812_074554_501598_946EF324 X-CRM114-Status: GOOD ( 22.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 12 Aug 2021 14:36:35 +0100, Valentin Schneider wrote: > > On 12/08/21 08:26, Marc Zyngier wrote: > > On Tue, 29 Jun 2021 13:50:02 +0100, > > Valentin Schneider wrote: > >> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c > >> index ef30b4762947..e6d6d32ddcbc 100644 > >> --- a/kernel/irq/manage.c > >> +++ b/kernel/irq/manage.c > >> @@ -1107,7 +1107,7 @@ static void irq_finalize_oneshot(struct irq_desc *desc, > >> desc->threads_oneshot &= ~action->thread_mask; > >> > >> if (!desc->threads_oneshot && !irqd_irq_disabled(&desc->irq_data) && > >> - irqd_irq_masked(&desc->irq_data)) > >> + (irqd_irq_masked(&desc->irq_data) | irqd_irq_flow_masked(&desc->irq_data))) > >> unmask_threaded_irq(desc); > > > > The bitwise OR looks pretty odd. It is probably fine given that both > > side of the expression are bool, but still. I can fix this locally. > > > > Thomas suggested that back in v1: > > https://lore.kernel.org/lkml/87v98v4lan.ffs@nanos.tec.linutronix.de/ > > I did look at the (arm64) disassembly diff back then and was convinced by > what I saw, though I'd have to go do that again as I can't remember much > else. Ah, fair enough. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel