From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A13BC388F9 for ; Wed, 11 Nov 2020 11:54:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 846EE20709 for ; Wed, 11 Nov 2020 11:54:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RIJnwdph"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="rndhnIa7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 846EE20709 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:In-Reply-To:Subject:To: From:References:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UtbyUoU4uy5Rj6nngqwmGyxJBOD+uVV5UUovHHI5+qg=; b=RIJnwdph+rvyMMbwE/8A43A9w Etr85dpmI1xVPaLe/H527SQ37NAs0xjxCl27EjKi2UYV0r7bfBhPOQ2fcokfNxY0+Grm+pQukQRU3 OoXtxklP2psf6jLTPo4afRKifU++cm0ZVNF81uDRD9J1ljA5BoI6ZskeqD+KDx6HjtLrTY0F6Km2I OHjECWhDXZkslstS5Yly0i0j7VR1huODFQ2Qx+8SeUYr7zv7UcTNG97nXKFnLdAQePyZ7dYac0myE Y2gVMolnIr37lOWDUIAofk9e8flh6AET6ln7P4wYOVgMg2743ihFiKLGameOaBxFteNwbj7xS5V+4 Kod0tIlDg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcoh8-0003cf-NA; Wed, 11 Nov 2020 11:53:46 +0000 Received: from esa5.microchip.iphmx.com ([216.71.150.166]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kcoh6-0003aw-6I for linux-arm-kernel@lists.infradead.org; Wed, 11 Nov 2020 11:53:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1605095624; x=1636631624; h=references:from:to:cc:subject:in-reply-to:date: message-id:mime-version; bh=WSmJGeYv08kihbIdCx4Xr9p9GNTGzzp58lE9eX/ZuP8=; b=rndhnIa7kbW6Oe5EwPUdF30eJcfEa0yUZf3H3NL4btmodlb+k6js130k xk5mqKKOk7PpUtZzVwJcxpymaU/pWnt/hhKQJybyUrqvadEShACjqKAtR Det0SxMQYRVxZAs8UUJu0woa9D0SKeVoQBzSTWEwDUmZtAIzF/8vZARE1 CwAitZpd6XLLxHc9XlJFy8rReNq74zwAw20E5fApz3v7gwS5DXP8RjI+x X4LZCYjNsyqkDNWXp34yYwVyUwduri/+6ByQpJ7nZVdi7XpSHXfkdBNEM OtA3vOaB4svFfgqk/JNns0lf/N11ffApNYxbzBFiEeMbVundY7TE/Frvz A==; IronPort-SDR: Vpk5sZaNn8l5nZ7DduYthRfjCryb7NYr1FPqIw/WSI6ptrNOjWWJgOF7ce395ziptShbSR5f8z +E66enIU5MTdecR05McBuk3xyxkFUEJZb7QMFTYCUSiVD4nTNpigMtNFyxBcmKhKbj2jgnPivz o2juzUj4beaVtF7TsIly+xuPn9/Nd9baj78aC1SC23+jdxWzyQj0Gj0KoooApXjKUGUJCChuyI x9ziOUkEqhOHYTQulL1xpBeNPsaUUCdV0J2+4Ju2j5Ukab4HBUGvqEiQCZNZUOQnAQtOWSGudS 2Wc= X-IronPort-AV: E=Sophos;i="5.77,469,1596524400"; d="scan'208";a="98026575" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 11 Nov 2020 04:53:38 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Wed, 11 Nov 2020 04:53:38 -0700 Received: from soft-dev10.microchip.com (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3 via Frontend Transport; Wed, 11 Nov 2020 04:53:36 -0700 References: <20201109132643.457932-1-lars.povlsen@microchip.com> <20201109132643.457932-3-lars.povlsen@microchip.com> <87361hfbwu.fsf@microchip.com> <87zh3oe0nr.fsf@microchip.com> User-agent: mu4e 1.2.0; emacs 26.3 From: Lars Povlsen To: Andy Shevchenko Subject: Re: [PATCH v8 2/3] pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO In-Reply-To: Date: Wed, 11 Nov 2020 12:53:35 +0100 Message-ID: <87wnys3y9s.fsf@microchip.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201111_065344_372376_CB029CB1 X-CRM114-Status: GOOD ( 17.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Alexandre Belloni , Linus Walleij , Linux Kernel Mailing List , Microchip Linux Driver Support , "open list:GPIO SUBSYSTEM" , Lars Povlsen , linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Andy Shevchenko writes: > On Wed, Nov 11, 2020 at 10:52 AM Lars Povlsen > wrote: >> Andy Shevchenko writes: >> > On Tue, Nov 10, 2020 at 5:51 PM Lars Povlsen wrote: >> >> > On Mon, Nov 9, 2020 at 3:27 PM Lars Povlsen wrote: > > ... > >> >> >> + return -EOPNOTSUPP; >> >> > >> >> > Are you sure? IIRC internally we are using ENOTSUPP. >> >> > >> >> > Couple of drivers seem to be wrongly using the other one. >> >> >> >> Checkpatch complains about ENOTSUPP: >> >> >> >> # ENOTSUPP is not a standard error code and should be avoided in new patches. >> >> # Folks usually mean EOPNOTSUPP (also called ENOTSUP), when they type ENOTSUPP. >> > >> > checkpatch is wrong if this is internal code and to me sounds like >> > it's not going out of the kernel. >> > >> > ... >> >> As it appears there are different opinions on this I'll let the pinctrl >> maintainer decide. > > There are no other opinions. > Read description of struct pinconf_ops and fix the code. > checkpatch is simply wrong here. Lets no start a war :-) - I'll change it... > >> >> >> + err = -EOPNOTSUPP; >> >> > >> >> > Ditto. >> >> >> >> Ditto. >> > >> > Ditto. Cheers, ---Lars -- Lars Povlsen, Microchip _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel