From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72431C43461 for ; Mon, 7 Sep 2020 11:48:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5BEC20C09 for ; Mon, 7 Sep 2020 11:48:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ab0Im712"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="fNDGu7mT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5BEC20C09 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:To:From: Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ji6EqiCy+ucVR3vZerQ9A6uzudrlDopa/uNm2jMn1gg=; b=Ab0Im712gKOOH9smHEEfmyQZs BHGV6+/8Mw1edHpr3Ly0jilcBDfCyQ0lMVVcROT0lFZpUu+JgUIOPJ9SEmztbtVG2cMu7CHwe1PyC p+sR2/4xXvVafrBWbyRF3KxB1zpg+xPw1InPnRixgX0qhi7PSGRHo/5yIXNxU5C7unYuBPjB7N1N4 3ENf3KrFHG5WhmajG3oyOiBFtbjcrZzA3Vi6JVYUPSIUbX9aocC7WWqHAq1BbhQFTSrpa+a49U2CO z3Qwj+2Hl0YC56cNyY1IkBEZ0V3jB+ockY+4g8mrQbvwaW+q/YWS/r6M+CKdURBqQzuX7UNIopg8w 3iD4F5BCg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFFbt-0002SU-UB; Mon, 07 Sep 2020 11:46:58 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFFbq-0002Rn-OI for linux-arm-kernel@lists.infradead.org; Mon, 07 Sep 2020 11:46:56 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A9B83207C3; Mon, 7 Sep 2020 11:46:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599479213; bh=vQO/mkxuUbHFYS++GetY/5IbiGpHZq/A237zPcJhwgM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fNDGu7mTBtk8PQxAIPQHwhjGaVbFXr9qH6cLFvurGeCbDr6ln7HI8DW/B9ikeWC3d bbrDDN5x05NX2U8o6egXGMq6NsghFnV6h8Is3xvWG28nMunPLzR/HDAkI4uIgQcYwX XlCTE4KPsi1fCkRHTWm7xKx8kVX8ZN7FUepOIAfA= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFFbn-009kme-Lk; Mon, 07 Sep 2020 12:46:51 +0100 Date: Mon, 07 Sep 2020 12:46:50 +0100 Message-ID: <87wo15lsgl.wl-maz@kernel.org> From: Marc Zyngier To: Andrew Scull Subject: Re: [PATCH v3 07/18] KVM: arm64: nVHE: Don't consume host SErrors with ESB In-Reply-To: <20200903135307.251331-8-ascull@google.com> References: <20200903135307.251331-1-ascull@google.com> <20200903135307.251331-8-ascull@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: ascull@google.com, kvmarm@lists.cs.columbia.edu, james.morse@arm.com, suzuki.poulose@arm.com, julien.thierry.kdev@gmail.com, will@kernel.org, catalin.marinas@arm.com, kernel-team@android.com, sudeep.holla@arm.com, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200907_074654_883580_E5A78718 X-CRM114-Status: GOOD ( 19.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-team@android.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, james.morse@arm.com, linux-arm-kernel@lists.infradead.org, Sudeep Holla , will@kernel.org, kvmarm@lists.cs.columbia.edu, julien.thierry.kdev@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 03 Sep 2020 14:52:56 +0100, Andrew Scull wrote: > > The ESB at the start of the host vector may cause SErrors to be consumed > to DISR_EL1. However, this is not checked for the host so the SError > could go unhandled. > > Remove the ESB so that SErrors are not consumed but are instead left > pending for the host to consume. __guest_enter already defers entry into > a guest if there are any SErrors pending. > > Fixes: 0e5b9c085dce ("KVM: arm64: Consume pending SError as early as possible") I'd drop the Fixes: tag here. The KVM RAS support was never designed to use nVHE the first place, and this patch is impossible to backport without dragging tons of other patches, turning it into a nightmare. The patch itself is fine. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel