From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71C42C433E4 for ; Sun, 26 Jul 2020 10:27:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 397EA206D8 for ; Sun, 26 Jul 2020 10:27:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="3UzymfMP"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZBMDAWWK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 397EA206D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:To:From: Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Q/PFKVyqkmmpgfhg1s0ie6uaJ+xJzW20VTqESjTxnc0=; b=3UzymfMPTr74fuSRXg6d2CMJu ta2cExVZjmQUeTV/GUItZL/QqCi82Ca6/Hw35emu4d7iQCsuz53uKp2CDrUMGRfdO5WtAn5ry7gyg JMNkyJKYKihoNR8sxHIXtGqWF/89FlATZ+geDbYD5lY5Z9BNiJulO/GtBkd/MrYZdNiz1WKK8bimn qs4qpN4riEnikOJhe5ZNnQE8goy94Lxy1ZemX11Ex/A3XLEfw+AVW1fVrP3FTBQNqBzBmwwHKRmtd c0z3QZ4BKCZICouUcd2JiCvujftM6ZTVpkIH5xLNkF/IIJJnfpSRJhTKsb0nRp/nLyTmjUwhPPUB7 8dxsQoY6Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jzdqM-0003CH-Ca; Sun, 26 Jul 2020 10:25:22 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jzdqJ-0003Bw-Lj for linux-arm-kernel@lists.infradead.org; Sun, 26 Jul 2020 10:25:20 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 83AEB206D8; Sun, 26 Jul 2020 10:25:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595759118; bh=ug2stl67UDUJgbNJGfvU0eqL3Tvb+mH5wo7CPnHpZSU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZBMDAWWKn/MPUoY1oeByyRYFHg0Xh3CtZbtlXPSFSWxHn+Fs01DfeTEBAlI4JS2fh 6LFsFK/qtTX7JRi/fKxv1Jp/V5sS9Cf8dNQQXIUYHIeQZUd0Z1jxdoi18U0m6RpGKU d8d/LFOsqLsuZBXJw6nh7vmEMVbgsTi9LiErg8Ak= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jzdqG-00F0bz-NT; Sun, 26 Jul 2020 11:25:16 +0100 Date: Sun, 26 Jul 2020 11:25:15 +0100 Message-ID: <87wo2qwp2s.wl-maz@kernel.org> From: Marc Zyngier To: kernel test robot , Saravana Kannan Subject: Re: [arm-platforms:irq/irqchip-next 41/43] drivers/irqchip/irq-mtk-sysirq.c:236:1: warning: parameter names (without types) in function declaration In-Reply-To: <202007261731.5H1vb9oj%lkp@intel.com> References: <202007261731.5H1vb9oj%lkp@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: lkp@intel.com, saravanak@google.com, kbuild-all@lists.01.org, linux-arm-kernel@lists.infradead.org, hanks.chen@mediatek.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200726_062519_955952_BCF75155 X-CRM114-Status: GOOD ( 27.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-team@android.com, Hanks Chen , kbuild-all@lists.01.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 26 Jul 2020 10:18:34 +0100, kernel test robot wrote: > > [1 ] > tree: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git irq/irqchip-next > head: 99e05524bc722c8d3c1ab9c817afcb6829dbded3 > commit: 3ae3022690e6787839dafa8ea3496450248b53e1 [41/43] irqchip/mtk-sysirq: Convert to a platform driver > config: arm-defconfig (attached as .config) > compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > git checkout 3ae3022690e6787839dafa8ea3496450248b53e1 > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All error/warnings (new ones prefixed by >>): > > In file included from drivers/irqchip/irq-mtk-sysirq.c:8: > >> include/linux/irqchip.h:40:1: warning: data definition has no type or storage class > 40 | MODULE_DEVICE_TABLE(of, drv_name##_irqchip_match_table); \ > | ^~~~~~~~~~~~~~~~~~~ > drivers/irqchip/irq-mtk-sysirq.c:236:1: note: in expansion of macro 'IRQCHIP_PLATFORM_DRIVER_END' > 236 | IRQCHIP_PLATFORM_DRIVER_END(mtk_sysirq) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > >> include/linux/irqchip.h:40:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int] > 40 | MODULE_DEVICE_TABLE(of, drv_name##_irqchip_match_table); \ > | ^~~~~~~~~~~~~~~~~~~ > drivers/irqchip/irq-mtk-sysirq.c:236:1: note: in expansion of macro 'IRQCHIP_PLATFORM_DRIVER_END' > 236 | IRQCHIP_PLATFORM_DRIVER_END(mtk_sysirq) > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ > >> drivers/irqchip/irq-mtk-sysirq.c:236:1: warning: parameter names (without types) in function declaration > cc1: some warnings being treated as errors Thanks for the heads up. The patch introducing the new macros fails to include linux/module.h (arm64 gets away with it by luck, while arm fails to compile). I'm fixing it with the patch below. M. >From 691d1b3962ff7d434eefcd991e6e7bd629379625 Mon Sep 17 00:00:00 2001 From: Marc Zyngier Date: Sun, 26 Jul 2020 11:12:36 +0100 Subject: [PATCH] irqchip: Fix IRQCHIP_PLATFORM_DRIVER_* compilation by including module.h The newly introduced IRQCHIP_PLATFORM_DRIVER_* macros expand into module-related macros, but do so without including module.h. Depending on the driver and/or architecture, this happens to work, or not. Unconditionnaly include linux/module.h to sort it out. Fixes: f3b5e608ed6d ("irqchip: Add IRQCHIP_PLATFORM_DRIVER_BEGIN/END and IRQCHIP_MATCH helper macros") Reported-by: kernel test robot Cc: Saravana Kannan Signed-off-by: Marc Zyngier --- include/linux/irqchip.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/irqchip.h b/include/linux/irqchip.h index 8e754d8b8155..67351aac65ef 100644 --- a/include/linux/irqchip.h +++ b/include/linux/irqchip.h @@ -12,6 +12,7 @@ #define _LINUX_IRQCHIP_H #include +#include #include #include -- 2.27.0 -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel