From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9BC0C433DF for ; Tue, 2 Jun 2020 09:49:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7CCCE20734 for ; Tue, 2 Jun 2020 09:49:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="K3CcGtuL"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="hmU8VbGn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7CCCE20734 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date: In-Reply-To:Subject:To:From:References:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=YCNO0a1GG33VOHQtZ5lmXVkKQXtSOwR9SF7wQqZYHms=; b=K3CcGtuLDfzM3E4nKIGn7EoZLP VsH3sp1QFiZlDco22cFfZiOGp8qIdEjHvFbJhin6ImPQhQQNGimeIEBVrgzBMoMw28SEj6JrFuKHs wGe/FkP0NmSDyXxitoFExwPnr16IkPTwLa/rXVbjKsZxkdotXNtm6myxhZnQm95eP11c0eDpwCaYS gGX7oeiY+u4kfqkfgTxzMqqFFeOjDtFLXEJnN5WIx/5NIxtRLkssfhi0bQgaK028PFEUEme/Ea6S7 Gmio7xhDk5pWxQuKQN8H2J1d1uBpCg7Ah1aM9AjDooISeMz7doVOVkrH8aT+3ildF19GqVVnj8gaN g8syZn3g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jg3Xp-0003oW-TN; Tue, 02 Jun 2020 09:49:17 +0000 Received: from esa3.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jg3Xl-0003nZ-1a for linux-arm-kernel@lists.infradead.org; Tue, 02 Jun 2020 09:49:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1591091353; x=1622627353; h=references:from:to:cc:subject:in-reply-to:date: message-id:mime-version; bh=XYWvcTMnu5gYjXeMs5ChljnhBkkNboMpnYYArlKHA2Y=; b=hmU8VbGnEYkQbF2Zs1wDA1SfyFR2klxwok2QZKB7SAi3lomGO9TII38J T7XZQSwOrzLU5ij42c/eedRrG/cXOrsBvPd2N/3kaECRwNsrBqg4GPQ/H hRQVee+nU0NHO32ovcGuYDhSijCyAKHl5VYOALg23qv+I4n1s7DG6vLZ1 c/k1Gpkl1UNwuoajMAX9XeECIOaPJcT9RgL//wYvY9xjnkplJCeIvu3rs wo7RtZ+m22K5X4Ys44ZMVmHZT35F6bDhd97ugJ5bwL0e1U353KJEGKZ2M QuYFws+5oJSTtRWR3paILI6ylGHwW9UK7egpsQ9iysdP/JRyPRyBA2T5u w==; IronPort-SDR: vkMrKR4DTnFoAhQgn4Xj1OqpqZBjuz9tFOz8GKffkGjDmng3TRtTay4RgFkq7ULrjECwGmLp2m MdaD91OpomcTxZoazsPtP8rBvk1J/QPwvHPriOj4gjHo6X3yW+V7odKuskYGG/vk5coh3y+k4v 5vkWGsKDTL2niv/nkykeYnFTG4jIV0YXk4WAsd2uVrVbQ89uuxfPhB3A8oxGLQzsiG5teIAGDZ GxjzyHPPXkMhugow9mwMqubhKeLm9tfEeYLqLs8YPwhZ3VbI/aLrVZOqNwif5U3PoYtoSP0QBS LIk= X-IronPort-AV: E=Sophos;i="5.73,463,1583218800"; d="scan'208";a="78594449" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 02 Jun 2020 02:49:12 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 2 Jun 2020 02:49:12 -0700 Received: from soft-dev15.microsemi.net.microchip.com (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 2 Jun 2020 02:49:09 -0700 References: <20200513130842.24847-1-lars.povlsen@microchip.com> <20200513130842.24847-4-lars.povlsen@microchip.com> <20200528022502.GA3234572@bogus> From: Lars Povlsen To: Rob Herring Subject: Re: [PATCH 3/5] dt-bindings: reset: ocelot: Add documentation for 'microchip, reset-switch-core' property In-Reply-To: <20200528022502.GA3234572@bogus> Date: Tue, 2 Jun 2020 11:49:08 +0200 Message-ID: <87wo4piyqz.fsf@soft-dev15.microsemi.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200602_024913_134498_0DC96FF6 X-CRM114-Status: GOOD ( 13.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , List-Id: Cc: devicetree@vger.kernel.org, Alexandre Belloni , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , Microchip Linux Driver Support , SoC Team , linux-arm-kernel@lists.infradead.org, Lars Povlsen Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Rob Herring writes: > On Wed, May 13, 2020 at 03:08:40PM +0200, Lars Povlsen wrote: >> This documents the 'microchip,reset-switch-core' property in the >> ocelot-reset driver. >> >> Signed-off-by: Lars Povlsen >> --- >> .../devicetree/bindings/power/reset/ocelot-reset.txt | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/power/reset/ocelot-reset.txt b/Documentation/devicetree/bindings/power/reset/ocelot-reset.txt >> index 4d530d8154848..20fff03753ad2 100644 >> --- a/Documentation/devicetree/bindings/power/reset/ocelot-reset.txt >> +++ b/Documentation/devicetree/bindings/power/reset/ocelot-reset.txt >> @@ -9,9 +9,15 @@ microchip Sparx5 armv8 SoC's. >> Required Properties: >> - compatible: "mscc,ocelot-chip-reset" or "microchip,sparx5-chip-reset" >> >> +Optional properties: >> +- microchip,reset-switch-core : Perform a switch core reset at the >> + time of driver load. This is may be used to initialize the switch >> + core to a known state (before other drivers are loaded). > > How do you know when other drivers are loaded? This could be a module > perhaps. Doesn't seem like something that belongs in DT. > The reset driver is loaded at postcore_initcall() time, which ensures it is loaded before other drivers using the switch core. I noticed other drivers do the same to do low-level system reset and initialization at early boot time. > Can this behavior be implied with "microchip,sparx5-chip-reset"? Since we need to cater for both modus operandi, I would need two driver compatible strings per platform, which scales worse than a single property. The "microchip,reset-switch-core" is a device configuration property which tells the system (driver) how the hw should be handled. Since you do not *always* want to reset the switch core (f.ex. when implementing systems with warm reboot), I think it makes perfect sense - but I may be biased off course :-) Thank you for (all) of your comments, by the way! ---Lars > > Rob -- Lars Povlsen, Microchip _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel