From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B6CAC43381 for ; Tue, 5 Mar 2019 21:47:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DCAC520652 for ; Tue, 5 Mar 2019 21:47:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Mv/XULc6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DCAC520652 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=anholt.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sHUaijzq7WT/ZOOlkj14jPsBjJY9LY1ZJ9muBjz1kKo=; b=Mv/XULc6kvKvIRWkJUcJYV3NB itavVx/RaV58sOiqc8Cd1T3QKfRp77Ht6mDOyAg18gD2zkY/RuB6WElGLrV8H8u1d1gQdJ8exZclh IPkyUektkUdhsupH0W80NHS/COFHUMoGmW7YVtT96/PEnTFbHZhUhKfexwBpiRVSlH020U8kWEhFS m/Yx0ckE1uTySoylcIUXQKs5DpZg2Els1Uz3o6S2Ku42/NWMEyJoGvPVpOM7NGUy3BL8ZrRxQXXvE JFEJ1U8Xec/rgK6kBL8CvejKMiu+TZhH32I4ZMRY34tkOOb3D5s+CaNTaFIokTNQGyndqkXSngAIs 7lsO5OqcA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1Huf-00039g-Dv; Tue, 05 Mar 2019 21:47:49 +0000 Received: from anholt.net ([50.246.234.109]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h1Huc-000391-Hc for linux-arm-kernel@lists.infradead.org; Tue, 05 Mar 2019 21:47:48 +0000 Received: from localhost (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id 47B9010A2DFF; Tue, 5 Mar 2019 13:47:41 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at anholt.net Received: from anholt.net ([127.0.0.1]) by localhost (kingsolver.anholt.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id lwM0R8tQLi47; Tue, 5 Mar 2019 13:47:39 -0800 (PST) Received: from eliezer.anholt.net (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id DB05910A2A9B; Tue, 5 Mar 2019 13:47:39 -0800 (PST) Received: by eliezer.anholt.net (Postfix, from userid 1000) id 723692FE464F; Tue, 5 Mar 2019 13:47:39 -0800 (PST) From: Eric Anholt To: Maxime Ripard , Alex Deucher Subject: Re: [PATCH 2/7] drm/edid: Allow to ignore the audio EDID data In-Reply-To: <20190305091240.sbkvdwosocaytx22@flea> References: <4914bea9fc3ef3deaffa39ab691dbd9a76461e97.1551711042.git-series.maxime.ripard@bootlin.com> <87wole76ws.fsf@anholt.net> <20190305091240.sbkvdwosocaytx22@flea> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/25.2.2 (x86_64-pc-linux-gnu) Date: Tue, 05 Mar 2019 13:47:38 -0800 Message-ID: <87woldm1s5.fsf@anholt.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190305_134746_623871_E0AA81E2 X-CRM114-Status: GOOD ( 21.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: eben@raspberrypi.org, David Airlie , Maarten Lankhorst , Maling list - DRI developers , Paul Kocialkowski , Sean Paul , Thomas Petazzoni , Daniel Vetter , linux-arm-kernel Content-Type: multipart/mixed; boundary="===============8952227048423011887==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8952227048423011887== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Maxime Ripard writes: > [ Unknown signature status ] > On Mon, Mar 04, 2019 at 03:05:31PM -0500, Alex Deucher wrote: >> On Mon, Mar 4, 2019 at 2:53 PM Eric Anholt wrote: >> > >> > Maxime Ripard writes: >> > >> > > In some cases, in order to accomodate with displays with poor EDIDs,= we >> > > need to ignore that the monitor alledgedly supports audio output and >> > > disable the audio output. >> > > >> > > Signed-off-by: Maxime Ripard >> > > --- >> > > drivers/gpu/drm/drm_edid.c | 8 ++++++++ >> > > 1 file changed, 8 insertions(+) >> > > >> > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c >> > > index 990b1909f9d7..c0258b011bb2 100644 >> > > --- a/drivers/gpu/drm/drm_edid.c >> > > +++ b/drivers/gpu/drm/drm_edid.c >> > > @@ -4190,6 +4190,11 @@ bool drm_detect_hdmi_monitor(struct edid *edi= d) >> > > } >> > > EXPORT_SYMBOL(drm_detect_hdmi_monitor); >> > > >> > > +static bool ignore_edid_audio =3D false; >> > > +module_param(ignore_edid_audio, bool, 0644); >> > > +MODULE_PARM_DESC(ignore_edid_audio, >> > > + "Ignore the EDID and always consider that a monitor d= oesn't have audio capabilities"); >> > > + >> > > /** >> > > * drm_detect_monitor_audio - check monitor audio capability >> > > * @edid: EDID block to scan >> > > @@ -4209,6 +4214,9 @@ bool drm_detect_monitor_audio(struct edid *edi= d) >> > > bool has_audio =3D false; >> > > int start_offset, end_offset; >> > > >> > > + if (ignore_edid_audio) >> > > + goto end; >> > > + >> > > edid_ext =3D drm_find_cea_extension(edid); >> > > if (!edid_ext) >> > > goto end; >> > >> > It looks like the motivation for the original flag on Raspberry Pi was >> > "I've got a non-audio monitor, but the system comes up trying to play >> > audio to HDMI instead of the analog jack". Do we have some way for DRM >> > to communicate to ALSA that this is not the right place to try to play >> > audio by default? >>=20 >> Apparently not. We have users using debug knobs in our drivers to >> disable display audio because ALSA defaults to that rather than other >> audio. > > I guess one way to do this would be to register the card only when an > audio-capable monitor is connected instead of doing this at probe > time. I'm not sure how convenient it is for userspace though. Oh, right, the HDMI encoder passes the ELD to ALSA, and userspace gets to use that. So, open source is already doing the right thing, and the problem was that the old driver talking to the firmware wouldn't, thus the need for a flag. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlx+7noACgkQtdYpNtH8 nugPOw/8CUEDLaLFIt9yVZ0lcuaI5tZw7NP7TVV+0t1YZy1/LxwxkhCGkMGJoJUr n+cdLKgGrg3nuaXDFG1sosF53VHikFirs2JJ9gtQIVndNylXl/La8/fNUPDphubr UAguttRb+93YqZxBvvqd3mY+oojphO2sww9aHItSPG1xud7eNe8mW2QsUm5qpIDg q/qnEIqLjAPY6qhodnrnsnK8PSMLJ+5xHGQ70o/yxC/vfgI8B/lNHMofOtg+O3n6 CqHzsEcarwg5q4cwWSfWOlClwsii2/w3HVBg5HqrWEkA0Dzi5xkhYpoxEbS6a5xp OM+WPYtoTUnzuuUDpUmgorBDNZCI8mq91Y/TIuXduWtsbj9/jG7KO1aCh/ESUPvK GM3tKdSyr0ULc0BUEZLpSKK/7bMoR8CN4wxC0UbjDhMouyfZ5ZagkBUdMrSCfi0d UMWvbmPKTB8o25aZD7QfKEaZ271KkMzTMMtPN6CeM1PYfVtKpeRyzsHQEixgjtva FjuppMOrTenrr003Mxcyoqx17X6hoo4EXbsNUQy5qemyEh7szaYQ3x7qtBXyjkHi Cmh7FA6WKUIcKc3OwbirXAkMCt++ZOQfm88xwk3eNAMpduLFP57hDznMsCqfhVTU 6ylUNV7A05XmZe1ZA28rkkAF/+gNjRc5kdyIU1/a9Vm1B2v7uoQ= =ejHc -----END PGP SIGNATURE----- --=-=-=-- --===============8952227048423011887== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8952227048423011887==--