From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63F8EC4360F for ; Mon, 4 Mar 2019 19:53:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E6DD20823 for ; Mon, 4 Mar 2019 19:53:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MBgv2evJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E6DD20823 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=anholt.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7kAlATgp2BJI3zBZbkCtFAYbhAmXktbvFOhQyETZdWE=; b=MBgv2evJBx+tr4/74zTD8yUVm 7aoh2Tw4KR0tPy+KEnsIJmv2+cQUhmfzqxHbSoNFb4ADIDTwdmm5PxX+PruDTdaIB2br+yPMmA0xL LIQo6xN3TMDDHx4sOsj696VwWJAA6eFDtumEIepxxKd1/oKoIy/UwTjK1k1sDD8baULm2qq1ibecL GvzYnF4r3eNpUz8RqkVQ2oXFYcOk123mvYY4KPvjj4V9RJkGubYBiw128sYf2ny4VPVN5jDf1pGf7 f0TKszRDq/eZDJJA+aOBvj80/NR54ygwA4nsjkhhG+20ICOEHyQOHm5rtIhLO1jPHSQYjWpQHXjja XkDTBRfQg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0ten-0003X6-G6; Mon, 04 Mar 2019 19:53:49 +0000 Received: from anholt.net ([50.246.234.109]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h0tek-0003Wc-8Z for linux-arm-kernel@lists.infradead.org; Mon, 04 Mar 2019 19:53:47 +0000 Received: from localhost (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id 271FC10A2A7A; Mon, 4 Mar 2019 11:53:43 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at anholt.net Received: from anholt.net ([127.0.0.1]) by localhost (kingsolver.anholt.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id eSz-HGPljgvm; Mon, 4 Mar 2019 11:53:41 -0800 (PST) Received: from eliezer.anholt.net (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id B9E4610A2A62; Mon, 4 Mar 2019 11:53:41 -0800 (PST) Received: by eliezer.anholt.net (Postfix, from userid 1000) id E1B352FE464E; Mon, 4 Mar 2019 11:53:40 -0800 (PST) From: Eric Anholt To: Maxime Ripard , Maarten Lankhorst , Sean Paul , Maxime Ripard , Daniel Vetter , David Airlie Subject: Re: [PATCH 2/7] drm/edid: Allow to ignore the audio EDID data In-Reply-To: <4914bea9fc3ef3deaffa39ab691dbd9a76461e97.1551711042.git-series.maxime.ripard@bootlin.com> References: <4914bea9fc3ef3deaffa39ab691dbd9a76461e97.1551711042.git-series.maxime.ripard@bootlin.com> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/25.2.2 (x86_64-pc-linux-gnu) Date: Mon, 04 Mar 2019 11:53:39 -0800 Message-ID: <87wole76ws.fsf@anholt.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190304_115346_336141_88C93DF8 X-CRM114-Status: GOOD ( 16.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paul Kocialkowski , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, Thomas Petazzoni , eben@raspberrypi.org Content-Type: multipart/mixed; boundary="===============7247968088385076059==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============7247968088385076059== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Maxime Ripard writes: > In some cases, in order to accomodate with displays with poor EDIDs, we > need to ignore that the monitor alledgedly supports audio output and > disable the audio output. > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/drm_edid.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 990b1909f9d7..c0258b011bb2 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -4190,6 +4190,11 @@ bool drm_detect_hdmi_monitor(struct edid *edid) > } > EXPORT_SYMBOL(drm_detect_hdmi_monitor); >=20=20 > +static bool ignore_edid_audio =3D false; > +module_param(ignore_edid_audio, bool, 0644); > +MODULE_PARM_DESC(ignore_edid_audio, > + "Ignore the EDID and always consider that a monitor doesn't have audi= o capabilities"); > + > /** > * drm_detect_monitor_audio - check monitor audio capability > * @edid: EDID block to scan > @@ -4209,6 +4214,9 @@ bool drm_detect_monitor_audio(struct edid *edid) > bool has_audio =3D false; > int start_offset, end_offset; >=20=20 > + if (ignore_edid_audio) > + goto end; > + > edid_ext =3D drm_find_cea_extension(edid); > if (!edid_ext) > goto end; It looks like the motivation for the original flag on Raspberry Pi was "I've got a non-audio monitor, but the system comes up trying to play audio to HDMI instead of the analog jack". Do we have some way for DRM to communicate to ALSA that this is not the right place to try to play audio by default? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlx9gkMACgkQtdYpNtH8 nugcqxAAp22ZWbsBXmwA2P2091hw33bUJwEhVDFC2ORD+gwmnG4DJqdbmg6IAMXN AQw0yvAzGi2InZAGaVmUTmFPozY5aAF+RNpw9gHTj7iJO2Me+oXYeh+OhiNS+wVq mCQEJwTjI1kpNNHqrJ/FdIey365Uv/OfJ1eDHklWPVRwkDn4kNJ1o8S3ZH6nM+Vk jGp2UWVEEbTF06uiPM5Aw7U+kP1nEM7Suj1gITZ95ske5ArNibTS86PoJvoROldk LhguynIruYSd1Uz+W/Fyw2UWNktT0ECH9ZWVw6KPxbjLXKC1hw8xJOdnT7FfOLW+ upJ3asO55KjN2CJSP8fa636BulSdRBdNDd2WHcAejjR4NQq/r9Ft3PCAsZOTFIM0 V46DnRAdAS2fhuRa2DRIf3v0hc1QvFbDU/DlgbX2G9m4Is4NHHmiYAbA1bA5LVUZ q6Xg7ZpNlXrQ3OltGMC3acQtV2B9rXgubPFEnBVGJN+iQk7mT4J6ujaIoElGatlJ f9e/t3l42zxOnDGNAz14gBPjt0RA84bBJMZeRTNxQMttYh2MCncD0vzE5SpzU4rJ xIHyQcKPdbOSdJd2Zls/fQHHyDWO6ak5Bu08FJzcGGQg+ZEs6Ww0Cof3k2pkBwhE vRN4y/VHxg+cGeJx0LHeXrk8+aogq2BmxisRPCUIrm4Zp5/0S0A= =PYfc -----END PGP SIGNATURE----- --=-=-=-- --===============7247968088385076059== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============7247968088385076059==--