* [PATCH] irqchip/gic-v5: Remove the redundant ITS cache invalidation
@ 2025-09-03 2:33 Zenghui Yu
2025-09-03 6:21 ` Marc Zyngier
0 siblings, 1 reply; 2+ messages in thread
From: Zenghui Yu @ 2025-09-03 2:33 UTC (permalink / raw)
To: linux-arm-kernel, linux-kernel
Cc: maz, lpieralisi, tglx, wanghaibin.wang, Zenghui Yu
An ITS cache invalidation has been performed immediately after programming
the L2 DTE in gicv5_its_device_register(). No need to perform it again
right after a successful gicv5_its_device_register().
Remove it.
Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
---
drivers/irqchip/irq-gic-v5-its.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/irqchip/irq-gic-v5-its.c b/drivers/irqchip/irq-gic-v5-its.c
index 2fb58d76f521..554485f0be1f 100644
--- a/drivers/irqchip/irq-gic-v5-its.c
+++ b/drivers/irqchip/irq-gic-v5-its.c
@@ -768,8 +768,6 @@ static struct gicv5_its_dev *gicv5_its_alloc_device(struct gicv5_its_chip_data *
goto out_dev_free;
}
- gicv5_its_device_cache_inv(its, its_dev);
-
its_dev->its_node = its;
its_dev->event_map = (unsigned long *)bitmap_zalloc(its_dev->num_events, GFP_KERNEL);
--
2.33.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] irqchip/gic-v5: Remove the redundant ITS cache invalidation
2025-09-03 2:33 [PATCH] irqchip/gic-v5: Remove the redundant ITS cache invalidation Zenghui Yu
@ 2025-09-03 6:21 ` Marc Zyngier
0 siblings, 0 replies; 2+ messages in thread
From: Marc Zyngier @ 2025-09-03 6:21 UTC (permalink / raw)
To: Zenghui Yu
Cc: linux-arm-kernel, linux-kernel, lpieralisi, tglx, wanghaibin.wang
On Wed, 03 Sep 2025 03:33:19 +0100,
Zenghui Yu <yuzenghui@huawei.com> wrote:
>
> An ITS cache invalidation has been performed immediately after programming
> the L2 DTE in gicv5_its_device_register(). No need to perform it again
> right after a successful gicv5_its_device_register().
Indeed. And this call doesn't check it's been successful either.
>
> Remove it.
>
> Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
> ---
> drivers/irqchip/irq-gic-v5-its.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-gic-v5-its.c b/drivers/irqchip/irq-gic-v5-its.c
> index 2fb58d76f521..554485f0be1f 100644
> --- a/drivers/irqchip/irq-gic-v5-its.c
> +++ b/drivers/irqchip/irq-gic-v5-its.c
> @@ -768,8 +768,6 @@ static struct gicv5_its_dev *gicv5_its_alloc_device(struct gicv5_its_chip_data *
> goto out_dev_free;
> }
>
> - gicv5_its_device_cache_inv(its, its_dev);
> -
> its_dev->its_node = its;
>
> its_dev->event_map = (unsigned long *)bitmap_zalloc(its_dev->num_events, GFP_KERNEL);
Reviewed-by: Marc Zyngier <maz@kernel.org>
M.
--
Jazz isn't dead. It just smells funny.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-03 6:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-03 2:33 [PATCH] irqchip/gic-v5: Remove the redundant ITS cache invalidation Zenghui Yu
2025-09-03 6:21 ` Marc Zyngier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).