From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7720BC3DA64 for ; Sun, 28 Jul 2024 21:42:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=q7aK20IlmQwmfDE56bJr2rtG6Uwoh9l8h3MdILXONZU=; b=Q47LaSSYf3Q1UG3vk5N7GgX7ku AKRLvHnGO7c23hqWFrm/HDkWVYaiCaRZPK4DMPjB+aH8JSyW1Y+x2O5kdpKVuTGc0r5idTzHnExXf 0TELIR0bwekYOvu+GD5i3ZhJCncEsP3X1tAUkQ1LqeeUHeXX/KB5CSKSEA4JAWKlVD7CBOzHw52/6 Vam7Hsp8R1ashw+WKI6JAIZLJHVIznWSH+fFHSuuflBFJveIZsO6XRWaHqiLMlIy6cJyXlGH1kau9 +V464TbeJ3sY8Jm6bHJBod5J8L8h41yROvX55gdpcx949U4iNFhdsYpk+F4MafIQ6emH83RKPbTme NbZ0P2GA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYBex-00000009HZw-2tr7; Sun, 28 Jul 2024 21:42:31 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sYBeU-00000009HVb-2heU for linux-arm-kernel@lists.infradead.org; Sun, 28 Jul 2024 21:42:06 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1722202921; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q7aK20IlmQwmfDE56bJr2rtG6Uwoh9l8h3MdILXONZU=; b=Ih+AAUzpcp7BjX3vejsWJIQ42FyD5/kgZR9woX4zCGESCOEbX4IvUjPKZ2iQmIzp8SLojY PKpEj6HT3rf1NN85CmCvXfkDe0QM+sJSLEUlREmRp+Rh/fY0Id+ByUNuOFxSNMeT0I0oJE 1Vs/J1CMBDsPfT7JNq8dgvojATshL4IUf2kj1iBUpZJfgbeCRq16U6FDb1iWAnhzbOGYzJ oFypNoVm/O5c+XBfRxTS4JJg2agHnWEGRedv73Rf7j/G2Rn7Sups+NjiinlZi198xfZkNl fT8fBqIFZ8H+TRNWVWZdRlFYffMXvUqohNARtK0FyhcBOot5mUhTkuyLwtJ2uw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1722202921; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q7aK20IlmQwmfDE56bJr2rtG6Uwoh9l8h3MdILXONZU=; b=MAMpPiy2n7O/RuM7ktD4hoHAgxIG1zVEvQIhEz3WB0E71t0mv5JMVtAth8HjFlTUt/ppwE frd6GwRE957oiaAw== To: Marek =?utf-8?Q?Beh=C3=BAn?= , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , linux-arm-kernel@lists.infradead.org, arm@kernel.org, Andy Shevchenko , Hans de Goede , Ilpo =?utf-8?Q?J=C3=A4rvinen?= Cc: Marek =?utf-8?Q?Beh=C3=BAn?= Subject: Re: [PATCH 04/13] irqchip/armada-370-xp: Add the __init attribute to mpic_msi_init() In-Reply-To: <20240715105156.18388-5-kabel@kernel.org> References: <20240715105156.18388-1-kabel@kernel.org> <20240715105156.18388-5-kabel@kernel.org> Date: Sun, 28 Jul 2024 23:42:00 +0200 Message-ID: <87y15lry6v.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240728_144202_852187_1E821284 X-CRM114-Status: GOOD ( 14.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 15 2024 at 12:51, Marek Beh=C3=BAn wrote: > Add the __init attribute to the mpic_msi_init() function. It is only > called from the device initializer, and so can be dropped after boot is > complete. > > Signed-off-by: Marek Beh=C3=BAn > --- > drivers/irqchip/irq-armada-370-xp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-ar= mada-370-xp.c > index 1739bf768696..2185f79007f4 100644 > --- a/drivers/irqchip/irq-armada-370-xp.c > +++ b/drivers/irqchip/irq-armada-370-xp.c > @@ -318,8 +318,8 @@ static void mpic_msi_reenable_percpu(void) > writel(1, per_cpu_int_base + MPIC_INT_CLEAR_MASK); > } >=20=20 > -static int mpic_msi_init(struct device_node *node, > - phys_addr_t main_int_phys_base) > +static int __init mpic_msi_init(struct device_node *node, > + phys_addr_t main_int_phys_base) Please get rid of the line break while at it. Thanks, tglx