From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4F89C4707B for ; Thu, 18 Jan 2024 14:10:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oOorJTnYzwjmiL4iO2ihm49ofo6aoObWJLX15vlrOog=; b=aqKr+m9MIEULkE 8QAbk8xs4CRwnAjUP5DX8xewxZh7VG6cQL0eerb1v2BchmPWGq5LTASy+M5G4JuzKq1197kF3oxu1 ikwflKDGeketW4rX3dH5RR40hDfj9eLVviUPnjTK4bh8lukMgcYo94PbAyouk4kh1jlEXP3Jr1EBl F/epAzf11pnfCF+AexEtYZ8p8yCxrZHE4ZREsX0nL/27LMvHQV3851Efy7SeoNtwGcpL1bWDw6vq4 YmaWnEk6fb1mENkmE1HhTGy55N1o6YtV4n3BQzBkaJOQlLn702xArBXvmWDjZjJhA4YidNwiOn97V k87O9kyndimq22RbdXPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rQT5k-002vQb-2K; Thu, 18 Jan 2024 14:10:00 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rQT5h-002vOw-0t for linux-arm-kernel@lists.infradead.org; Thu, 18 Jan 2024 14:09:58 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id CFE4EB818A0; Thu, 18 Jan 2024 14:09:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 371CEC433C7; Thu, 18 Jan 2024 14:09:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705586995; bh=kBiT5drkA1zgE0V/ePCDsjTx47cqMBWft3QxfGT5hXg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SorbwJHwyJdHQdbkVNp8ySIaJDkWF/fDdv4spTE3Zc5Pnm8eUEpxyq3vE2h+QS7wB VOqhuIzlR5F6q1jVIvFCHNxgj2C4a4+Dj2ZtdlSCCIrJsBZHiT+FqERGJ93YtzoeT1 mrTKjnwkn0nU+pAlcqLoQelYhIlSDvVVlem/u1ShNOitByvbuYBuQAbmC/0N3Qkuhu 3O+gH4BhEZ3hdgwzjWAOLwF2q88Ixaf0GRrXBhPJ8psJZkEpC8WE88o/bondO90aiQ 0j4pITXHZ6c9Gw4jRYf/PyTgW7dndpLBKrpuDwoMw2lOg2qr0pe70fGAtR1bRT/yyq 06PZ69uTLy93A== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rQT5d-00CiPd-4S; Thu, 18 Jan 2024 14:09:53 +0000 Date: Thu, 18 Jan 2024 14:09:52 +0000 Message-ID: <87y1cmwx5b.wl-maz@kernel.org> From: Marc Zyngier To: Dawei Li Cc: tglx@linutronix.de, sdonthineni@nvidia.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, set_pte_at@outlook.com, stable@vger.kernel.org Subject: Re: [PATCH 4/4] genirq: Initialize resend_node hlist for all irq_desc In-Reply-To: <20240118112739.2000497-5-dawei.li@shingroup.cn> References: <20240118112739.2000497-1-dawei.li@shingroup.cn> <20240118112739.2000497-5-dawei.li@shingroup.cn> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: dawei.li@shingroup.cn, tglx@linutronix.de, sdonthineni@nvidia.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, set_pte_at@outlook.com, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240118_060957_456699_B89782DE X-CRM114-Status: GOOD ( 19.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 18 Jan 2024 11:27:39 +0000, Dawei Li wrote: > > For !CONFIG_SPARSE_IRQ kernel, early_irq_init() is supposed to > initialize all the desc entries in system, desc->resend_node > included. > > Thus, initialize desc->resend_node for all irq_desc entries, rather > than irq_desc[0] only, which is the current implementation is about. > > Fixes: bc06a9e08742 ("genirq: Use hlist for managing resend handlers") > Cc: stable@vger.kernel.org > > Signed-off-by: Dawei Li > --- > kernel/irq/irqdesc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c > index 27ca1c866f29..371eb1711d34 100644 > --- a/kernel/irq/irqdesc.c > +++ b/kernel/irq/irqdesc.c > @@ -600,7 +600,7 @@ int __init early_irq_init(void) > mutex_init(&desc[i].request_mutex); > init_waitqueue_head(&desc[i].wait_for_threads); > desc_set_defaults(i, &desc[i], node, NULL, NULL); > - irq_resend_init(desc); > + irq_resend_init(&desc[i]); > } > return arch_early_irq_init(); > } Well spotted. It would probably be worth having a helper that fully initialises one desc, but that's out of the scope of this fix. Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel