From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B5AEEEEC01 for ; Fri, 15 Sep 2023 19:14:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=I1wnBej3w5eQA4jxQyyZWt8wJ/5BCB9jUWcKqFcq5rg=; b=4clkhiED/VcJxD JILTipotJ/mR4Ib7nbIot9/RFim1zFrpHalo2Q62anGn3GDw7ODfRxSes4U9E2D2q6bqxmQ1W3tFJ 7q8tDvjdCs/2SedzQcsAcKaEbqb03JjQI+ktyLK76MFPG3TOX/dRuF9c8M52BGoZN2rr+k7gvPhs2 nPs7elR502wtkEWnta1sI34ITTjYjfIUcEMV6eFuIV6v7rAKN/MeuhOCAoxKthoplRcnKRbNiEc1x vK3VDKNWfigslVMwiSr6m9zl6hIZ44NGDC05r3M4blX551vgrz5dII0hAseMlUiinS7TINkkDMu3I he82idbbLGBvj6D/9BcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qhEGt-00BFV4-1M; Fri, 15 Sep 2023 19:14:31 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qhEGq-00BFUj-0X for linux-arm-kernel@lists.infradead.org; Fri, 15 Sep 2023 19:14:29 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1694805266; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rApaMJWzLfsSlXraIlDQUJyr3iLwzD00Wf6q05UQ0mU=; b=VhiEl6OnF7EIHZJ0155JYnZKmWWPicROKgPOGKFsPdTtv9NbdGHV8VraP4Mca4lP7phW2N CZZZBV6m5/Zz2JxbJkyLiAehLcg3EAcFt2KHLXHddKDutmId0xLaKuARM9DP6wt/PZSuP7 ANfnpr288k3QwRzKXizWXESSpthW1mT6PP+vDQs/42g3AfnU4zCDPOsJXkvDcGu3BEqc43 mih695uKck/ev/CrIfdNNipokd9r4vvkeYp+raKqmHhFzEZlrDD0OvzYEW+NyFM4hVj9EE hZ3MwbPLOJJiSz//MgIqhvD6yWnWThoO3yqiTPqJp73Bwj6zNJlbIF6xMmNrIA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1694805266; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rApaMJWzLfsSlXraIlDQUJyr3iLwzD00Wf6q05UQ0mU=; b=zrklfkJaPaJbPwJMIOjo273uhLqrzHOFJz+YrfnWxTkKGqSo+SXcSSBLom1XvIN987uKZh p4o167PLO7Iz4NBg== To: Mark Rutland , linux-arm-kernel@lists.infradead.org Cc: daniel.lezcano@linaro.org, linux-kernel@vger.kernel.org, mark.rutland@arm.com, maz@kernel.org Subject: Re: [PATCH] clocksource/drivers/arm_arch_timer: Initialize evtstrm after finalizing cpucaps In-Reply-To: <20230907133410.3817800-1-mark.rutland@arm.com> References: <20230907133410.3817800-1-mark.rutland@arm.com> Date: Fri, 15 Sep 2023 21:14:25 +0200 Message-ID: <87y1h7z1ta.ffs@tglx> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230915_121428_365841_2CB717FA X-CRM114-Status: GOOD ( 13.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 07 2023 at 14:34, Mark Rutland wrote: > We attempt to initialize each CPU's arch_timer event stream in > arch_timer_evtstrm_enable(), which we call from the > arch_timer_starting_cpu() cpu hotplug callback which is registered early > in boot. As this is registered before we initialize the system cpucaps, > the test for ARM64_HAS_ECV will always be false for CPUs present at boot > time, and will only be taken into account for CPUs onlined late > (including those which are hotplugged out and in again). > > Due to this, CPUs present and boot time may not use the intended divider > and scale factor to generate the event stream, and may differ from other > CPUs. > > Correct this by only initializing the event stream after cpucaps have been > finalized, registering a separate CPU hotplug callback for the event stream > configuration. Since the caps must be finalized by this point, use > spus_have_final_cap() to verify this. > > Signed-off-by: Mark Rutland > Cc: Daniel Lezcano > Cc: Marc Zyngier > Cc: Thomas Gleixner Acked-by: Thomas Gleixner _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel