From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E796C38142 for ; Tue, 31 Jan 2023 22:17:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+qdJ9RYXZLlxJ39kEXyXS3eCc3lEOTyKIgvavYwPymE=; b=UUMWoRPDqltR58 QukePnPQ3YIKd4bvsJLZ2AsUiSb0nH6dsqAhODWe5OmB/QiHh2gTSK6GJrAkZC4MIMsf/VtZuXqFj Hrlz5qTAsOGTh2Gye7rAeUC3W+DI8PdCL3Ono+A87E8PZiMrTq5pPSw/M7WrnPay8TzGWJ3Hc1HZw lZ2mqZW2Wpj19QV8Q81k6dA9xYjGjYZUixdFN/7B/+3+Wj0SvtA+KOzyd7kPDhDvmfYUGSq6IEwjM 7cNTq6G5P+Gb3lVyXsStDR0CB70F442cG+aDU39fV+eK9v0riCAJnyyQDahh0nVQiRMc/MMzoAxjk +yCeCjc3ba0coolX6Fsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMyvl-009Umv-Tk; Tue, 31 Jan 2023 22:16:46 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pMyvi-009Um9-DX for linux-arm-kernel@lists.infradead.org; Tue, 31 Jan 2023 22:16:43 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CD12EB81EB5; Tue, 31 Jan 2023 22:16:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 763E9C433EF; Tue, 31 Jan 2023 22:16:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675203398; bh=Wolu3XhvZe+9nNY9wveQYWc3XVj4s/qvU+aEBr2FzQw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KnrdNzr0nB7m9IvMhey7MLntrx8MGXJP0nJgmnVwv1PltRKAnC+v09mletqP3j2tb gX+mriyG89Fj9UDs7QodYrNYqHs9Cmcu192TMrWK33e8XGkjK8woT/t6mvpCb86klG Vfm6kV+BJzwiupiqRxgxd+6kcy+Ddf65jJG1532ZRN69bFW7AX2ZuRuBI+i1M45pKj 0jozpHcaDsliR3u5rS+6XnHUAjTIQFSrhauFcHxgn3UR5TuA2oo5yPkjNKa0Dr0/cn SkE19wx2lZ3HPeDlbixdgby3pJgeTJD5KXOFV+12MSDMm2A0Qba6nlyTkrUvSOoPJN X9pIDBn5O16Sg== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pMyvb-006KxO-Ub; Tue, 31 Jan 2023 22:16:36 +0000 Date: Tue, 31 Jan 2023 22:16:35 +0000 Message-ID: <87y1picpto.wl-maz@kernel.org> From: Marc Zyngier To: Oliver Upton Cc: kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Alexandru Elisei , Andre Przywara , Chase Conklin , Christoffer Dall , Ganapatrao Kulkarni , Jintack Lim , Russell King , James Morse , Suzuki K Poulose , Zenghui Yu Subject: Re: [PATCH v8 09/69] KVM: arm64: nv: Reset VMPIDR_EL2 and VPIDR_EL2 to sane values In-Reply-To: References: <20230131092504.2880505-1-maz@kernel.org> <20230131092504.2880505-10-maz@kernel.org> <87zg9ycqdj.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: oliver.upton@linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alexandru.elisei@arm.com, andre.przywara@arm.com, chase.conklin@arm.com, christoffer.dall@arm.com, gankulkarni@os.amperecomputing.com, jintack@cs.columbia.edu, rmk+kernel@armlinux.org.uk, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230131_141642_769281_021977CB X-CRM114-Status: GOOD ( 24.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 31 Jan 2023 22:09:53 +0000, Oliver Upton wrote: > > On Tue, Jan 31, 2023 at 10:04:40PM +0000, Marc Zyngier wrote: > > On Tue, 31 Jan 2023 20:17:50 +0000, Oliver Upton wrote: > > > > > > On Tue, Jan 31, 2023 at 09:24:04AM +0000, Marc Zyngier wrote: > > > > From: Christoffer Dall > > > > > > > > The VMPIDR_EL2 and VPIDR_EL2 are architecturally UNKNOWN at reset, but > > > > let's be nice to a guest hypervisor behaving foolishly and reset these > > > > to something reasonable anyway. > > > > > > Must we be so kind? :) > > > > > > In all seriousness, I've found the hexspeak value of reset_unknown() to > > > be a rather useful debugging aid. And I can promise you that I'll use NV > > > to debug my own crap changes! > > > > > > Any particular reason against just using reset_unknown()? > > > > Because debugging NV itself is hell when all you have is a model! > > Blech! > > > As we were trying to debug the early code base, we really wanted to > > make it easy to run tiny guests without much setup, and work out of > > the box. That's how this sort of changes came about. > > > > In any case, something like this the hack below works as well (I just > > booted an L1 and a couple of L2s with it, and nothing caught fire). > > LGTM, mind squashing it into the previous patch? Sure thing. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel