From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A11DC54E94 for ; Wed, 25 Jan 2023 09:30:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+pv2oW1bGUPvIFR2zqwVix2RumhHqyHDkOtoUhs+0Ws=; b=1RGdhpue698VQ8 9kHrsb5qUX5PObxZnFrPC44+yIKum7mn5qe19nCHTfQYg9+97kaId4HtnfTAOG7bgwBd/QJcXCjgt D4XzqB5riwHPYaTfd/SjWRf50gH4NfkKENmsLIMLU6nKVVbOUOQkauhq8JmB1pRTol1e8hXDgPD7J RDIkwdy+GT3ayirBoyWK9fnkW9Jgg/CWAgvBgPqZtlxGv/xu6c3AbG4lEOBZd9Q3TMnCWZvUnuAAF tQSXYyIbw7+OWQKFraH3kL9xv0ocWdeTowyfe6I9Q/F8xH4QhGr1zo17Yl6pATOulFMQvDG0nOTmn M+G6XaFF929pJBB6vjKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKc69-006cgW-Fn; Wed, 25 Jan 2023 09:29:41 +0000 Received: from sender4-op-o14.zoho.com ([136.143.188.14]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKc66-006cey-7d for linux-arm-kernel@lists.infradead.org; Wed, 25 Jan 2023 09:29:40 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1674638971; cv=none; d=zohomail.com; s=zohoarc; b=Cqxpx+/WBy72ex2kZEIHyPo+naMFPb5kMYQvk6aLoIF0z0FzwG/QaAmMxje9kKuz8EMO2rWrQ7yS7SZ0wtrq31Z4FqHlLt5GodmPLgalDPo425Gd0HaxXZ+uQpDzYVfhZnQCySKo10ei9bgxHtC95bIBRJm06PX8uU8STZVOwFs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1674638971; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=xkUg3nf6OEkoY+au5DwmIp1JKRouLWwMmVa4vTYLlCw=; b=WEjQ7Y5tui0zAcLQjRcBeWTdwMI9eca3b7+V3vznKbB88U1PMIh0k9Zp4/EcnjYS6/TaloOnZ/AEGb2hz4/qZj8JdudfDV1pK5zxWG86oOG0hCH/1RAlvs0NNaIezzledt6I7UvU4Ug/MXwQ3SfbykI2KgBJh5DrEVl2zEjAS/Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=linux.beauty; spf=pass smtp.mailfrom=me@linux.beauty; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1674638971; s=zmail; d=linux.beauty; i=me@linux.beauty; h=Date:Date:Message-ID:From:From:To:To:Cc:Cc:Subject:Subject:In-Reply-To:References:MIME-Version:Content-Type:Message-Id:Reply-To; bh=xkUg3nf6OEkoY+au5DwmIp1JKRouLWwMmVa4vTYLlCw=; b=NZYVOFcgDjflfenyaZs5V94vkCwIPdSH92OhImxH2F0qo9kmlmT/D6iBfpZg8JWS AgFDMCg+CYFpQwKh/GjNjadB5x/yLszesuREGuWikO9LUhu3Lp3/XSZkMVCBZv6LFPS D3rfUwLiFrQDuNzLM8pUDl3hbNRSpxhYDV3YVfUE= Received: from lchen-xiaoxin.linux.beauty (221.225.241.248 [221.225.241.248]) by mx.zohomail.com with SMTPS id 16746389698191012.618366623598; Wed, 25 Jan 2023 01:29:29 -0800 (PST) Date: Wed, 25 Jan 2023 17:28:41 +0800 Message-ID: <87y1prgdyu.wl-me@linux.beauty> From: Li Chen To: Krzysztof Kozlowski Cc: Li Chen , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , "moderated list:ARM/Ambarella SoC support" , "open list:COMMON CLK FRAMEWORK" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: Re: [PATCH 07/15] dt-bindings: clock: Add Ambarella clock bindings In-Reply-To: <0c19efb4-3bca-f500-ca24-14b9d24369ef@linaro.org> References: <20230123073305.149940-1-lchen@ambarella.com> <20230123073305.149940-8-lchen@ambarella.com> <0c19efb4-3bca-f500-ca24-14b9d24369ef@linaro.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-ZohoMailClient: External X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230125_012938_324414_3A0693E0 X-CRM114-Status: GOOD ( 32.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, Sorry for my late reply. On Mon, 23 Jan 2023 16:11:08 +0800, Krzysztof Kozlowski wrote: > > On 23/01/2023 08:32, Li Chen wrote: > > This patch introduce clock bindings for Ambarella. > > > > Signed-off-by: Li Chen > > Change-Id: I29018a23ed3a5b79a1103e859a5c7ed7bb83a261 > > All the same problems plus new: > > Subject: drop second/last, redundant "bindings". The "dt-bindings" > prefix is already stating that these are bindings. Well noted. > > --- > > .../clock/ambarella,composite-clock.yaml | 52 ++++++++++++++++ > > .../bindings/clock/ambarella,pll-clock.yaml | 59 +++++++++++++++++++ > > MAINTAINERS | 2 + > > 3 files changed, 113 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/clock/ambarella,composite-clock.yaml > > create mode 100644 Documentation/devicetree/bindings/clock/ambarella,pll-clock.yaml > > > > diff --git a/Documentation/devicetree/bindings/clock/ambarella,composite-clock.yaml b/Documentation/devicetree/bindings/clock/ambarella,composite-clock.yaml > > new file mode 100644 > > index 000000000000..fac1cb9379c4 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/ambarella,composite-clock.yaml > > @@ -0,0 +1,52 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/clock/ambarella,composite-clock.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Ambarella Composite Clock > > + > > +maintainers: > > + - Li Chen > > + > > Missing description. Thanks, description as below will be added in v2: "Ambarella SoCs integrates some composite clocks, like uart0, which aggrate the functionality of the basic clock types, like mux and div." > > +properties: > > + compatible: > > + items: > > Drop items. Ok. > > + - const: ambarella,composite-clock > > Missing SoC specific compatible. This is anyway not really correct > compatible... Most Ambarella's compatibles don't contain SoC name, because we prefer to use syscon + offsets in dts to tell driver the correct register offsets, or ues struct soc_device and SoC identity stores in a given physical address. So compatibles like "ambarella,composite-clock" and "ambarella,pinctrl" are used widely in Ambarella kernels. Feel free to correct me if you think this is not a good idea. > > + > > + clocks: true > > No, needs constraints. Ok. I will list all clocks name > > + assigned-clocks: true > > + assigned-clock-parents: true > > + assigned-clock-rates: true > > Drop these three. Ok > > + clock-output-names: true > > Missing constraints. Ok, I will add "maxItems: 1" > > + amb,mux-regmap: true > > NAK. > > It's enough. The patches have very, very poor quality. > > Missing description, missing type/$ref, wrong prefix. Sorry, I forget to run dt_binding_check, I will spend some time learning the binding and check, sorry for it. > > + amb,div-regmap: true > > + amb,div-width: true > > + amb,div-shift: true > > These two are arguments to phandle. I will add description and $ref to regmap and width/shift. > > + > > + '#clock-cells': > > + const: 0 > > + > > +required: > > + - compatible > > + - reg > > + - clocks > > + - '#clock-cells' > > + > > +additionalProperties: false > > So why you decided to add it here and not in other places? I didn't understand it well. I will add it to other places in v2, thanks for pointint out it. > > + > > +examples: > > + - | > > + gclk_uart0: gclk-uart0 { > > Wrong indentation. Well noted. > > + #clock-cells = <0>; > > + compatible = "ambarella,composite-clock"; > > + clocks = <&osc>, <&gclk_core>, <&pll_out_enet>, <&pll_out_sd>; > > + clock-output-names = "gclk_uart0"; > > + assigned-clocks = <&gclk_uart0>; > > + assigned-clock-parents = <&osc>; > > + assigned-clock-rates = <24000000>; > > + amb,mux-regmap = <&rct_syscon 0x1c8>; > > + amb,div-regmap = <&rct_syscon 0x038>; > > + amb,div-width = <24>; > > + amb,div-shift = <0>; > > + }; > > diff --git a/Documentation/devicetree/bindings/clock/ambarella,pll-clock.yaml b/Documentation/devicetree/bindings/clock/ambarella,pll-clock.yaml > > new file mode 100644 > > index 000000000000..65c1feb60041 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/ambarella,pll-clock.yaml > > @@ -0,0 +1,59 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/clock/ambarella,pll-clock.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Ambarella PLL Clock > > + > > +maintainers: > > + - Li Chen > > + > > +properties: > > + compatible: > > + enum: > > + - ambarella,pll-clock > > + - ambarella,clkpll-v0 > > + > > +if: > > No, this does not work like that. It sits under "allOf", located after > "required:". Thanks, I will learn "allOf" and use it in v2. BTW, we use the two compatibles as below: clocks { compatible = "ambarella,clkpll-v0"; ... gclk_core: gclk-core { #clock-cells = <0>; compatible = "ambarella,pll-clock"; clocks = <&osc>; clock-output-names = "gclk_core"; amb,clk-regmap = <&rct_syscon 0x000 0x004 0x100 0x104 0x000 0x000>; }; ... } I'm not sure can I describe the two compatibles in this single yaml, can you give some advice? thanks! > > + properties: > > + compatible: > > + const: ambarella,pll-clock > > + > > +then: > > + properties: > > + clocks: > > + maxItems: 1 > > + > > + clock-output-names: true > > + amb,clk-regmap: true > > + amb,frac-mode: true > > + assigned-clocks: true > > + assigned-clock-rates: true > > Same problems. Ok. > > + gclk_axi: gclk-axi { > > + #clock-cells = <0>; > > + compatible = "fixed-factor-clock"; > > What is this example about? Not related at all. Provide real example. Sorry, I paste the wrong example, I will replace it with our gclk_core pll instead. Regards, Li _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel