From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BC99C43603 for ; Tue, 10 Dec 2019 11:42:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E550206D5 for ; Tue, 10 Dec 2019 11:42:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="D6T1EYD1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E550206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ThKNeSeghbMSSILPXsjcxvJZo7DQTNXgwed2dwqXJKI=; b=D6T1EYD1CHKCxXOIjeMh1UFbj HrHtbq9JKz3yVpB22lEf7W6omzNiR7HkLXTgsD08aRwStFisJ1k8V/LUf0DZMpFH/8Z5GidfXVUGK SbXU1QjqbD3op165B8SEfWbHxhv55RUiDcMidOkQYWU2FslyJY4RbYHzbqQ+L8vVkuALw0ANlLuSj FaqnOY3lpfvswAN2P7UQnK5XOBau9chWRwlO1RiPhan+p1JZyVo1ra3siqAIhNQ+MbqhclFlJ2C0Q e+OmwjxxpDShgiQEuubyY3xZVjUIm93oacyUeccixsTaoObhSgQ+PjvztRugt9dreoHprCyLcFilt BWrH8ya8g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iedue-0003dl-Np; Tue, 10 Dec 2019 11:42:44 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iedub-0003dL-Dl; Tue, 10 Dec 2019 11:42:43 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: aratiu) with ESMTPSA id 92096291A06 From: Adrian Ratiu To: Philippe CORNU , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-rockchip@lists.infradead.org" Subject: Re: [Linux-stm32] [PATCH v4 0/4] Genericize DW MIPI DSI bridge and add i.MX 6 driver In-Reply-To: References: <20191202193359.703709-1-adrian.ratiu@collabora.com> Date: Tue, 10 Dec 2019 13:43:03 +0200 Message-ID: <87y2vk1k54.fsf@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191210_034241_724266_4436ADDA X-CRM114-Status: GOOD ( 16.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "kernel@collabora.com" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-imx@nxp.com" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 06 Dec 2019, Philippe CORNU wrote: > Hi Adrian, > > And sorry for this late reply. Your patches look good and we > ("stm guys") understand that v1.01 is very different to > v1.30/31. > > We are doing our best to review & test your patches and we will > go back to you asap. Many thanks, Philippe :-) Hi Philippe, Thank you for taking the time to test this, I really appreciate it. Adrian > > > On 12/2/19 8:33 PM, Adrian Ratiu wrote: >> Having a generic Synopsis DesignWare MIPI-DSI host controller bridge >> driver is a very good idea, however the current implementation has >> hardcoded quite a lot of the register layouts used by the two supported >> SoC vendors, STM and Rockchip, which use IP cores v1.30 and v1.31. >> >> This makes it hard to support other SoC vendors like the FSL/NXP i.MX 6 >> which use older v1.01 cores or future versions because, based on history, >> layout changes should also be expected in new DSI versions / SoCs. >> >> This patch series converts the bridge and platform drivers to access >> registers via generic regmap APIs and allows each platform driver to >> configure its register layout via struct reg_fields, then adds support >> for the host controller found on i.MX 6. >> >> I only have i.MX hardware with MIPI-DSI panel and relevant documentation >> available for testing so I'll really appreciate it if someone could test >> the series on Rockchip and STM... eyeballing register fields could only >> get me so far, so sorry in advance for any breakage! >> >> Many thanks to Boris Brezillon for >> suggesting the regmap solution and to Liu Ying >> for doing the initial i.MX platform driver implementation. >> >> This series applies on top of latest linux-next tree, next-20191202. >> >> v3 -> v4: >> * Added commmit message to dt-binding patch (Neil) >> * Converted the dt-binding to yaml dt-schema format (Neil) >> * Small DT node + driver fixes (Rob) >> * Renamed platform driver to reflect it's only for i.MX v6 (Fabio) >> * Added small panel example to the host controller DT binding >> >> v2 -> v3: >> * Added const declarations to dw-mipi-dsi.c structs (Emil) >> * Fixed Reviewed-by tags and cc'd some more relevant ML (Emil) >> >> v1 -> v2: >> * Moved register definitions & regmap initialization into bridge >> module. Platform drivers get the regmap via plat_data after calling >> the bridge probe (Emil). >> >> Adrian Ratiu (4): >> drm: bridge: dw_mipi_dsi: access registers via a regmap >> drm: bridge: dw_mipi_dsi: abstract register access using reg_fields >> drm: imx: Add i.MX 6 MIPI DSI host driver >> dt-bindings: display: add i.MX6 MIPI DSI host controller doc >> >> .../display/imx/fsl,mipi-dsi-imx6.yaml | 136 ++++ >> drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 699 +++++++++++++----- >> drivers/gpu/drm/imx/Kconfig | 7 + >> drivers/gpu/drm/imx/Makefile | 1 + >> drivers/gpu/drm/imx/dw_mipi_dsi-imx6.c | 378 ++++++++++ >> .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 17 +- >> drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 34 +- >> include/drm/bridge/dw_mipi_dsi.h | 2 +- >> 8 files changed, 1067 insertions(+), 207 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml >> create mode 100644 drivers/gpu/drm/imx/dw_mipi_dsi-imx6.c >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel