From: robert.jarzmik@free.fr (Robert Jarzmik)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ASoC: pxa: add binding for pxa2xx-ac97 audio complex
Date: Wed, 13 Jun 2018 21:00:19 +0200 [thread overview]
Message-ID: <87y3fiqzp8.fsf@belgarion.home> (raw)
In-Reply-To: <20180612221359.GA26741@rob-hp-laptop> (Rob Herring's message of "Tue, 12 Jun 2018 16:13:59 -0600")
Rob Herring <robh@kernel.org> writes:
> On Mon, Jun 11, 2018 at 10:22:10PM +0200, Robert Jarzmik wrote:
>> This adds a binding for the Marvell PXA audio complex, available in
>> pxa2xx and pxa3xx variants.
>> +Required properties:
>> + - compatible: "marvell,pxa2xx-ac97"
>
> Don't use wildcards in compatible strings. Though this is so old...
Yes, I could use pxa270-ac97.
>> + - reset-gpio: gpio used for AC97 reset, refer to gpio.txt
> reset-gpios
Right, I'm on it.
>> + status = "okay";
>
> Don't show status in examples.
Sure.
Cheers.
--
Robert
next prev parent reply other threads:[~2018-06-13 19:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 20:22 [PATCH 1/2] ASoC: pxa: add binding for pxa2xx-ac97 audio complex Robert Jarzmik
2018-06-11 20:22 ` [PATCH 2/2] ASoC: pxa: add devicetree support Robert Jarzmik
2018-06-12 22:13 ` [PATCH 1/2] ASoC: pxa: add binding for pxa2xx-ac97 audio complex Rob Herring
2018-06-13 19:00 ` Robert Jarzmik [this message]
2018-06-14 13:48 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3fiqzp8.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox