From mboxrd@z Thu Jan 1 00:00:00 1970 From: robert.jarzmik@free.fr (Robert Jarzmik) Date: Sun, 22 Jan 2017 11:25:26 +0100 Subject: [PATCH v3 01/15] ARM: pxa: Don't rely on public mmc header to include leds.h In-Reply-To: <87a8aleda2.fsf@belgarion.home> (Robert Jarzmik's message of "Fri, 20 Jan 2017 20:34:29 +0100") References: <1484313256-25993-1-git-send-email-ulf.hansson@linaro.org> <1484313256-25993-2-git-send-email-ulf.hansson@linaro.org> <87efzydusi.fsf@belgarion.home> <87a8aleda2.fsf@belgarion.home> Message-ID: <87y3y3crxl.fsf@belgarion.home> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Robert Jarzmik writes: > Ulf Hansson writes: > >> On 20 January 2017 at 09:01, Robert Jarzmik wrote: >>> Ulf Hansson writes: >>> So I was wondering how you made the choice of which files you add the include to >>> and which you don't touch ? >> >> By building the pxa_defconfig, see what errors it reports and then fix them. >> >> Isn't pxa_defconfig building all the variants? > Euh actually it should, but it's not. And actually thanks to a suggestion from Russell to improve my search line, I came up with the command line bellow, and perhaps you could fix the others with one command line and respin the patch ? Here it is : for f in $(grep -l _led arch/arm/mach-pxa/*.c | xargs grep -L linux/leds.h); do sed -i '0,/^#include $/{s/\(#include \n\1/}' $f; done Cheers. -- Robert