linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: kuninori.morimoto.gx@gmail.com (Kuninori Morimoto)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] usb: renesas_usbhs: add R-Car Gen. 2 init and power control
Date: Tue, 08 Jul 2014 17:08:48 -0700 (PDT)	[thread overview]
Message-ID: <87y4w3v1fa.wl%kuninori.morimoto.gx@gmail.com> (raw)
In-Reply-To: <1404831571-19817-1-git-send-email-ulrich.hecht+renesas@gmail.com>


Hi Ulrich

Thank you for your patch

> In preparation for DT conversion to reduce reliance on platform device
> callbacks.
> 
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
(snip)
> @@ -186,6 +192,8 @@ struct renesas_usbhs_platform_info {
>  	 * driver use these param for some register
>  	 */
>  	struct renesas_usbhs_driver_param	driver_param;
> +
> +	struct usb_phy *phy;
>  };

Using renesas_usbhs_platform_info for *phy is not good idea from my point of view.
Because its memory is located on platform side.
(this is the reason why usbhs_probe() using memcpy() for getting info->xxx)

I guess struct usbhs_priv is good place,
and you can use usbhs_pdev_to_priv() for this purpose ?

Best regards
---
Kuninori Morimoto

  parent reply	other threads:[~2014-07-09  0:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-08 14:59 [PATCH 1/2] usb: renesas_usbhs: add R-Car Gen. 2 init and power control Ulrich Hecht
2014-07-08 14:59 ` [PATCH 2/2] ARM: shmobile: lager: remove USBHS callbacks Ulrich Hecht
2014-07-09  0:08 ` Kuninori Morimoto [this message]
2014-07-09 10:11   ` [PATCH 1/2] usb: renesas_usbhs: add R-Car Gen. 2 init and power control Ulrich Hecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y4w3v1fa.wl%kuninori.morimoto.gx@gmail.com \
    --to=kuninori.morimoto.gx@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).