From: khilman@linaro.org (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmc: dw_mmc: fix dw_mci_get_cd
Date: Thu, 16 Jan 2014 10:29:40 -0800 [thread overview]
Message-ID: <87y52fok4r.fsf@linaro.org> (raw)
In-Reply-To: <1389876527-13498-1-git-send-email-zhangfei.gao@linaro.org> (Zhangfei Gao's message of "Thu, 16 Jan 2014 20:48:47 +0800")
Zhangfei Gao <zhangfei.gao@linaro.org> writes:
> Introduced from commit bf626e5550f24aec24975a0e85ad8e572ca76a6b
> CDETECT is ignored since negated return value of mmc_gpio_get_cd(mmc)
> can not be checked by IS_ERR_VALUE.
> Add spin_lock_bh(&host->lock) for atomic accessing DW_MMC_CARD_PRESENT,
> otherwise sd detect may occasionally fail.
>
> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> Reported-by: Kevin Hilman <khilman@linaro.org>
> Reviewed-by: Sachin Kamat <sachin.kamat@linaro.org>
> Tested-by: Sachin Kamat <sachin.kamat@linaro.org>
I didn't look at the patch in detail, but can at least confirm that
Arndale boots again in -next with this patch applied.
Tested-by: Kevin Hilman <khilman@linaro.org>
Kevin
next prev parent reply other threads:[~2014-01-16 18:29 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 2:31 [PATCH v2] mmc: dw_mmc: fix dw_mci_get_cd Zhangfei Gao
2014-01-16 10:50 ` Arnd Bergmann
2014-01-16 12:34 ` zhangfei
2014-01-16 12:48 ` [PATCH] " Zhangfei Gao
2014-01-16 18:29 ` Kevin Hilman [this message]
2014-01-17 12:35 ` Seungwon Jeon
2014-01-17 14:25 ` Chris Ball
-- strict thread matches above, loose matches on Subject: below --
2014-01-14 15:58 [PATCH 1/3] mmc: dw_mmc: use slot-gpio to handle cd pin Kevin Hilman
2014-01-15 7:15 ` [PATCH] mmc: dw_mmc: fix dw_mci_get_cd Zhangfei Gao
2014-01-15 7:31 ` zhangfei
2014-01-15 10:07 ` Zhangfei Gao
2014-01-15 11:58 ` Seungwon Jeon
2014-01-15 12:10 ` zhangfei
2014-01-15 12:26 ` Seungwon Jeon
2014-01-15 13:56 ` zhangfei
2014-01-15 13:59 ` Arnd Bergmann
2014-01-15 14:20 ` Arnd Bergmann
2014-01-15 15:36 ` zhangfei
2014-01-15 16:01 ` Russell King - ARM Linux
2014-01-15 16:07 ` Arnd Bergmann
2014-01-15 16:22 ` Russell King - ARM Linux
2014-01-16 2:10 ` zhangfei
2014-01-16 11:12 ` Arnd Bergmann
2014-01-16 11:25 ` Russell King - ARM Linux
2014-01-15 14:38 ` Seungwon Jeon
2014-01-15 15:32 ` zhangfei
2014-01-15 15:51 ` Zhangfei Gao
2014-01-15 15:59 ` Russell King - ARM Linux
2014-01-15 15:54 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y52fok4r.fsf@linaro.org \
--to=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).