From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@linaro.org (Kevin Hilman) Date: Thu, 16 Jan 2014 10:29:40 -0800 Subject: [PATCH] mmc: dw_mmc: fix dw_mci_get_cd In-Reply-To: <1389876527-13498-1-git-send-email-zhangfei.gao@linaro.org> (Zhangfei Gao's message of "Thu, 16 Jan 2014 20:48:47 +0800") References: <1389839502-13046-1-git-send-email-zhangfei.gao@linaro.org> <1389876527-13498-1-git-send-email-zhangfei.gao@linaro.org> Message-ID: <87y52fok4r.fsf@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Zhangfei Gao writes: > Introduced from commit bf626e5550f24aec24975a0e85ad8e572ca76a6b > CDETECT is ignored since negated return value of mmc_gpio_get_cd(mmc) > can not be checked by IS_ERR_VALUE. > Add spin_lock_bh(&host->lock) for atomic accessing DW_MMC_CARD_PRESENT, > otherwise sd detect may occasionally fail. > > Signed-off-by: Zhangfei Gao > Reported-by: Kevin Hilman > Reviewed-by: Sachin Kamat > Tested-by: Sachin Kamat I didn't look at the patch in detail, but can at least confirm that Arndale boots again in -next with this patch applied. Tested-by: Kevin Hilman Kevin