From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@ti.com (Kevin Hilman) Date: Wed, 21 Mar 2012 07:06:30 -0700 Subject: [PATCH v4 RESEND 6/7] gpio/omap: fix incorrect update to context.irqenable1 In-Reply-To: (Tarun Kanti DebBarma's message of "Wed, 21 Mar 2012 10:31:48 +0530") References: <1332240799-6748-1-git-send-email-tarun.kanti@ti.com> <1332240799-6748-7-git-send-email-tarun.kanti@ti.com> <87zkbbywwz.fsf@ti.com> Message-ID: <87y5qurqu1.fsf@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org "DebBarma, Tarun Kanti" writes: > On Wed, Mar 21, 2012 at 8:10 AM, DebBarma, Tarun Kanti > wrote: >> On Tue, Mar 20, 2012 at 11:31 PM, Kevin Hilman wrote: >>> Tarun Kanti DebBarma writes: >>> >>>> In _enable_gpio_irqbank() when bank->regs->set_irqenable is valid, >>>> gpio_mask can be directly set by writing to set_irqenable register >>>> without overwriting current value. In order to ensure the same is >>>> stored in context.irqenable1, we must read from regs->irqenable >>>> instead of overwriting it with gpio_mask. >>> >>>> The overwriting makes sense only in the second case where irqenable >>>> is explicitly read and updated with new gpio_mask before writing it >>>> back. However, for consistency reading regs->irqenable into the >>>> bank->context.irqenable1 takes care of both the scenarios. >>> >>> ...except that the code doesn't do this anymore. >> Yes. >>> >>> I like the newer version (I hope so, since I suggested it :), but please >>> update the changlog to describe what the code is actually doing. >> Sure. > I have updated the change log here: > git://gitorious.org/~tarunkanti/omap-sw-develoment/tarunkantis-linux-omap-dev > for_3.4/gpio_more_fixes Please also post and updated version of the patch for review. Kevin