From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 666EBC3DA4A for ; Sat, 27 Jul 2024 09:26:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QqgoJW7g7u7HqVS4qFxDoO7rT/lHn05xZnz3i/ktMoQ=; b=0CpJgy40XaO1CSMGg//tqXaMca NeGMl43uLwzEWEVEVzW1oaTRz2WE52tuh103LMr3p87+a4o3SeGjcuWXgFDDNo/uMxeZGPxZXyeX5 Cb6UHnvLXXq3TWUCVLX/snPs1mdHF+xp6qpT5Iu1aj9jvPfOqOti7/sL5TTJrqRD4acirE89fEzjG ExBSfZINFouD6PllIBbZsbDH7Hr9ezcfpG8QYxGKczx8myHzYhytKm/HQaTHpF/w+e1zp0tnEeFg9 4D2Zm+1ZX6Jzr7RSh7RiTOttOijhLoKG/NPL7fUiRvYo2uPKnElRqGf3kAJHBwRqaGSnXeNsCrVsC qlyT7q8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXdgZ-00000006Ogc-2eR7; Sat, 27 Jul 2024 09:25:55 +0000 Received: from galois.linutronix.de ([193.142.43.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXdg6-00000006Oa7-1Jzi for linux-arm-kernel@lists.infradead.org; Sat, 27 Jul 2024 09:25:29 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1722072323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QqgoJW7g7u7HqVS4qFxDoO7rT/lHn05xZnz3i/ktMoQ=; b=lbm+CFvAwWkc+6r0ahaP1ILMnN0DRfy+3/67vnyXKccqve05wp5UJJzWkaDCazI04LvEHp iMkBmHPSQOG0d/ULkYaJOL/YrN5MKgDAnsNfeRL7HbXllunH72ZmIqoy1P4DKwJuFU+Sqg WUqvn3B/kw5Q02aJj+82QvJLrDX3knJZaWww/gfugOXR/SdfDP2p0axNv7KTmzNiEL23vW NkJpiHbgddvxGY4HJ0mZA7SllNDsAkbVx/zcOsuNYpRe2A6kM6bQ94LEO3Qc0np5F+WkoC l+Jllv0jMaNa6lTScS5QwymJB5DaayfN46aNtfDGysJ+elroBlDdMN7D9szlQQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1722072323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QqgoJW7g7u7HqVS4qFxDoO7rT/lHn05xZnz3i/ktMoQ=; b=1WpClalEFCiFnT5MaUoBCEIIWNB2v+tWCBbNCItXXPozuAo7lchhN7/0GcsMP8CSy1gXrx A/1aFNJlvNc2UuBg== To: Jinjie Ruan , maz@kernel.org, joey.gouly@arm.com, mark.rutland@arm.com, will@kernel.org, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: ruanjinjie@huawei.com Subject: Re: [PATCH] irqchip/gic-v3: Remove asmlinkage for gic_handle_irq() In-Reply-To: <20240727073648.1042377-1-ruanjinjie@huawei.com> References: <20240727073648.1042377-1-ruanjinjie@huawei.com> Date: Sat, 27 Jul 2024 11:25:23 +0200 Message-ID: <87zfq3tce4.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240727_022526_530279_065D5E09 X-CRM114-Status: UNSURE ( 7.85 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jul 27 2024 at 15:36, Jinjie Ruan wrote: > Since commit 064dbfb41691 ("arm64: entry: convert IRQ+FIQ handlers to C"), > the gic_handle_irq() is only called by C functions, so remove > the asmlinkage. > > Fixes: 064dbfb41691 ("arm64: entry: convert IRQ+FIQ handlers to C") > Signed-off-by: Jinjie Ruan Right. Can we please fix all of that and be done with it? # git grep -l asmlinkage drivers/irqchip/ | xargs grep set_handle_irq should find the remaining leftovers of asmlinkage. Thanks, tglx