From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87D39C4332F for ; Sat, 15 Oct 2022 09:05:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References :In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NbRiq882wj/IphKhj99Od8xKRgWdjN4LvulhHJD2t2c=; b=lRsiVdnoFa6ES7 W4R2BxKrrWVemXxfgFZ+RQlfTNJRsbOsthEYQb/cWisG2Sh9P/ppnKEHI7xT1eJkRVhSbNAu0QUaD QirgU18/EMcjFwYR5K088usauiCCz1+zj0aIwjBMVScNjqYFhQSUvf6WLNsxszf/kJ4LVHR+CfeQg 3SoBpz3QV44NU6+0KU2x2vlNtDjO5gSJIgss6dMwZLLabi1tVgYzzCEjU83zhRtj76lE5MKsluVii MkRtaQdDGWX1Oq+W+mgjKIvall9KtAX5h5LVmc07Y7G9RLsX9dnwv+uPscEJuzuaEpEcFOGPRfpR7 57fO38AfBXyG0V+DQ7Dg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ojd6D-00Gg32-GY; Sat, 15 Oct 2022 09:04:53 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ojd69-00Gg1o-U2 for linux-arm-kernel@lists.infradead.org; Sat, 15 Oct 2022 09:04:51 +0000 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1665824688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=O2r2z/z0hDoo2fh70QGYrUogL6TlcVgEKV7x78z66rk=; b=wZ3A/EFb4G6uurDA8QKXiizxdoxYR3Jam1s3WZDYV9AObyHEPUyugqKotgGPGlttpyyqbZ 00CYpl+9rAbhzgpo5OEbXraxPEry/QZhxbNDaQXpaN9HXZ6qzRd0FVBn8P43g8E7BmSENn 1jln89FlJtjTWT78Ie4yq6ppn+aa0g9pXTGAg+CggXj0qaq1QSor9+tCjlxixo2J/6RqT5 XGHvewENPpjNtEzTJiWGAF+U9W6OXxpHldZoJ/3rcjIeeMMLuEWPWMj83FusJ0vVWoKPUM /XKixrvwt8PUouDljQLgmXXAkkTZesN2jyn40BPx2Gm36cCscOkcBIZvItMVag== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1665824688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=O2r2z/z0hDoo2fh70QGYrUogL6TlcVgEKV7x78z66rk=; b=Aduh0A0cNaJ8nQRyYpvXMx8W9EFOUe8/aIlhdsZRrdSd91ovdKPL4JuxWEfVfJ6qnyXeSn IAeKSJxHo4/48yAg== To: Victor Hassan , daniel.lezcano@linaro.org, wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org, maxime@cerno.tech Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [RESEND] clocksource: sun4i: Fix the bug that tick_resume stucks In-Reply-To: <20221009032507.39145-1-victor@allwinnertech.com> References: <20221009032507.39145-1-victor@allwinnertech.com> Date: Sat, 15 Oct 2022 11:04:47 +0200 Message-ID: <87zgdxa24w.ffs@tglx> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221015_020450_128266_D0071965 X-CRM114-Status: UNSURE ( 8.30 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Oct 09 2022 at 11:25, Victor Hassan wrote: > Currently syscore_resume() will stuck on tick_resume(). This lacks a clear explanation of the problem, i.e. WHY the current implementation is not working. > Fix this by changing `.tick_resume` from > sun4i_clkevt_shutdown() to a new function sun4i_tick_resume(). > > -static struct timer_of to = { > - .flags = TIMER_OF_IRQ | TIMER_OF_CLOCK | TIMER_OF_BASE, How is switching from a statically allocated struct to a runtime allocated struct related to the problem? Thanks, tglx _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel