From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: "Marek Behún" <kabel@kernel.org>, linux-arm-kernel@lists.infradead.org
Cc: pali@kernel.org, "Josef Schlehofer" <josef.schlehofer@nic.cz>,
"Marek Behún" <kabel@kernel.org>
Subject: Re: [PATCH mvebu/dt 1/2] ARM: dts: turris-omnia: configure LED[0] pin function to link/activity
Date: Mon, 18 Jul 2022 12:42:48 +0200 [thread overview]
Message-ID: <87zgh6r9av.fsf@BL-laptop> (raw)
In-Reply-To: <20220704113622.18887-1-kabel@kernel.org>
Marek Behún <kabel@kernel.org> writes:
> The marvell PHY driver changes the LED[0] pin function to "On - 1000
> Mbps Link, Off - Else".
>
> Turris Omnia expects that the function is "On - Link, Blink - Activity,
> Off - No link".
>
> Use the `marvell,reg-init` DT property to change the function.
>
> In the future, once netdev trigger will support HW offloading, we will
> be able to have this configured via the combination of PHY driver and
> leds-turris-omnia driver.
>
> Signed-off-by: Marek Behún <kabel@kernel.org>
Applied on mvebu/dt
Thanks,
Gregory
> ---
> arch/arm/boot/dts/armada-385-turris-omnia.dts | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> index f4878df39753..1583c4b14ae8 100644
> --- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
> +++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
> @@ -397,7 +397,8 @@ &mdio {
> phy1: ethernet-phy@1 {
> compatible = "ethernet-phy-ieee802.3-c22";
> reg = <1>;
> - marvell,reg-init = <3 18 0 0x4985>;
> + marvell,reg-init = <3 18 0 0x4985>,
> + <3 16 0xfff0 0x0001>;
>
> /* irq is connected to &pcawan pin 7 */
> };
> --
> 2.35.1
>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-07-18 10:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 11:36 [PATCH mvebu/dt 1/2] ARM: dts: turris-omnia: configure LED[0] pin function to link/activity Marek Behún
2022-07-04 11:36 ` [PATCH mvebu/dt 2/2] ARM: dts: turris-omnia: enable LED controller node Marek Behún
2022-07-18 10:43 ` Gregory CLEMENT
2022-07-18 10:42 ` Gregory CLEMENT [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgh6r9av.fsf@BL-laptop \
--to=gregory.clement@bootlin.com \
--cc=josef.schlehofer@nic.cz \
--cc=kabel@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=pali@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).