From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69694C43334 for ; Sun, 17 Jul 2022 10:44:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g/Ek4LL06j/JSLiBeNgYt45GiLBUIPLsEV97z6ZZAEA=; b=azJ4bIdalaNW5f E+cbo2gLDGqSubyjCY3+lo8T8y+BTi71fbMpsH47b+Y6/nCc9ndQcr4WYFNrxcBMBg22RQPoLC7hl Uj2dfEe6/Hwg3d0BqHyo5ffYZNnD9blAheUWjmWzA4Jz/RQQ4Qvhfqu7dg+3V2vPFUcHjyNpmzagF 2NQ/ojf824a6Szsa91lotRa3JgDCT/beT45rQloXUZeYL4GdpO/9i8V09BtlPno2H0QV0x3x8Y/VJ /EpYY7f0XE83V08s9+PrDL2C3d119h0tdB6s1v3D9hrqkLAabRkR3em67xU3LZafpVpx/t4UM9Sx/ uNBOfEb5zksN7q3kiLjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oD1kJ-006P2j-IW; Sun, 17 Jul 2022 10:43:31 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oD1kF-006P1N-QM for linux-arm-kernel@lists.infradead.org; Sun, 17 Jul 2022 10:43:29 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 723D4B80CBF; Sun, 17 Jul 2022 10:43:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F299BC3411E; Sun, 17 Jul 2022 10:43:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658054604; bh=iSE5dgUJcHMVav4waBygNS5QidjTiMxbKVsgdaFAqYs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pSDnm/bUaknyQUw4WtskGPATYLxLnKQCfWgTvIyHJgF8uJ1HwYJwGUwYPajhfd8EY vldkMUD69pMh3b4/VLKtDGI3NPX+y21m65HxI4woQSD8kQYIbrpXNee4J0AniDuCTS 1VfZ/eNRglHrZ5Qav54KI0RpKu0tNb4T9pklF7cWdmsQH31XTrFJgMtzOdB9PECj17 k27QfWcp5CV1xxm+6OlrG98awCowRoP9FsrFfF+7As3oAFfVd+5jvdsYpbSKllBqLX u/pc9AYjEOugirgq0RP5Hsd0PaWNfE88DoSm5u/v3TqKfEx8FA8EmuH1TZESnqaMTB pAdNh05imlNWg== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oD1k9-007zpX-Tw; Sun, 17 Jul 2022 11:43:22 +0100 Date: Sun, 17 Jul 2022 11:43:21 +0100 Message-ID: <87zgh8yq7q.wl-maz@kernel.org> From: Marc Zyngier To: Kalesh Singh Cc: mark.rutland@arm.com, broonie@kernel.org, madvenka@linux.microsoft.com, tabba@google.com, will@kernel.org, qperret@google.com, android-mm@google.com, kernel-team@android.com, James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: Fix hypervisor address symbolization In-Reply-To: <20220715235824.2549012-1-kaleshsingh@google.com> References: <20220715235824.2549012-1-kaleshsingh@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: kaleshsingh@google.com, mark.rutland@arm.com, broonie@kernel.org, madvenka@linux.microsoft.com, tabba@google.com, will@kernel.org, qperret@google.com, android-mm@google.com, kernel-team@android.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220717_034328_199413_740743CD X-CRM114-Status: GOOD ( 22.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 16 Jul 2022 00:58:24 +0100, Kalesh Singh wrote: > > With CONFIG_RANDOMIZE_BASE=y vmlinux addresses will resolve correctly I guess you mean *incorrectly* here, right? > from kallsyms. Fix this by adding the KASLR offset before printing the > symbols. > > Based on arm64 for-next/stacktrace. In general, place these remarks after the '---' line, as they don't really make sense in the commit itself (which is likely to be merged on a different base anyway). > > Fixes: 6ccf9cb557bd ("KVM: arm64: Symbolize the nVHE HYP addresses") > Reported-by: Fuad Tabba > Signed-off-by: Kalesh Singh > --- > arch/arm64/kvm/handle_exit.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kvm/handle_exit.c b/arch/arm64/kvm/handle_exit.c > index f66c0142b335..e43926ef2bc2 100644 > --- a/arch/arm64/kvm/handle_exit.c > +++ b/arch/arm64/kvm/handle_exit.c > @@ -347,10 +347,10 @@ void __noreturn __cold nvhe_hyp_panic_handler(u64 esr, u64 spsr, > kvm_err("nVHE hyp BUG at: %s:%u!\n", file, line); > else > kvm_err("nVHE hyp BUG at: [<%016llx>] %pB!\n", panic_addr, > - (void *)panic_addr); > + (void *)(panic_addr + kaslr_offset())); > } else { > kvm_err("nVHE hyp panic at: [<%016llx>] %pB!\n", panic_addr, > - (void *)panic_addr); > + (void *)(panic_addr + kaslr_offset())); > } > > /* > I'll fix the above as I apply the patch, no need to respin. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel