From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A78FFC433E2 for ; Mon, 7 Sep 2020 10:40:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5486C20738 for ; Mon, 7 Sep 2020 10:40:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RxsxgYxF"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="2Wie+WkE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5486C20738 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:To:From: Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aC9R2zB6jqFnkmDoKN8sinMXi1Ld96J3/X9QrQNHXyU=; b=RxsxgYxFLHZKPw22LSFe1j5iG Jvkx7tSgS0W6jXGcf2UdYLWJ7Q+SzLRRMMe3uJugMEd8EtpGmdoEk4/SPf+3I3+wQqHNzLJPo/pwf pB6Lamvu4TXhhihp9q85VhuANJKlGL8/yhxSsd19m6Ki2Eur4wg3ZUmyKAXorfcHe0MKk+BOTfACG cpEqR1/IPIpRz214sYqEaCGBy9bkYGmQbdl4OTgdrrYIbh6JsGbQmIybcIGlKP8z9z4sXO1TB5jfS 6abEYIgSP3kKnsfpiZN14xDUgKrUmt3PzCMULMzs8P9lud2JdYp9aHaeTyTptjs9AbhOUXHGbkTbx I2sGZ4vRQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFEYE-0007mG-Lz; Mon, 07 Sep 2020 10:39:06 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFEXr-0007bl-My for linux-arm-kernel@lists.infradead.org; Mon, 07 Sep 2020 10:38:45 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5AD0B20738; Mon, 7 Sep 2020 10:38:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599475122; bh=H2zHLW+oJBfNU+V+o/hZ1kbOu3tUvHUQGfWA5z2MjJ4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=2Wie+WkEpBuiVpWC9ofKFwXkMLI1rcFab8jei5mgY8Yr/Jv+gqjznDPaFXNqFqvJX NN9RWx6JS1s1QS1/mNPR+sOyd3C25pOYe5FqmpZYTvOVN85/FGQsGqX4kw+REswFky Q4ga4b/w9GZd9GFqyiHOVwzdhmfGD7DUN8EOzt2g= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFEXn-009jtD-Bu; Mon, 07 Sep 2020 11:38:40 +0100 Date: Mon, 07 Sep 2020 11:38:38 +0100 Message-ID: <87zh61lvm9.wl-maz@kernel.org> From: Marc Zyngier To: Andrew Scull Subject: Re: [PATCH v3 04/18] KVM: arm64: Restrict symbol aliasing to outside nVHE In-Reply-To: <20200903135307.251331-5-ascull@google.com> References: <20200903135307.251331-1-ascull@google.com> <20200903135307.251331-5-ascull@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: ascull@google.com, kvmarm@lists.cs.columbia.edu, james.morse@arm.com, suzuki.poulose@arm.com, julien.thierry.kdev@gmail.com, will@kernel.org, catalin.marinas@arm.com, kernel-team@android.com, sudeep.holla@arm.com, linux-arm-kernel@lists.infradead.org, dbrazdil@google.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200907_063843_906838_B63553FD X-CRM114-Status: GOOD ( 24.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-team@android.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, james.morse@arm.com, linux-arm-kernel@lists.infradead.org, Sudeep Holla , David Brazdil , will@kernel.org, kvmarm@lists.cs.columbia.edu, julien.thierry.kdev@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andrew, On Thu, 03 Sep 2020 14:52:53 +0100, Andrew Scull wrote: > > nVHE symbols are prefixed but this is sometimes hidden from the host by > aliasing the non-prefixed symbol to the prefixed version with a macro. > This runs into problems if nVHE tries to use the symbol as it becomes > doubly prefixed. Avoid this by omitting the aliasing macro for nVHE. > > Cc: David Brazdil > Signed-off-by: Andrew Scull > --- > arch/arm64/include/asm/kvm_asm.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/include/asm/kvm_asm.h b/arch/arm64/include/asm/kvm_asm.h > index 6f98fbd0ac81..6f9c4162a764 100644 > --- a/arch/arm64/include/asm/kvm_asm.h > +++ b/arch/arm64/include/asm/kvm_asm.h > @@ -99,8 +99,11 @@ struct kvm_s2_mmu; > > DECLARE_KVM_NVHE_SYM(__kvm_hyp_init); > DECLARE_KVM_HYP_SYM(__kvm_hyp_vector); > + > +#ifndef __KVM_NVHE_HYPERVISOR__ > #define __kvm_hyp_init CHOOSE_NVHE_SYM(__kvm_hyp_init) > #define __kvm_hyp_vector CHOOSE_HYP_SYM(__kvm_hyp_vector) > +#endif Hmmm. Why do we limit this to these two symbols instead of making it a property of the "CHOOSE_*" implementation? The use of CHOOSE_HYP_SYM is already forbidden in the EL2 code (see how any symbol results in __nvhe_undefined_symbol being emitted). Does anything break if we have: #define CHOOSE_NVHE_SYM(x) x when __KVM_NVHE_HYPERVISOR__ is defined? Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel