From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] gpio: mvebu: fix regmap_update_bits usage
Date: Fri, 09 Jun 2017 12:05:40 +0200 [thread overview]
Message-ID: <87zidho4qz.fsf@free-electrons.com> (raw)
In-Reply-To: <20170609120435.60191c76@free-electrons.com> (Thomas Petazzoni's message of "Fri, 9 Jun 2017 12:04:35 +0200")
Hi Thomas,
On ven., juin 09 2017, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Fri, 9 Jun 2017 12:03:18 +0200, Gregory CLEMENT wrote:
>
>> regmap_update_bits(mvchip->regs, GPIO_IO_CONF_OFF,
>> - BIT(pin), 1);
>> + BIT(pin), BIT(pin));
>>
>> return 0;
>> }
>> @@ -364,7 +364,7 @@ static int mvebu_gpio_direction_output(struct gpio_chip *chip, unsigned int pin,
>> mvebu_gpio_set(chip, pin, value);
>>
>> regmap_update_bits(mvchip->regs, GPIO_IO_CONF_OFF,
>> - BIT(pin), 0);
>> + BIT(pin), BIT(pin));
>
> Are you sure here? We want to clear the bit, so I guess the 0 is
> appropriate, no?
argh!
yes it was a mistake
Gregory
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
prev parent reply other threads:[~2017-06-09 10:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 10:03 [PATCH] gpio: mvebu: fix regmap_update_bits usage Gregory CLEMENT
2017-06-09 10:04 ` Thomas Petazzoni
2017-06-09 10:05 ` Gregory CLEMENT [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zidho4qz.fsf@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox