linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: khilman@deeprootsystems.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] ARM: OMAP: hwmod: wait for sysreset complete after enabling hwmod
Date: Mon, 22 Oct 2012 14:46:17 -0700	[thread overview]
Message-ID: <87zk3edvti.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1350922532-26338-1-git-send-email-t-kristo@ti.com> (Tero Kristo's message of "Mon, 22 Oct 2012 19:15:32 +0300")

Tero Kristo <t-kristo@ti.com> writes:

> When waking up from off-mode, some IP blocks are reset automatically by
> hardware. For this reason, software must wait until the reset has
> completed before attempting to access the IP block.
>
> This patch fixes for example the bug introduced by commit
> 6c31b2150ff96755d24e0ab6d6fea08a7bf5c44c ("mmc: omap_hsmmc: remove access
> to SYSCONFIG register"), in which the MMC IP block is reset during
> off-mode entry, but the code expects the module to be already available
> during the execution of context restore.
>
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
> Cc: Paul Walmsley <paul@pwsan.com>
> Cc: Benoit Cousson <b-cousson@ti.com>
> Cc: Venkatraman S <svenkatr@ti.com>

I can confirm that this patch the regression in my OMAP3 PM tests where
suspend test (to retention or off) failed if ran after the off-idle
test.

Tested-by: Kevin Hilman <khilman@ti.com>

on 3530/Overo, 3730/OveroSTORM, 3730/Beagle-xM

Thanks Tero for the fix,

Kevin

  reply	other threads:[~2012-10-22 21:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-22 16:15 [RFC] ARM: OMAP: hwmod: wait for sysreset complete after enabling hwmod Tero Kristo
2012-10-22 21:46 ` Kevin Hilman [this message]
2012-10-23 15:43   ` Shubhrajyoti Datta
2012-10-23 16:09     ` Kevin Hilman
2012-10-23 17:50       ` Shubhrajyoti Datta
2012-10-23  7:47 ` Paul Walmsley
2012-10-23  8:03   ` Tero Kristo
2012-10-30  3:11     ` Paul Walmsley
2012-10-23 14:28   ` Kevin Hilman
2012-10-23 14:49     ` Santosh Shilimkar
2012-10-23 17:03     ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zk3edvti.fsf@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).