From: Amit Kachhap <amit.kachhap@arm.com>
To: Suzuki K Poulose <suzuki.poulose@arm.com>,
linux-arm-kernel@lists.infradead.org
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, James Morse <james.morse@arm.com>
Subject: Re: [PATCH v2] arm64: cpufeature: Fix the visibility of compat hwcaps
Date: Thu, 3 Nov 2022 13:55:04 +0530 [thread overview]
Message-ID: <880002bf-9ca2-dd94-4ee8-acf618aaaac0@arm.com> (raw)
In-Reply-To: <ca3e6b40-cbed-769e-5d00-1345490ffc9d@arm.com>
On 11/2/22 16:17, Suzuki K Poulose wrote:
> Hi Amit
>
> On 02/11/2022 10:21, Amit Daniel Kachhap wrote:
>> Commit 237405ebef58 ("arm64: cpufeature: Force HWCAP to be based on the
>> sysreg visible to user-space") forced the hwcaps to use sanitised
>> user-space view of the id registers. However, the ID register structures
>> used to select few compat cpufeatures (vfp, crc32, ...) are masked and
>> hence such hwcaps do not appear in /proc/cpuinfo anymore for PER_LINUX32
>> personality.
>>
>> Add the ID register structures explicitly and set the relevant entry as
>> visible for compat hwcaps.
>>
>> While at it, update the comment for structure ftr_generic_32bits[] which
>> lists the ID register that use it.
>>
>
> Minor nit: With this change, we expose mvfr*_el1 and the following
> document needs an update to reflect the change.
>
> Documentation/arm64/cpu-feature-registers.rst
I just send the v3 with your suggestion. I missed changing the mrs
instruction emulation for crm argument in v2 which I did now.
>
> Otherwise, looks good to me.
Thanks for your feedback.
Amit
>
> Suzuki
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-11-03 8:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 10:21 [PATCH v2] arm64: cpufeature: Fix the visibility of compat hwcaps Amit Daniel Kachhap
2022-11-02 10:47 ` Suzuki K Poulose
2022-11-03 8:25 ` Amit Kachhap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=880002bf-9ca2-dd94-4ee8-acf618aaaac0@arm.com \
--to=amit.kachhap@arm.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox