From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA018C433FE for ; Thu, 3 Nov 2022 08:26:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OlNpcPgUJcCOB3/YcMpigc3FIaVMQy6cLqGYGjY06bY=; b=DtCFtwyppHYFX5 k5dkc/a+exXclUorvhIMwkG00jsa3INBSrtTGWps4e9okFglnh+Kk0j0xYdKq1b0PF/KWJLaKCH+p B2pOi68h1viDYyNEWI+wUIr1nFj0QqITgi0KmLYgzYxUClViDAE5HGjAmQyvX0AsBAF43cwEWMAV5 zxECTvKLVMXnjUifR3sCwF1GhXJ3cYg9KbupA5eN1rUnpaAYW60myeCY2w8Qbp2jfdQskTWEiWkGY MWDVfYG1lrA8FDKU6FeUTqExuQndfQbtpjf0Or0ljzWFvaoQvPaRgpIG8yQokTtJdfEPSPcfrFs7J cDVV7l2zXPsY8fhrOlIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqVXN-00Gfju-Dk; Thu, 03 Nov 2022 08:25:22 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oqVXF-00GfiX-CD for linux-arm-kernel@lists.infradead.org; Thu, 03 Nov 2022 08:25:15 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A5F041FB; Thu, 3 Nov 2022 01:25:15 -0700 (PDT) Received: from [10.162.41.9] (unknown [10.162.41.9]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7F5813F5A1; Thu, 3 Nov 2022 01:25:07 -0700 (PDT) Message-ID: <880002bf-9ca2-dd94-4ee8-acf618aaaac0@arm.com> Date: Thu, 3 Nov 2022 13:55:04 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2] arm64: cpufeature: Fix the visibility of compat hwcaps To: Suzuki K Poulose , linux-arm-kernel@lists.infradead.org Cc: Catalin Marinas , Will Deacon , James Morse References: <20221102102143.19617-1-amit.kachhap@arm.com> Content-Language: en-US From: Amit Kachhap In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221103_012513_509508_FA7B96EF X-CRM114-Status: GOOD ( 13.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/2/22 16:17, Suzuki K Poulose wrote: > Hi Amit > > On 02/11/2022 10:21, Amit Daniel Kachhap wrote: >> Commit 237405ebef58 ("arm64: cpufeature: Force HWCAP to be based on the >> sysreg visible to user-space") forced the hwcaps to use sanitised >> user-space view of the id registers. However, the ID register structures >> used to select few compat cpufeatures (vfp, crc32, ...) are masked and >> hence such hwcaps do not appear in /proc/cpuinfo anymore for PER_LINUX32 >> personality. >> >> Add the ID register structures explicitly and set the relevant entry as >> visible for compat hwcaps. >> >> While at it, update the comment for structure ftr_generic_32bits[] which >> lists the ID register that use it. >> > > Minor nit: With this change, we expose mvfr*_el1 and the following > document needs an update to reflect the change. > > Documentation/arm64/cpu-feature-registers.rst I just send the v3 with your suggestion. I missed changing the mrs instruction emulation for crm argument in v2 which I did now. > > Otherwise, looks good to me. Thanks for your feedback. Amit > > Suzuki > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel