Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm/imx: add missing include of asm/exception.h for avic.c
Date: Fri, 21 Oct 2011 18:38:32 +0200	[thread overview]
Message-ID: <8805141.r6GF1WOsYI@wuerfel> (raw)
In-Reply-To: <20111021072219.GH15299@pengutronix.de>

On Friday 21 October 2011 09:22:19 Uwe Kleine-K?nig wrote:
> 
> On Fri, Oct 21, 2011 at 10:33:00AM +0800, Shawn Guo wrote:
> > It adds missing include of asm/exception.h for avic.c to fix the
> > compile error below.
> > 
> >   arch/arm/plat-mxc/avic.c:154:39: error: expected ?=?, ?,?, ?;?,
> >   ?asm? or ?__attribute__? before ?avic_handle_irq?
> > 
> > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> Arnd already posted a patch for that[1], but this one looks better.
> 
> Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>

Ok, thanks!

I found the same problem in plat-mxc/tzic.c as well now.

Which branch should we apply the patch to? The header file was
introduced in rmk's smp branch, but the usage was introduced in
the imx/multi-irq branch.

Should I merge the smp branch into imx/multi-irq and fix up the
breakage in the merge commit?

	Arnd

  reply	other threads:[~2011-10-21 16:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-21  2:33 [PATCH] arm/imx: add missing include of asm/exception.h for avic.c Shawn Guo
2011-10-21  7:22 ` Uwe Kleine-König
2011-10-21 16:38   ` Arnd Bergmann [this message]
2011-10-21 18:07     ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8805141.r6GF1WOsYI@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox