From: Krzysztof Kozlowski <krzk@kernel.org>
To: Conor Dooley <conor@kernel.org>, florin.leotescu@oss.nxp.com
Cc: Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Michael Shych <michaelsh@nvidia.com>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, viorel.suman@nxp.com,
carlos.song@nxp.com, linux-arm-kernel@lists.infradead.org,
imx@lists.linux.dev, festevam@gmail.com,
Florin Leotescu <florin.leotescu@nxp.com>
Subject: Re: [PATCH v3 1/3] dt-bindings: hwmon: Add Microchip emc2305 yaml schema
Date: Tue, 4 Mar 2025 17:31:47 +0100 [thread overview]
Message-ID: <880bac84-c593-44fa-a9dc-63462e1cee9d@kernel.org> (raw)
In-Reply-To: <20250304-serving-stem-e059361db2b8@spud>
On 04/03/2025 17:29, Conor Dooley wrote:
>> +properties:
>> + compatible:
>> + enum:
>> + - microchip,emc2301
>> + - microchip,emc2302
>> + - microchip,emc2303
>> + - microchip,emc2305
>
> Driver has no match data etc, suggesting all of these are compatible.
> Please pick one as a fallback compatible.
>
>> +
>> + reg:
>> + maxItems: 1
>> +
>> +required:
>> + - compatible
>> + - reg
>
> Missing descriptions of the fans, no?
> See max6639 for an example.
Yes and missing $ref to fan-controller schema.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-04 18:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 16:21 [PATCH v3 0/3] Add OF support for Microchip emc2305 fan controller florin.leotescu
2025-03-04 16:21 ` [PATCH v3 1/3] dt-bindings: hwmon: Add Microchip emc2305 yaml schema florin.leotescu
2025-03-04 16:27 ` Frank Li
2025-03-05 12:47 ` Daniel Baluta
2025-03-05 14:49 ` Florin Leotescu (OSS)
2025-03-04 16:29 ` Conor Dooley
2025-03-04 16:31 ` Krzysztof Kozlowski [this message]
2025-03-04 16:32 ` Krzysztof Kozlowski
2025-03-04 16:33 ` Krzysztof Kozlowski
2025-03-04 16:21 ` [PATCH v3 2/3] hwmon: emc2305: Add OF support florin.leotescu
2025-03-04 16:27 ` Frank Li
2025-03-04 16:21 ` [PATCH v3 3/3] hwmon: emc2305: Use devm_thermal_of_cooling_device_register florin.leotescu
2025-03-04 16:33 ` Frank Li
2025-03-05 16:54 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=880bac84-c593-44fa-a9dc-63462e1cee9d@kernel.org \
--to=krzk@kernel.org \
--cc=carlos.song@nxp.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=florin.leotescu@nxp.com \
--cc=florin.leotescu@oss.nxp.com \
--cc=imx@lists.linux.dev \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=michaelsh@nvidia.com \
--cc=robh@kernel.org \
--cc=viorel.suman@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox