From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7428C4360C for ; Tue, 8 Oct 2019 08:13:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A9AD021721 for ; Tue, 8 Oct 2019 08:13:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KCOEO7IM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A9AD021721 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aafwVDEBoMT4FQhWBEEUax5QljI9NWuPOfFpBZt8NmU=; b=KCOEO7IMySkgLS W48j03ODm5iprB8g53hXypra0Y3q4klkkgDptNBRfWlifNRRo7+bU45iPX74+VQ5usYK8T55hYUUk s+hyIq/q2q97oI8gUiPClfn4ihpN73y+XaBwO3O8Xl1mxR49kqR6bWEWa+He+lig3n3bz+y1gMjsH 4Ku8mwyP+esdTBhvp4FMahp+vdxFp3IIcECOqYHsoruzwGCUwBky21uwvJmC5XUVM//Pp0npkmCl+ t0o1vRYxuzSnGnR/2rGcdSdx1RF1hOMXWbcO9hd78B1JslLST+oJiSsabWFKguHXkxTas+OdTvjNe uKjQkm1I2CUuM1tV9U8g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHkcM-0005DR-Vk; Tue, 08 Oct 2019 08:13:14 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHkcK-0005Cu-5j; Tue, 08 Oct 2019 08:13:13 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8C2581570; Tue, 8 Oct 2019 01:13:11 -0700 (PDT) Received: from [10.162.40.139] (p8cg001049571a15.blr.arm.com [10.162.40.139]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 28D403F6C4; Tue, 8 Oct 2019 01:12:58 -0700 (PDT) Subject: Re: [PATCH V4 2/2] mm/pgtable/debug: Add test validating architecture page table helpers To: "Kirill A. Shutemov" , Ingo Molnar References: <1570427124-21887-1-git-send-email-anshuman.khandual@arm.com> <1570427124-21887-3-git-send-email-anshuman.khandual@arm.com> <20191007130617.GB56546@gmail.com> <20191007132607.4q537nauwfn5thol@box> <20191007135158.GA36360@gmail.com> <20191007140058.um5g44rvxyzyiref@box> From: Anshuman Khandual Message-ID: <881796fc-c35e-3790-a1ee-7031c6cdb38d@arm.com> Date: Tue, 8 Oct 2019 13:43:22 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20191007140058.um5g44rvxyzyiref@box> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191008_011312_300546_21D9B19E X-CRM114-Status: GOOD ( 19.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Peter Zijlstra , James Hogan , Tetsuo Handa , Heiko Carstens , Michal Hocko , linux-mm@kvack.org, Dave Hansen , Paul Mackerras , sparclinux@vger.kernel.org, Thomas Gleixner , linux-s390@vger.kernel.org, Michael Ellerman , x86@kernel.org, Russell King - ARM Linux , Matthew Wilcox , Steven Price , Jason Gunthorpe , Gerald Schaefer , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Kees Cook , Masahiro Yamada , Mark Brown , Dan Williams , Vlastimil Babka , Christophe Leroy , Sri Krishna chowdary , Ard Biesheuvel , Greg Kroah-Hartman , linux-mips@vger.kernel.org, Ralf Baechle , linux-kernel@vger.kernel.org, Paul Burton , Mike Rapoport , Vineet Gupta , Martin Schwidefsky , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/07/2019 07:30 PM, Kirill A. Shutemov wrote: > On Mon, Oct 07, 2019 at 03:51:58PM +0200, Ingo Molnar wrote: >> >> * Kirill A. Shutemov wrote: >> >>> On Mon, Oct 07, 2019 at 03:06:17PM +0200, Ingo Molnar wrote: >>>> >>>> * Anshuman Khandual wrote: >>>> >>>>> This adds a test module which will validate architecture page table helpers >>>>> and accessors regarding compliance with generic MM semantics expectations. >>>>> This will help various architectures in validating changes to the existing >>>>> page table helpers or addition of new ones. >>>>> >>>>> Test page table and memory pages creating it's entries at various level are >>>>> all allocated from system memory with required alignments. If memory pages >>>>> with required size and alignment could not be allocated, then all depending >>>>> individual tests are skipped. >>>> >>>>> diff --git a/arch/x86/include/asm/pgtable_64_types.h b/arch/x86/include/asm/pgtable_64_types.h >>>>> index 52e5f5f2240d..b882792a3999 100644 >>>>> --- a/arch/x86/include/asm/pgtable_64_types.h >>>>> +++ b/arch/x86/include/asm/pgtable_64_types.h >>>>> @@ -40,6 +40,8 @@ static inline bool pgtable_l5_enabled(void) >>>>> #define pgtable_l5_enabled() 0 >>>>> #endif /* CONFIG_X86_5LEVEL */ >>>>> >>>>> +#define mm_p4d_folded(mm) (!pgtable_l5_enabled()) >>>>> + >>>>> extern unsigned int pgdir_shift; >>>>> extern unsigned int ptrs_per_p4d; >>>> >>>> Any deep reason this has to be a macro instead of proper C? >>> >>> It's a way to override the generic mm_p4d_folded(). It can be rewritten >>> as inline function + define. Something like: >>> >>> #define mm_p4d_folded mm_p4d_folded >>> static inline bool mm_p4d_folded(struct mm_struct *mm) >>> { >>> return !pgtable_l5_enabled(); >>> } >>> >>> But I don't see much reason to be more verbose here than needed. >> >> C type checking? Documentation? Yeah, I know it's just a one-liner, but >> the principle of the death by a thousand cuts applies here. > > Okay, if you think it worth it. Anshuman, could you fix it up for the next > submission? Sure, will do. > > >> BTW., any reason this must be in the low level pgtable_64_types.h type >> header, instead of one of the API level header files? > > I defined it next pgtable_l5_enabled(). What is more appropriate place to > you? pgtable_64.h? Yeah, it makes sense. Needs to be moved to arch/x86/include/asm/pgtable_64.h as well ? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel