From: g.portay@overkiz.com (g.portay at overkiz.com)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: at91/dt: sam9x5: add pinctrl for pwm0
Date: Tue, 07 Apr 2015 21:40:56 +0200 [thread overview]
Message-ID: <8817d74520bc99a9ee01fe303dc335cd@overkiz.com> (raw)
In-Reply-To: <20150407192231.GW20669@piout.net>
On 2015-04-07 21:22, Alexandre Belloni wrote:
> Hi Ga?l,
>
> On 07/04/2015 at 16:11:23 +0200, Ga?l PORTAY wrote :
>> Defines the pinctrl configurations for PWM0.
>>
>> Signed-off-by: Ga?l PORTAY <g.portay@overkiz.com>
>> ---
>> arch/arm/boot/dts/at91sam9x5.dtsi | 46
>> +++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 46 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi
>> b/arch/arm/boot/dts/at91sam9x5.dtsi
>> index d221179..08ed53d 100644
>> --- a/arch/arm/boot/dts/at91sam9x5.dtsi
>> +++ b/arch/arm/boot/dts/at91sam9x5.dtsi
>> @@ -463,6 +463,52 @@
>> };
>> };
>>
>> + pwm0 {
>> + pinctrl_pwm0_pwm0_0: pwm0_pwm0-0 {
>> + atmel,pins =
>> + <AT91_PIOB 11 AT91_PERIPH_B AT91_PINCTRL_NONE>; /* PB11 periph
>> B */
> please drop those useless
> comments --^
>
> Else, I'm fine with that patch.
I do think so... I added them for consistency only... I will drop them
in v2.
Do you want I drop all those kind of comments (of the whole file) as
well ?
Thanks for your review.
next prev parent reply other threads:[~2015-04-07 19:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-07 14:11 [PATCH 0/2] ARM: at91/dt: add support for at91-kizboxmini Gaël PORTAY
2015-04-07 14:11 ` [PATCH 1/2] ARM: at91/dt: sam9x5: add pinctrl for pwm0 Gaël PORTAY
2015-04-07 19:22 ` Alexandre Belloni
2015-04-07 19:40 ` g.portay at overkiz.com [this message]
2015-04-07 20:05 ` Alexandre Belloni
2015-04-07 14:11 ` [PATCH 2/2] ARM: at91/dt: add support for kizboxmini Gaël PORTAY
2015-04-07 19:32 ` Alexandre Belloni
2015-04-07 19:49 ` g.portay at overkiz.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8817d74520bc99a9ee01fe303dc335cd@overkiz.com \
--to=g.portay@overkiz.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox