public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v1 2/2] ARM: dts: rockchip: set dr_mode property for rk3288-firefly board
Date: Sun, 26 Apr 2015 12:16:05 +0200	[thread overview]
Message-ID: <8829961.lJFBlrS3Ia@diego> (raw)
In-Reply-To: <1430041299-24874-2-git-send-email-lyz@rock-chips.com>

Hi,

Am Sonntag, 26. April 2015, 17:41:39 schrieb Yunzhi Li:
> rk3288-firefly board use the dwc2 usb otg controller as a host
> controller and the device mode not used, so the dr_mode should be
> "host" then the dwc2 usb otg controller will work at host only
> mode
> 
> Signed-off-by: Yunzhi Li <lyz@rock-chips.com>

Not sure I understand. Is this some sort of hardware limitation? Because when 
for example flashing a kernel via upgrade_tool it is working just fine as 
gadget.

If it is a software choice, this should not be made in the devicetree, as the 
dt describes the hardware alone.


Heiko


> 
> ---
> 
>  arch/arm/boot/dts/rk3288-firefly.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/rk3288-firefly.dtsi
> b/arch/arm/boot/dts/rk3288-firefly.dtsi index e6f873a..a861776 100644
> --- a/arch/arm/boot/dts/rk3288-firefly.dtsi
> +++ b/arch/arm/boot/dts/rk3288-firefly.dtsi
> @@ -466,6 +466,7 @@
>  };
> 
>  &usb_otg {
> +	dr_modr = "host";
>  	status = "okay";
>  };

  reply	other threads:[~2015-04-26 10:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-26  9:41 [PATCH v1 1/2] ARM: dts: rockchip: add properties for dwc2 usb otg controller Yunzhi Li
2015-04-26  9:41 ` [PATCH v1 2/2] ARM: dts: rockchip: set dr_mode property for rk3288-firefly board Yunzhi Li
2015-04-26 10:16   ` Heiko Stübner [this message]
2015-04-26 11:12   ` Sergei Shtylyov
2015-04-28 20:59 ` [PATCH v1 1/2] ARM: dts: rockchip: add properties for dwc2 usb otg controller Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8829961.lJFBlrS3Ia@diego \
    --to=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox