From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D262C433ED for ; Thu, 15 Apr 2021 14:15:35 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A2AD611F1 for ; Thu, 15 Apr 2021 14:15:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A2AD611F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=idZ1hib/d3e6iL037HUl5N1EkeyzasUcQgkXenQJsvE=; b=R888CSO3F58Aal1zJ9vXIvg2G 3XL6RAQDgD7Q5b1mEStaOqp60wiyn+Sin1gUjb+dFrr4iI++WqYd8RjMqlEOo87nCsEoCL8h4tqdY AOihYHvVSFjK9e4VtCwt5uperymXKzq5m7khV0zhIDbXZNsO02FFwI2mt8+OVq7pJfHj1yndnxs46 bzTggbayaXc2/RiU/jiuYtFQyQyv7mXLswff3haIN5bsXXrnM1jeF0q6RB9E29WIp6vyS0z+GaojV O2x3d63bLWPbTo4o9Zmu9bAMOhKtxsvAfoNjzyc6pPafm70+ZAp5717nAy4bRNuqmnJeR10d0CRA8 v2htKAj7A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lX2kf-00GP3T-5D; Thu, 15 Apr 2021 14:13:49 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lX2kZ-00GP2J-Hi for linux-arm-kernel@desiato.infradead.org; Thu, 15 Apr 2021 14:13:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To: Subject:Sender:Reply-To:Cc:Content-ID:Content-Description; bh=SJzFzeQyY6zE2VIwTjDjNNAyn53IVBeNMuXB6ksOPYU=; b=bP7DfS9XnGfOF6kiZ8+BDsM5o8 2Sq5mZBI6tW3trjhXvXkv4s7dkka6C/uei9uMsoRXzuYlNQmBQEw1fs1dqkjXMY1mdxx0taKDfPDN O/ZbgIWJ7p8/M+pxh1tdf9HbJhI4eZkaomCHs+dR8owNWjVwQJ5bTJdgSc/1XSN9s3Lf42EEVW7NE jZu13uIAPUkybauuxaC8TEBa5Btv22EfXHOT29rfBk7Qk9J233iMrPaxZqJosksrV0CEck9png7+S QiPO02GyETE+aEw1e6aMaJUjavmRETHHpybBcpC/30NOoBY2FpSwbWKsAkp4aD0E9qHiI9UN+sytq 5l6uveVQ==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lX2kW-008dxa-VJ for linux-arm-kernel@lists.infradead.org; Thu, 15 Apr 2021 14:13:42 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D334B106F; Thu, 15 Apr 2021 07:13:39 -0700 (PDT) Received: from [10.57.57.112] (unknown [10.57.57.112]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C21233F694; Thu, 15 Apr 2021 07:13:37 -0700 (PDT) Subject: Re: [PATCH v4 1/6] perf arm-spe: Remove unused enum value ARM_SPE_PER_CPU_MMAPS To: Leo Yan , Arnaldo Carvalho de Melo , Al Grant , John Garry , Will Deacon , Mathieu Poirier , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Dave Martin , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210412091006.468557-1-leo.yan@linaro.org> <20210412091006.468557-2-leo.yan@linaro.org> From: James Clark Message-ID: <882e13d1-c793-88c6-0b1e-629462fb99ac@arm.com> Date: Thu, 15 Apr 2021 17:13:36 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210412091006.468557-2-leo.yan@linaro.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210415_071341_088740_DE8F76C1 X-CRM114-Status: GOOD ( 18.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/04/2021 12:10, Leo Yan wrote: > The enum value 'ARM_SPE_PER_CPU_MMAPS' is never used so remove it. Hi Leo, I think this causes an error when attempting to open a newly recorded file with an old version of perf. The value ARM_SPE_AUXTRACE_PRIV_MAX is used here: size_t min_sz = sizeof(u64) * ARM_SPE_AUXTRACE_PRIV_MAX; struct perf_record_time_conv *tc = &session->time_conv; struct arm_spe *spe; int err; if (auxtrace_info->header.size < sizeof(struct perf_record_auxtrace_info) + min_sz) return -EINVAL; And removing ARM_SPE_PER_CPU_MMAPS changes the value of ARM_SPE_AUXTRACE_PRIV_MAX. At least I think that's what's causing the problem. I get this error: ./perf report -i per-thread-spe-time.data 0x1c0 [0x18]: failed to process type: 70 [Invalid argument] Error: failed to process sample # To display the perf.data header info, please use --header/--header-only options. # James > > Signed-off-by: Leo Yan > --- > tools/perf/util/arm-spe.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tools/perf/util/arm-spe.h b/tools/perf/util/arm-spe.h > index 98d3235781c3..105ce0ea0a01 100644 > --- a/tools/perf/util/arm-spe.h > +++ b/tools/perf/util/arm-spe.h > @@ -11,7 +11,6 @@ > > enum { > ARM_SPE_PMU_TYPE, > - ARM_SPE_PER_CPU_MMAPS, > ARM_SPE_AUXTRACE_PRIV_MAX, > }; > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel