From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D822CC433EF for ; Thu, 21 Jul 2022 06:52:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uk9aWmL3HyAqeas0t14MWOBwpASf+6BE4pcGtLE8498=; b=YG9OCZ8KDS3pRadrwHSerJh6wX 7+oo04MPR8qTk9uB24ckZ5UBU3XuNxBH9rtLUS0fYco38awBmruW3XaJHp2kGn+VROPyKNh2J9sxS atrPzksk4evTeoI1WdgXnVeFeNMRZahmuzo1xbB9i/VgtUmc54poGocf9I50doTJotJJQweaKxYCg YVUWaGwcoo4mgcF3ER7nEtSvsz0laSUbPDakdHko1HseIATf72ukJT/WE/KQ+YsyBWUO6B4y6xQU5 rW1vhP4kmZ7qZOq2TyCAI+Sf6LILk2tCzCvLQwJrh0AEjR3MV9EcMZz87nOT+toFgffgBKfIlww5U af+VmaHQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEQ1x-001Gzh-TC; Thu, 21 Jul 2022 06:51:29 +0000 Received: from 8.mo561.mail-out.ovh.net ([87.98.172.249]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oEQ1t-001Gw3-V0 for linux-arm-kernel@lists.infradead.org; Thu, 21 Jul 2022 06:51:27 +0000 Received: from player697.ha.ovh.net (unknown [10.109.138.157]) by mo561.mail-out.ovh.net (Postfix) with ESMTP id AD27922033 for ; Thu, 21 Jul 2022 06:51:21 +0000 (UTC) Received: from RCM-web2.webmail.mail.ovh.net (ip-194-187-74-233.konfederacka.maverick.com.pl [194.187.74.233]) (Authenticated sender: rafal@milecki.pl) by player697.ha.ovh.net (Postfix) with ESMTPSA id 65D0E2CD2F359; Thu, 21 Jul 2022 06:51:09 +0000 (UTC) MIME-Version: 1.0 Date: Thu, 21 Jul 2022 08:51:09 +0200 From: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= To: Krzysztof Kozlowski Cc: William Zhang , Linux ARM List , joel.peshkin@broadcom.com, dan.beygelman@broadcom.com, Rob Herring , Krzysztof Kozlowski , Anand Gore , Kursad Oney , Florian Fainelli , Broadcom internal kernel review list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: Re: [RESEND PATCH 2/9] dt-bindings: arm64: bcmbca: Update BCM4908 description In-Reply-To: References: <20220721000658.29537-1-william.zhang@broadcom.com> User-Agent: Roundcube Webmail/1.4.13 Message-ID: <883c2ad4c36220b488519a8902ad72bc@milecki.pl> X-Sender: rafal@milecki.pl X-Originating-IP: 194.187.74.233 X-Webmail-UserID: rafal@milecki.pl X-Ovh-Tracer-Id: 17827780602349661147 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrudelkedgudeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepggffhffvvefujghffgfkgihitgfgsehtjehjtddtredvnecuhfhrohhmpeftrghfrghlpgfoihhlvggtkhhiuceorhgrfhgrlhesmhhilhgvtghkihdrphhlqeenucggtffrrghtthgvrhhnpeegvdffjeelvdeggeetheegveejieetgeeiiefggeelveejffehieekhfduueelhfenucfkpheptddrtddrtddrtddpudelgedrudekjedrjeegrddvfeefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehplhgrhigvrheileejrdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomheprhgrfhgrlhesmhhilhgvtghkihdrphhlpdhnsggprhgtphhtthhopedupdhrtghpthhtoheplhhinhhugidqrghrmhdqkhgvrhhnvghlsehlihhsthhsrdhinhhfrhgruggvrggurdhorhhgpdfovfetjfhoshhtpehmohehiedu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220720_235126_183233_1D5CB3AC X-CRM114-Status: UNSURE ( 9.33 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-07-21 08:44, Krzysztof Kozlowski wrote: > On 21/07/2022 02:06, William Zhang wrote: >> Append "brcm,bcmbca" to BCM4908 chip family compatible strings. Add >> generic 4908 board entry. > > This does not explain at all why you are doing it. Improve your commit > messages. To clarify it from my side (and maybe help a bit): 1. As I understand it BCMBCA is a one big family of SoCs. 2. BCM4908 is a subset of that family (a subfamily?) designed for a specific group of devices. If that's correct I think William it's what you should describe in your commit message. That would make binding more accurate and should be a good argument for your change (I believe). _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel