From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55B3CEB64DC for ; Mon, 3 Jul 2023 12:55:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bujlkytCyGcpw0Jo2GCrIfb7Yv7TqEHrqxiFqt+glqY=; b=H2Ra/lfZWEXB1v khvq9IxbR1nEDO8pPh97ppEzcVSLF7RsrFSNnWubXIjiSQ02LSpWNE/cqPU6Db1drBmYWo2eMA2IP N6dtheZ6cHVV4bBmFwYsq2vuBb6S+3dEL1aNxcAG+DxJ1XO/+KTN6uhda+HS+BsoSo3UNgWTj6iT5 NhEmSJNRysMoSn5lBiLtBIyU2dvEH4rMPxUT/Qzd0C9zWwCWp1WDRJH38OvexXreQ3lUcy6PzetKq +fgrjyY/9MP2W2uakJQPiiF4j6/deyYc0AkbApTNuDOMwZj20C9W4LfbOH6R13/3rLQ00x1j86pnx SZsT5YosmVAIEcdHFKgg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGJ4w-00AYQZ-14; Mon, 03 Jul 2023 12:54:54 +0000 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGJ4t-00AYPU-19 for linux-arm-kernel@lists.infradead.org; Mon, 03 Jul 2023 12:54:52 +0000 Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-4fb73ba3b5dso6982242e87.1 for ; Mon, 03 Jul 2023 05:54:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688388887; x=1690980887; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=v5vg9Foed0fGCLC6fQJ5romEdNjTvzK0Z22HuX4YlC8=; b=ygKIo91z1/P+BIySSrpClLc3H42+uNOqyHBDRliREHJmsL3Y+/JwFDNhG/9agp16Go MBXAMfk6WX796GJagY8JIeBITY611anmlMZl6gyu5/YOYOCDfqrLSVikHnmnZQsyYZCd 9jWJsuoEPQ7eVjVdhyR2s+qsN3dIG/e8YsSh6TXlYI+Tm5UP3C7eVr4TC5s50Ghr1kbU V86G3M+NNER1+P4sulAH06zpVroor+hu5b5kBgmhJy5xcr6QjM9wLqKJ1eg3NUchXXsy o/Gk3akM2S7yRuUlAwucRhezb4zesIGfsJioOc4IJXBno7VBJi9rrBbBpigQEX/89VHf +oWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688388887; x=1690980887; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=v5vg9Foed0fGCLC6fQJ5romEdNjTvzK0Z22HuX4YlC8=; b=WLAMCcHOPvImv4TLPTm207S3a6V7gRQ3Jq//7UjpCSiWbmQL6ON2ybVaLsibbDwjjE rQtdFDaM9qV9E64iSluCCcNlQ04KwVeyHuyTEYWCLCNU0VTcZ7ePVyJ2QDsH0UvvZIwy Im+EWXEUA6JW10zlksj58nIl6+4LvBJVgdv3j0g0j4RTaShEByDjHA5OKqecuF1AJHJm hoWUCCY95m71LOEV2x43x8NGSb66NjIBcPHY86zEeUfvk6UXUNrXbUGIxuOBpAqOlC4F Ino083pVBiPpL4mVpLoPlSsrB2QEOV0/4ZyPDAB8zO6LqbI9JAedbqfDmaNLkI/chNk0 d6rA== X-Gm-Message-State: ABy/qLYL34EWy+BhOXH+WpmJfXGlUXuXFL8L4ODTDPLKHM5OIuLGLVdG xWgprwUtZU3F6x/OVQ0cTdd5I9g04RIErE845Qc= X-Google-Smtp-Source: APBJJlHM1frPemlXRN9IjBwImUu2ICaLNU9ZsDkBq1O2R5IQ80yEgdN0B+79v6mSaJM1VkkZNzRCjA== X-Received: by 2002:a05:6512:33c9:b0:4f8:7325:bcd4 with SMTP id d9-20020a05651233c900b004f87325bcd4mr7993114lfg.0.1688388887459; Mon, 03 Jul 2023 05:54:47 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id q20-20020a1cf314000000b003f90b9b2c31sm30179834wmq.28.2023.07.03.05.54.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 05:54:45 -0700 (PDT) Date: Mon, 3 Jul 2023 15:54:42 +0300 From: Dan Carpenter To: Christophe JAILLET Cc: wsa@kernel.org, Linus Walleij , Andi Shyti , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org Subject: Re: [PATCH v2] i2c: busses: i2c-nomadik: Remove a useless call in the remove function Message-ID: <885ee9fa-f56c-4e21-b648-866dd4e1dc0f@kadam.mountain> References: <62ae6810d41e0429ebaadfac8a95409f4bc72456.1688160163.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <62ae6810d41e0429ebaadfac8a95409f4bc72456.1688160163.git.christophe.jaillet@wanadoo.fr> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230703_055451_465034_55BD33F2 X-CRM114-Status: GOOD ( 15.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 30, 2023 at 11:23:28PM +0200, Christophe JAILLET wrote: > Since commit a410963ba4c0 ("Merge branch 'i2c-embedded/for-next' of > git://git.pengutronix.de/git/wsa/linux"), there is no more > request_mem_region() call in this driver. > > So remove the release_mem_region() call from the remove function which is > likely a left over. > > There is no details in the above commit log, but at its end we can read: > Conflicts: > drivers/i2c/busses/i2c-nomadik.c > > This may explain why this call has been left here. > > Fixes: a410963ba4c0 ("Merge branch 'i2c-embedded/for-next' of git://git.pengutronix.de/git/wsa/linux The reason why you're so confused about this Merge commit is because it's completely unrelated to the bug. :P It should be: Fixes: 235602146ec9 (i2c-nomadik: turn the platform driver to an amba driver) When you look at that commit, you'll see that your patch is correct. regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel