From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C416FC10F14 for ; Sun, 21 Apr 2019 16:01:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9179F20833 for ; Sun, 21 Apr 2019 16:01:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="aUFMd3L2"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LlTOgH4G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9179F20833 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:References: To:Subject:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ujf7p/lwOXkz0Dug05Gbgwd7aISvWN3GPMzPB+m09Ks=; b=aUFMd3L2S4cjoKU/NgDpR4OHl Dd0irnSVHGXfKlPwVpAElwokZBCxvKTv5vwhcCnKKuAG41Y7vw3/jQUdgM24V4zPse+E1SEXCLRLk 3eti1f7DwQohByQVaAixiZzNnKAfEkyL9QY8YGjbG+zsNiRm1vUufOBfG8JohQpRC5KVuZ6S8b0Bt kMeautF/pyj3CR20L2zltWGsjNl/vdjVjj2svPmN9jbU4JyVGEIxYrUrEJpebtxAW8WcY9zg7Kz5g vUtNxc6GcWKLwUWvcUyvII+oCZyKL7My8JFaKlr11Fxw3krFTfcRdvqHF6mNFMEygFyPCBCCq6mbO I0yWoZw6Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hIEtg-0006Lo-Ky; Sun, 21 Apr 2019 16:00:52 +0000 Received: from mail-qt1-x841.google.com ([2607:f8b0:4864:20::841]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hIEtc-0006KS-UQ; Sun, 21 Apr 2019 16:00:50 +0000 Received: by mail-qt1-x841.google.com with SMTP id z16so9939167qtn.4; Sun, 21 Apr 2019 09:00:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1FmFRZalGuBteJupls9Ynq4YZ5LXv0xaPNANJ13Fang=; b=LlTOgH4GTmIW6f4I6jujECk1OI2ay9gwyRBC9lrQE3N7dWh800IQHRhC0mkjCeHX02 usu3svlkojKuzYArNmS89QIAOTMwzOxy10FSe+zXh8dOozg58hqc8sX69dg8Hg/1maqa 4LHElgDqraw3FqiUq0kxFlvawZWOpez0dgGUJV6jPkQVo0uwEYiF5absvZiMTB+JIIZ+ 7DlcVLvjfcB7vvjpEKaWpBqBrbySGCmr3t/MffTuhH0kGqn5GBq5j+mrgiyg8m88YHnz UrDXQVFuuFN9HyevsaMBsR+b8DXW6WTMrTtpr9WR5/B90EKovv7o6UPjR2KZY/V2jJ/9 Iv7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1FmFRZalGuBteJupls9Ynq4YZ5LXv0xaPNANJ13Fang=; b=icWklqLWmF8yeW659gA1Tg+CSLh0+97N+SvUrah6HVmwXWbQkR3j/hlkYN3+t4hryP kXhKUF6F6S3khGaEHn3zuNEaaZZlD53LlNHn139p0uyLvzXlOX6CG/ROTkbdfda8vEpn fBkvOqc77U1WWquj5k8gitHA6RPydovwJAK9dNeYWvL9ISJrIirFaJAjRwC+YIkqzD3+ E5JUzRt1AjdeXvlXTkt66s1rwsEf1W9AErCfRTQBYV1FW9jLVO1KVEE6GtsI9K5dhkEr mmy+HpmQYX8Z537eT94/4qRanlhxFFdDz70bN0bFRdjIEjz3t5+lIWH+Z7d35AgzGNBy NHbQ== X-Gm-Message-State: APjAAAWm/Chs8Y1Dj9ZuXWapo47U8ui76nDZi5Wa/i/GoppMJ2x7bFMz PYXAvuPGpi+jf+UxHTcByHjtfmBxNlg= X-Google-Smtp-Source: APXvYqwseSY7RUnIrCBWTgCL/QGmOyiOUqjw8ubpjt55Bzlfsc2wKZ4nM+2sdZpDyD6A/EA+6c2xeQ== X-Received: by 2002:a0c:f989:: with SMTP id t9mr12286661qvn.74.1555862445747; Sun, 21 Apr 2019 09:00:45 -0700 (PDT) Received: from ?IPv6:2601:153:900:ebb:c07e:82e9:867b:9247? ([2601:153:900:ebb:c07e:82e9:867b:9247]) by smtp.gmail.com with ESMTPSA id j5sm5735380qtb.30.2019.04.21.09.00.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 Apr 2019 09:00:44 -0700 (PDT) From: Peter Geis Subject: Re: [PATCH] arm64: dts: rockchip: set TX PBL for rk3328-roc-cc gmac To: "Leonidas P. Papadakos" References: <20190417210059.26262-1-papadakospan@gmail.com> Message-ID: <8865b046-fb3a-4071-335c-66abb344d7f4@gmail.com> Date: Sun, 21 Apr 2019 12:00:45 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190417210059.26262-1-papadakospan@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190421_090049_009426_AFAD23FD X-CRM114-Status: GOOD ( 21.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jose Abreu , devicetree@vger.kernel.org, Heiko Stuebner , linux-rockchip@lists.infradead.org, Rob Herring , linux-arm-kernel@lists.infradead.org, Robin Murphy , "Leonidas P. Papadakos" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thanks for sharing that thread, it's nice to finally have an answer to why we have these issues. I've tested this on *my* Firefly rk3328-roc-cc, and while this patch succeeds in preventing the tx lockup, iperf3 drops to a delightful 15mbps. It would seem we have significant differences between manufacturing runs of the various boards. The auto adjustment feature that was discussed in that thread is probably the only thing that will solve this for all boards. Until then I don't think we are going to get a solution that works for all. On Wed, Apr 17, 2019 at 5:01 PM Leonidas P. Papadakos wrote: > > Some rockchip boards have issues with tx checksumming for packets > larger than 1498 B. > > An iperf test will tell you that transmissions stop almost immediately. > > A workaround to this issue is disabling TX checksumming offload, > and one of the ways to do that is snps,force_thresh_dma_mode. > > But after some discussion here it seems there is another path: > https://lkml.org/lkml/2019/4/5/148 > > Setting txpbl is a better-performing (maybe temporary) solution > compared to disabling T offload. > > In my testing with a Libre Computer Renegade, this was the best > all-around option, and increasing the MTU doesn't cause a queue timeout anymore. > > Signed-off-by: Leonidas P. Papadakos > --- > arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts > index 5d499c908..974f2dcdf 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts > @@ -141,10 +141,10 @@ > phy-mode = "rgmii"; > pinctrl-names = "default"; > pinctrl-0 = <&rgmiim1_pins>; > - snps,force_thresh_dma_mode; > snps,reset-gpio = <&gpio1 RK_PC2 GPIO_ACTIVE_LOW>; > snps,reset-active-low; > snps,reset-delays-us = <0 10000 50000>; > + snps,txpbl = <0x4>; > tx_delay = <0x24>; > rx_delay = <0x18>; > status = "okay"; > -- > 2.21.0 > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel