From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 674B0C7EE2A for ; Tue, 6 Jun 2023 08:30:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:Message-ID:In-Reply-To: Subject:cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hSPSRuXsIomUKxZqOtxun7po2vRMYZdEPbeS+/xI6mc=; b=axNpiCOb/zgtqpo3bHSAmPYYfo cIH0rmgoHCiauaxKll0/0hgltueijOZTe6vOu8S0vV7y8QS80nPfN2f4LXJa6k9q22LunYFKAnbUf vy5P07e7jDBdmbIqv0MYP2/FNlBinL4K3nUl6bM6z/CVwDSuFYzvrOYwYHYnCB3M6vvSOXpdBBAU7 YcI++pge+ZhLOqmIgS8zCMWr/E1ka0k0+K1vrg2wi+PaYtU35WHx2+FiqnmVNrD7MiG6sIWxO3jAi SLzt6Qb1zcVGumtWqMDrHcHKBWhY8lvZIXtkzeIi8MHSE1Y0r+SQC5e0255N2rqOdzKjKUKfdJDmt 8iAt+OgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q6S4W-000oa8-0Z; Tue, 06 Jun 2023 08:29:44 +0000 Received: from baptiste.telenet-ops.be ([2a02:1800:120:4::f00:13]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q6S4T-000oZ5-2S for linux-arm-kernel@lists.infradead.org; Tue, 06 Jun 2023 08:29:43 +0000 Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed30:a3e8:6562:a823:d832]) by baptiste.telenet-ops.be with bizsmtp id 5kVL2A0121Tjf1k01kVLNE; Tue, 06 Jun 2023 10:29:36 +0200 Received: from geert (helo=localhost) by ramsan.of.borg with local-esmtp (Exim 4.95) (envelope-from ) id 1q6S48-004ISO-MB; Tue, 06 Jun 2023 10:29:20 +0200 Date: Tue, 6 Jun 2023 10:29:20 +0200 (CEST) From: Geert Uytterhoeven To: Maxime Chevallier cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, alexis.lothore@bootlin.com, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Florian Fainelli , Heiner Kallweit , Russell King , Vladimir Oltean , Ioana Ciornei , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Maxime Coquelin , Jose Abreu , Alexandre Torgue , Giuseppe Cavallaro , Simon Horman Subject: Re: [PATCH net-next 1/2] net: stmmac: Add PCS_LYNX as a dependency for the whole driver In-Reply-To: <20230606064914.134945-2-maxime.chevallier@bootlin.com> Message-ID: <889297a0-88c3-90df-7752-efa00184859@linux-m68k.org> References: <20230606064914.134945-1-maxime.chevallier@bootlin.com> <20230606064914.134945-2-maxime.chevallier@bootlin.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230606_012941_940144_BC37D356 X-CRM114-Status: GOOD ( 24.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Maxime, On Tue, 6 Jun 2023, Maxime Chevallier wrote: > Although pcs_lynx is only used on dwmac_socfpga for now, the cleanup > path is in the generic driver, and triggers build issues for other > stmmac variants. Make sure we build pcs_lynx in all cases too, as for > XPCS. That seems suboptimal to me, as it needlesly increases kernel size for people who do not use dwmac_socfpga. Hence I made an alternative patch: https://lore.kernel/org/7b36ac43778b41831debd5c30b5b37d268512195.1686039915.git.geert+renesas@glider.be > Fixes: 5d1f3fe7d2d5 ("net: stmmac: dwmac-sogfpga: use the lynx pcs driver") > Signed-off-by: Maxime Chevallier > --- > drivers/net/ethernet/stmicro/stmmac/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/stmicro/stmmac/Kconfig > index 5583f0b055ec..fa956f2081a5 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/Kconfig > +++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig > @@ -5,6 +5,7 @@ config STMMAC_ETH > depends on PTP_1588_CLOCK_OPTIONAL > select MII > select PCS_XPCS > + select PCS_LYNX > select PAGE_POOL > select PHYLINK > select CRC32 > @@ -160,7 +161,6 @@ config DWMAC_SOCFPGA > select MFD_SYSCON > select MDIO_REGMAP > select REGMAP_MMIO > - select PCS_LYNX > help > Support for ethernet controller on Altera SOCFPGA Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel