From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Julien Stephan <jstephan@baylibre.com>
Cc: Phi-bang Nguyen <pnguyen@baylibre.com>,
Andy Hsieh <andy.hsieh@mediatek.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Conor Dooley <conor+dt@kernel.org>,
daoyuan huang <daoyuan.huang@mediatek.com>,
devicetree@vger.kernel.org,
Florian Sylvestre <fsylvestre@baylibre.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-media@vger.kernel.org, Louis Kuo <louis.kuo@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Moudy Ho <moudy.ho@mediatek.com>,
Ping-Hsun Wu <ping-hsun.wu@mediatek.com>,
Rob Herring <robh+dt@kernel.org>,
Vasily Gorbik <gor@linux.ibm.com>
Subject: Re: [PATCH 3/4] dt-bindings: media: add mediatek ISP3.0 camsv
Date: Sun, 2 Jul 2023 12:47:09 +0200 [thread overview]
Message-ID: <889bbee2-db9c-c1dd-dc8a-cdc436f1dfd8@linaro.org> (raw)
In-Reply-To: <20230628145412.1610260-4-jstephan@baylibre.com>
On 28/06/2023 16:52, Julien Stephan wrote:
> From: Phi-bang Nguyen <pnguyen@baylibre.com>
>
> This adds the bindings, for the ISP3.0 camsv module embedded in
> some Mediatek SoC, such as the mt8365
Thank you for your patch. There is something to discuss/improve.
> +
> +description:
> + The CAMSV is a set of DMA engines connected to the SENINF CSI-2
> + receivers. The number of CAMSVs depend on the SoC model.
> +
> +properties:
> + compatible:
> + const: mediatek,mt8365-camsv
> +
> + reg:
> + maxItems: 3
Describe the items (items with description) instead.
> +
...
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/clock/mediatek,mt8365-clk.h>
> + #include <dt-bindings/memory/mediatek,mt8365-larb-port.h>
> + #include <dt-bindings/power/mediatek,mt8365-power.h>
> +
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + camsv1: camsv@15050000 {
> + compatible = "mediatek,mt8365-camsv";
> + reg = <0 0x15050000 0 0x0040>,
> + <0 0x15050208 0 0x0020>,
> + <0 0x15050400 0 0x0100>;
Fix the alignment.
> + interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_LOW>;
> + clocks = <&camsys CLK_CAM>,
> + <&camsys CLK_CAMTG>,
> + <&camsys CLK_CAMSV0>;
Everywhere...
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-07-02 10:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 14:52 [PATCH 0/4] Add Mediatek ISP3.0 Julien Stephan
2023-06-28 14:52 ` [PATCH 1/4] dt-bindings: media: add mediatek ISP3.0 sensor interface Julien Stephan
2023-06-28 15:19 ` Rob Herring
2023-06-28 16:13 ` Rob Herring
2023-06-28 14:52 ` [PATCH 2/4] media: platform: mediatek: isp_30: " Julien Stephan
2023-06-28 14:52 ` [PATCH 3/4] dt-bindings: media: add mediatek ISP3.0 camsv Julien Stephan
2023-06-28 15:19 ` Rob Herring
2023-06-28 16:16 ` Rob Herring
2023-07-02 10:47 ` Krzysztof Kozlowski [this message]
2023-06-28 14:52 ` [PATCH 4/4] media: platform: mediatek: isp_30: " Julien Stephan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=889bbee2-db9c-c1dd-dc8a-cdc436f1dfd8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andy.hsieh@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=daoyuan.huang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=fsylvestre@baylibre.com \
--cc=gor@linux.ibm.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jstephan@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=louis.kuo@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=moudy.ho@mediatek.com \
--cc=ping-hsun.wu@mediatek.com \
--cc=pnguyen@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).