From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59A0BEB64D9 for ; Sun, 2 Jul 2023 10:47:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4jbd0oTv5tS09WhHzkch1AgqVvhdVpLZkmD3MpW7hWk=; b=LyNPPc6A2xUGfd Dc6OFnKMp9CTVECZxhI94QE+CgglZzVqkFgJBFvwT/cgpuWJ2Lx2Qxmeo8fDKwHKjdEiytpfLtTYh auQudXTXrzE3Z2fXjF9romrSipTS3d9l3KocRtoSwsrh0Y1d631vpxCe7MAQ3U5loeqK0RTOYk9u/ U2qpfj+ocpsB9J57fmZSZBZvhKRdR8PfLXbEgpyMRhSx/Ni7/htlgcB8KjEsztc1jQyKCf/zwRP3c qrxP3zGS8ErP680xGkrToWO+FW8vLpL4kid6johl/qltQtlK2N7kBvYvgkRPbc3st+GbIL2vhZADt eu7P/fW9qc2BxECjQjwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qFubt-007gQw-0x; Sun, 02 Jul 2023 10:47:17 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qFubp-007gNL-2R for linux-arm-kernel@lists.infradead.org; Sun, 02 Jul 2023 10:47:15 +0000 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-51d9124e1baso3874824a12.2 for ; Sun, 02 Jul 2023 03:47:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688294832; x=1690886832; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=doP8CZZyrslCenSYjdf6T/PIt+tCk5F92Ar2E5adtJ0=; b=ctacEYA1JK6veFXxDJZFud4r7LN4mBV0X0v7BsVcyc/h8oYdZJGgjQKfYbSclowoaF CKs9o5FIk4V/q8HdhxLVMS+Sr42LMHv+2sZCF8mC1KhKgvnJZh+69V4xD+YDMSYvsewV WNWMQiagaIhorzQIhS7+M2H2kyDkr2sPp+GZv66P5t8ubtR95qYQhfzLtRQeKW8MHomL kxGBUQyE83nuOB1+LLo9XvcMNl6hbj18QP9Xo/33e2Bs36JK0zpsHisRQmtKmyQue+sl 1pvQidSX7rfr4UOtgA2F6PKiRNJXHbHYojIpxZC8qxgeo+7dS0ixvkqrlbOm2SrYriy4 k1NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688294832; x=1690886832; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=doP8CZZyrslCenSYjdf6T/PIt+tCk5F92Ar2E5adtJ0=; b=HbwrCPy7KF1CRnZVhppycLJQfdaoxyjKng0W3eIlAGRQKHNLnapmVMFoYu3rmO7OAi R48Y4hyQaea8i9YmCtMTWvCABJzSDhCPTS9yXsE5+jNwTGTZdYjmd6RfcTpG28nq2Ywu NedddYeeRrJ/kuS+TVcgN7JSUsvzXsgpvHSYtkkAcIMCu3vaeVsnjB/qeJeTpQL2fgh7 /fD6bxKg5t/EUkh57f2QE3WPbQICkap8AIyiZz6xyGvP1+r8Fi3yqTNPREG8MC6U48op n91X9I5ivy3INGswtAR98EsG6vk6IYCJmXa3g6l9QqOp4L5TusQ8Q4d1R/TT/xWd+P6u UTog== X-Gm-Message-State: ABy/qLZztJkdXJY4/s8h8Y41t8UCM+7RrSrZwMLoer80kpV4YfFLrxP6 V+58E1XlMZjDY1eq1xTfLtdkrQ== X-Google-Smtp-Source: APBJJlEUDjmuQNgaEKhIauAAnEoZ97aP9Ydyy4Asa0tJshbXlejAZ3SysQ8kzJrnLsVizDYxGEaxCQ== X-Received: by 2002:aa7:ca57:0:b0:51d:96de:af6f with SMTP id j23-20020aa7ca57000000b0051d96deaf6fmr5497089edt.0.1688294831756; Sun, 02 Jul 2023 03:47:11 -0700 (PDT) Received: from [192.168.10.214] ([217.169.179.6]) by smtp.gmail.com with ESMTPSA id q14-20020a056402040e00b0051d890b2407sm8550077edv.81.2023.07.02.03.47.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Jul 2023 03:47:11 -0700 (PDT) Message-ID: <889bbee2-db9c-c1dd-dc8a-cdc436f1dfd8@linaro.org> Date: Sun, 2 Jul 2023 12:47:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 3/4] dt-bindings: media: add mediatek ISP3.0 camsv Content-Language: en-US To: Julien Stephan Cc: Phi-bang Nguyen , Andy Hsieh , AngeloGioacchino Del Regno , Conor Dooley , daoyuan huang , devicetree@vger.kernel.org, Florian Sylvestre , Hans Verkuil , Krzysztof Kozlowski , Laurent Pinchart , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-media@vger.kernel.org, Louis Kuo , Matthias Brugger , Mauro Carvalho Chehab , Moudy Ho , Ping-Hsun Wu , Rob Herring , Vasily Gorbik References: <20230628145412.1610260-1-jstephan@baylibre.com> <20230628145412.1610260-4-jstephan@baylibre.com> From: Krzysztof Kozlowski In-Reply-To: <20230628145412.1610260-4-jstephan@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230702_034713_918717_7326787C X-CRM114-Status: GOOD ( 15.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28/06/2023 16:52, Julien Stephan wrote: > From: Phi-bang Nguyen > > This adds the bindings, for the ISP3.0 camsv module embedded in > some Mediatek SoC, such as the mt8365 Thank you for your patch. There is something to discuss/improve. > + > +description: > + The CAMSV is a set of DMA engines connected to the SENINF CSI-2 > + receivers. The number of CAMSVs depend on the SoC model. > + > +properties: > + compatible: > + const: mediatek,mt8365-camsv > + > + reg: > + maxItems: 3 Describe the items (items with description) instead. > + ... > + > +examples: > + - | > + #include > + #include > + #include > + #include > + #include > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + camsv1: camsv@15050000 { > + compatible = "mediatek,mt8365-camsv"; > + reg = <0 0x15050000 0 0x0040>, > + <0 0x15050208 0 0x0020>, > + <0 0x15050400 0 0x0100>; Fix the alignment. > + interrupts = ; > + clocks = <&camsys CLK_CAM>, > + <&camsys CLK_CAMTG>, > + <&camsys CLK_CAMSV0>; Everywhere... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel