From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91BFCC48285 for ; Wed, 31 Jan 2024 09:31:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YYrPCt+K4/FJofentrwvjsdi+yhxgyyOGI7KwpV55qY=; b=hUoWY/fTfq1Nbt FEzRGy+wUWRxmllUf7VipbKFC6WksmkhZPkXOfwYMR/PZcDl9uE+RDJ1GWxysbXSUVckYi/8hT+WK xpSbKEIKT0ntz/QUlHh51UXhH9F+vV7SnhqVePcNJ5ZBK1RM3njeXZ5Cb8RakAchnBRw3Ie+ltU04 haUj5SHSkJHGLy8bjv0/BxObS/s1VEx8FKGELckud+XfMsYvP9wG7qujOMYSPwymXmArojDF6QXDX Yshr5bPSNlkrkSRKywWM/xBDUpJs8SJGq/BbWuBEBd+LJ9LNDXixPam8A4wv1X0j7bDFDoOUsPext J3eeWIvr8aebk3n3zw8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rV6wN-00000002TFf-0RUa; Wed, 31 Jan 2024 09:31:31 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rV5nn-000000023Og-0pT6 for linux-arm-kernel@bombadil.infradead.org; Wed, 31 Jan 2024 08:18:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=vCecwRzBzQSyeXumd7WutVzu1OLVJalOTvuV9hUGgyA=; b=oQF8x5fqfE39XhUCaHOzbQlULN KSPR5oEe0q7ztHhvEv5vi9ivC0FdG33gXuOiHwoQMWk5AGthP492FIAVFk+VrFUdljWR3BFa+fywy tJZZR6OSCu3No7kF1HAGvqoAWbcirNb6ZdCPUQoeDuLSH7eFKvZfynPJIH6C1enfUBdcXMkvDF7X2 qEMwCMowmc8LZwP07m0rT91CqwV4miieyNzr/OY+cZH+EpXyDEeifVRP+xa2zPRVee7UrRqe5VjTJ KYewjHi5IxjOHCZssnl1YVEDpT4Zb9I7RLmjyVCbZ/eavhg/eMi2bJ7h1S2Wwa4ut3UMVULMBLFWQ MKti18cw==; Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rV5nh-00000008oYL-3iGz for linux-arm-kernel@lists.infradead.org; Wed, 31 Jan 2024 08:18:32 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id EBC9FCE1E2F; Wed, 31 Jan 2024 08:18:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A034BC433C7; Wed, 31 Jan 2024 08:18:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706689103; bh=uVuCtAAr/8kTNdmmZBQPRy6Y0jWrvVDn0rG6YH7p4VU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=QAdIJ/i+5sP3lPohRphDzZU5Ek32FUCfbjWw+IU+SqwC23Yw1a4Q8cMIeUVIWL0dG 1A6e7MJzMb4OzeCay5vgD0QqzXGZZdsP0czcyN+6EH0I/sOnpdxWYEGI2OGhTR7E8f a4YSgXQ3nT46s0HqO37puWNOwtSaGGs+Pqss3NBTmhDdFVPYOLeG5nPoWTwyN9VOrF 8EQbdiumMZislx9pWo6CJEJqBFBc15CMCxM60brdEsM0zRDnqraNjK3D989qfM+kKK GEmt0l2qyFSVnhKuejfq9iKx/nddoUAFPuqoEjdZoHgoCuFaablECkFofWzJyYDBil T6lPsOpD4cTBQ== Message-ID: <88a036a2-2848-41d3-a0fb-48ee14604850@kernel.org> Date: Wed, 31 Jan 2024 09:18:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 30 2/7] Add binding for Aspeed SOC To: "Corona, Ernesto" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" Cc: "'oleksandrs@mellanox.com'" , "'jiri@nvidia.com'" , "Castro, Omar Eduardo" , "'omar.eduardo.castro@linux.intel.com'" , "'robh@kernel.org'" , "'corbet@lwn.net'" , "'mchehab+samsung@kernel.org'" , "'alexandre.belloni@bootlin.com'" , "'tytso@mit.edu'" , "'arnd@arndb.de'" , "'ebiggers@google.com'" , "'mark.rutland@arm.com'" , "'joel@jms.id.au'" , "'andrew@aj.id.au'" , "Filary, Steven A" , "'vadimp@mellanox.com'" , "'amithash@fb.com'" , "'patrickw3@fb.com'" , "Chen, Luke" , "'billy_tsai@aspeedtech.com'" , "'rgrs@protonmail.com'" References: Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240131_081831_046953_5A2BF6C4 X-CRM114-Status: GOOD ( 27.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 31/01/2024 00:30, Corona, Ernesto wrote: > Aspeed AST2400, AST2500 and AST2600 JTAG controller driver. > > Signed-off-by: Oleksandr Shamray > Signed-off-by: Jiri Pirko > Signed-off-by: Ernesto Corona > Signed-off-by: Omar Castro > Acked-by: Rob Herring 1. There are so many wrong things with this submission that you should drop the tag. Please provide lore link where you received this tag. Quick look at lore suggests you faked it. 2. Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. 3. Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts_getmaintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, use mainline), work on fork of kernel (don't, use mainline) or you ignore some maintainers (really don't). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested. Please kindly resend and include all necessary To/Cc entries. > Cc: Jonathan Corbet > Cc: Mauro Carvalho Chehab > Cc: Alexandre Belloni > Cc: "Theodore Ts'o" > Cc: Arnd Bergmann > Cc: Eric Biggers > Cc: Mark Rutland > Cc: Joel Stanley > Cc: Andrew Jeffery > Cc: Steven Filary > Cc: Vadim Pasternak > Cc: Amithash Prasad > Cc: Patrick Williams > Cc: Luke Chen > Cc: Billy Tsai > Cc: Rgrs > --- > v29->v30 > Comments pointed by Steven Filary > - Add Suport for 26xx series > > v28->v29 > Comments pointed by Ernesto Corona > - Change documentation to the new dt-bindings yaml format. > > v27->v28 > v26->v27 > v25->v26 > v24->v25 > v23->v24 > v22->v23 > v21->v22 > v20->v21 > v19->v20 > v18->v19 > > v17->v18 > v16->v17 > v15->v16 > Comments pointed by Joel Stanley > - change clocks = <&clk_apb> to proper clocks = <&syscon ASPEED_CLK_APB> > - add reset descriptions in bindings file > > v14->v15 > v13->v14 > v12->v13 > v11->v12 > v10->v11 > v9->v10 > v8->v9 > v7->v8 > Comments pointed by pointed by Joel Stanley > - Change compatible string to ast2400 and ast2000 > > V6->v7 > Comments pointed by Tobias Klauser > - Fix spell "Doccumentation" -> "Documentation" > > v5->v6 > Comments pointed by Tobias Klauser > - Small nit: s/documentation/Documentation/ > > v4->v5 > > V3->v4 > Comments pointed by Rob Herring > - delete unnecessary "status" and "reg-shift" descriptions in > bindings file > > v2->v3 > Comments pointed by Rob Herring > - split Aspeed jtag driver and binding to separate patches > - delete unnecessary "status" and "reg-shift" descriptions in > bindings file > --- > .../devicetree/bindings/jtag/aspeed-jtag.yaml | 85 +++++++++++++++++++ > 1 file changed, 85 insertions(+) > create mode 100644 Documentation/devicetree/bindings/jtag/aspeed-jtag.yaml > > diff --git a/Documentation/devicetree/bindings/jtag/aspeed-jtag.yaml b/Documentation/devicetree/bindings/jtag/aspeed-jtag.yaml > new file mode 100644 > index 000000000000..1a412e83b81b > --- /dev/null > +++ b/Documentation/devicetree/bindings/jtag/aspeed-jtag.yaml Use filename matching compatibles, so aspeed,jtag.yaml > @@ -0,0 +1,85 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/jtag/aspeed-jtag.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Aspeed JTAG driver for ast2400, ast2500 and ast2600 SoC > + > +description: > + Driver adds support of Aspeed 24/25/2600 series SOC JTAG controller. > + Driver implements the following jtag ops > + freq_get > + freq_set > + status_get > + status_set > + xfer > + mode_set > + bitbang > + enable > + disable > + > + It has been tested on Mellanox system with BMC equipped with > + Aspeed 2520 SoC for programming CPLD devices. > + > + It has also been tested on Intel system using Aspeed 25xx SoC > + for JTAG communication. > + > + Tested on Intel system using Aspeed 26xx SoC for JTAG communication. > + > +maintainers: > + - Oleksandr Shamray > + - Jiri Pirko > + - Ernesto Corona > + > +properties: > + compatible: > + oneOf: Drop > + - items: Drop > + - enum: > + - aspeed,ast2400-jtag > + - aspeed,ast2500-jtag > + - aspeed,ast2600-jtag > + > + Just one blank line. Since this was not tested, I will skip review of the rest. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel