From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B94B7C77B6C for ; Fri, 31 Mar 2023 14:25:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:Subject:From: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tXhWLGo+MMomDUfn58mlyNjnMalKt4nGhW6O4wAdI78=; b=n470yylm/AYn6m Zo30pwXwXYfHxMr4PSjEU32UIi8bcTh2H9kHw3PIG3lAAKGpMDcGpDumce2KxAC9nfoLf4jKfTkuv 9njCkpY1TwGwi+s1TlVIvghQ7Imdsmz5NgW01SRJMqGyeKwKv/RroyzIqxUcYu+eX2cdClAV3abJM LWzZdwFM/JHqVmiIEwvuN7B22WGMO1Ayn4jiEwIUFxrQVn/BC1vE1qDc04DKI1Zf+7rS51ebLS6IO P0KTuHY0USiLviHBT39s6mkQzfgo70t/qvPwG5Fdtjl9ih6ImzBvi1B+DsCtySkNw/LRyEJWht1Yi q9KccKs7FK7JdPb+98ew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1piFg9-007fzj-0p; Fri, 31 Mar 2023 14:24:33 +0000 Received: from mail-il1-x12b.google.com ([2607:f8b0:4864:20::12b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1piFg6-007fyB-0f for linux-arm-kernel@lists.infradead.org; Fri, 31 Mar 2023 14:24:31 +0000 Received: by mail-il1-x12b.google.com with SMTP id u8so11574064ilb.2 for ; Fri, 31 Mar 2023 07:24:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680272666; x=1682864666; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=6UCEBU5mLz9QdxPqNmojtQa38OeHK3XeLs0yM78qHDU=; b=ysa2qjifmTJO9JHHygIj29NmPqr7X++zxe0C5SngoNEYEgnb6q3wTU0Ve8V3Hk83qq xyyQcuFNn2Joc/XP++7VT03IfLitF+LM8DOP0xJ/cRTKpR8InW0+3C31Mbh7F4ztZUnN zCwyOiMRX2fzNPiOUI2aIg9/HgN+XbXvLdihCmNm2Bn3LDgvSfYnMYm8EToTOrGMPf4J osR6kfHsUdXfrRt0vB+TpSvVef8YETc489yJTl/1WCscdnWZZqFjVrNKxgL4vB/EFSrR ZsF7jEu35iOjh6Q4RD19FIcrALibJKiLmUQfYeA4xvDxLcjtld6MgCvxU/RzPK2vfkfP Ae1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680272666; x=1682864666; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6UCEBU5mLz9QdxPqNmojtQa38OeHK3XeLs0yM78qHDU=; b=4EnxK9LK6of6PZxkaK2y5+rKeRpf6MBeY04WNm/0xXeR3Qar2u45LWmygf58mDHcoO TWdWaJQwKnTjltisOxaSxBdhSh1qUlXs5P17YAHskQFxXnD61ILa9Gu70YZ/G/cfU+Fl WusaBo1LXqMLnudfGlWd9BJkqDXUy3Npwb6lTrccOnpbG7hSr/qd/gjZkG9fgn5Ij/il 2zpJoQPyVjnvG8IZcB6GyRPiM+cz6cF0CjDesJY2jOzNZ/NbSsG+Al/WRhCkl3gwRpqt 3j2lrDonUPam5mxbYHXn/rfFDb8UfrRj+5ebz5w78DcdIv2l/BR8+gmMS8i58/pSBVRb mtsg== X-Gm-Message-State: AAQBX9dKYK68kRnsWCfdH206PAdLdJ5PYeGKHbAMuNiVzZiZM5VLcUQA 7UXjQXAmglgDuwSh9EXu5EU1gg== X-Google-Smtp-Source: AKy350YVgRKOO4Y8oepZkwpgSMnl2j7X6N2/BaBvJ1LPgAjZRmKLiJF6tNiaXZIiQzSXa2KbugpiaA== X-Received: by 2002:a05:6e02:4cb:b0:323:f57c:806d with SMTP id f11-20020a056e0204cb00b00323f57c806dmr14994799ils.3.1680272666593; Fri, 31 Mar 2023 07:24:26 -0700 (PDT) Received: from [172.22.22.4] ([98.61.227.136]) by smtp.googlemail.com with ESMTPSA id g3-20020a056e020d0300b003230c7d6a3csm657043ilj.67.2023.03.31.07.24.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Mar 2023 07:24:25 -0700 (PDT) Message-ID: <88a4808c-5f45-cb07-83bb-039f9d832b5b@linaro.org> Date: Fri, 31 Mar 2023 09:24:24 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 From: Alex Elder Subject: Re: [PATCH v11 00/26] Drivers for gunyah hypervisor To: Elliot Berman , Srinivas Kandagatla Cc: Murali Nalajala , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Prakruthi Deepak Heragu , Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Arnd Bergmann , Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Bagas Sanjaya , Will Deacon , Andy Gross , Catalin Marinas , Jassi Brar , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230304010632.2127470-1-quic_eberman@quicinc.com> Content-Language: en-US In-Reply-To: <20230304010632.2127470-1-quic_eberman@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230331_072430_248052_742D8ECE X-CRM114-Status: GOOD ( 17.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/3/23 7:06 PM, Elliot Berman wrote: > Gunyah is a Type-1 hypervisor independent of any > high-level OS kernel, and runs in a higher CPU privilege level. It does > not depend on any lower-privileged OS kernel/code for its core > functionality. This increases its security and can support a much smaller > trusted computing base than a Type-2 hypervisor. > > Gunyah is an open source hypervisor. The source repo is available at > https://github.com/quic/gunyah-hypervisor. I've done a pretty detailed review again, and got further along than I did last time. Things are definitely looking better, but I have found some bugs that need to be addressed. I also make a lot of comments about grouping certain sets of definitions into enumerated types. Also I tend to notice when things aren't done consistently, and I mention that a lot. There are silly suggestions all over about alignment of things--these are mainly to make the code look prettier, though that's a matter of opinion. I still prefer having lines generally closer to 80 columns wide, but I've already mentioned that... I really focused on the code, and not the documentation. In fact I didn't even pay much attention to your patch headers either. I did not review the SCM calls yet. So in summary I have not reviewed patches 1, 2, 16, 17, and 26. I try to look at everything in my next review, which I hope will be final (or very close). -Alex > The diagram below shows the architecture. > > :: > > VM A VM B > +-----+ +-----+ | +-----+ +-----+ +-----+ > | | | | | | | | | | | > EL0 | APP | | APP | | | APP | | APP | | APP | > | | | | | | | | | | | > +-----+ +-----+ | +-----+ +-----+ +-----+ > ---------------------|------------------------- > +--------------+ | +----------------------+ > | | | | | > EL1 | Linux Kernel | | |Linux kernel/Other OS | ... > | | | | | > +--------------+ | +----------------------+ > --------hvc/smc------|------hvc/smc------------ > +----------------------------------------+ > | | > EL2 | Gunyah Hypervisor | > | | > +----------------------------------------+ > > Gunyah provides these following features. > . . . _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel