Re: [PATCH v2 3/4] dt-bindings: media: mediatek: mdp: Change mediatek,gce-events to reference - Jason-JH Lin (林睿祥)

From: "Jason-JH Lin (林睿祥)" <Jason-JH.Lin@mediatek.com>
To: "robh+dt@kernel.org" <robh+dt@kernel.org>,
	"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
	"krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"jassisinghbrar@gmail.com" <jassisinghbrar@gmail.com>,
	"angelogioacchino.delregno@collabora.com"
	<angelogioacchino.delregno@collabora.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"Singo Chang (張興國)" <Singo.Chang@mediatek.com>,
	"Johnson Wang (王聖鑫)" <Johnson.Wang@mediatek.com>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	"Jason-ch Chen (陳建豪)" <Jason-ch.Chen@mediatek.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"Shawn Sung (宋孝謙)" <Shawn.Sung@mediatek.com>,
	"Nancy Lin (林欣螢)" <Nancy.Lin@mediatek.com>,
	Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 3/4] dt-bindings: media: mediatek: mdp: Change mediatek,gce-events to reference
Date: Fri, 12 Jan 2024 07:53:29 +0000	[thread overview]
Message-ID: <88caca5148e8e00a23f062c46ccc6a7afc5f66d6.camel@mediatek.com> (raw)
In-Reply-To: <d1bae8c6-a511-4bd2-9bc6-1b3c4dc6fb42@linaro.org>

Hi Krzysztof,

Thanks for the reivews.

On Fri, 2024-01-12 at 08:22 +0100, Krzysztof Kozlowski wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On 10/01/2024 07:35, Jason-JH.Lin wrote:
> > Change mediatek,gce-events property to reference mediatek,gce-
> props.yaml
> > instead of defining itself.
> > 
> > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> > ---
> >  .../bindings/media/mediatek,mdp3-rdma.yaml           | 11 +++-----
> ---
> >  .../devicetree/bindings/media/mediatek,mdp3-rsz.yaml | 12 ++++--
> ------
> >  .../bindings/media/mediatek,mdp3-wrot.yaml           | 12 ++++--
> ------
> >  3 files changed, 11 insertions(+), 24 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-
> rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-
> rdma.yaml
> > index 59db8306485b..1ba70b9a5843 100644
> > --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-
> rdma.yaml
> > +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-
> rdma.yaml
> > @@ -44,13 +44,6 @@ properties:
> >        4 arguments defined in this property. Each GCE subsys id is
> mapping to
> >        a client defined in the header include/dt-
> bindings/gce/<chip>-gce.h.
> >  
> > -  mediatek,gce-events:
> > -    description:
> > -      The event id which is mapping to the specific hardware event
> signal
> > -      to gce. The event id is defined in the gce header
> > -      include/dt-bindings/gce/<chip>-gce.h of each chips.
> > -    $ref: /schemas/types.yaml#/definitions/uint32-array
> > -
> >    mediatek,scp:
> >      $ref: /schemas/types.yaml#/definitions/phandle
> >      description:
> > @@ -96,6 +89,8 @@ required:
> >    - '#dma-cells'
> >  
> >  allOf:
> > +  - $ref: ../mailbox/mediatek,gce-props.yaml
> 
> You need full path, so /schemas/mailbox/
> 
> Applies to all the patches.
> 

OK, I'll apply it to all the patches.

Regards,
Jason-JH.Lin

> Best regards,
> Krzysztof
> 
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel