From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37AFEC3DA42 for ; Wed, 10 Jul 2024 15:50:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SgKy5p995IZJBixL2m+hWHaNM8qtlTloa6iS5xyn5Ys=; b=D5z3Pb7rp/Ij7HDbpr73ft8K+S rUe5LfxZDKvVt2HltyagIyhBE4uU7U+W5iwaaNYiVtmHZYmhFCcBKTwdjbwiJdWkYija+pi00Fdun 6degKIZAYeMixXL1LRdw30Ou5QT8iZ49M2loiaBN7b7ZZu5xkliyV2sIJThG+jCdPBNWU/AT3/9Dv wMnguwPYRY8/N0XGl0fX0t5ZinmLN2tZNXzEhY4dohh3Gfih5yp5GZaSRFOFohzKTEuZdO5jwp0Qq 3b1LW5MV1zuB8jf7TeKVFmvRgn4/QK/kBMusLli/zBA6zwhkf+CTTyfFKkl2RfHXbEI+/csGH+hvJ z2x+LQHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRZae-0000000B18N-2yjd; Wed, 10 Jul 2024 15:50:44 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRZaN-0000000B13j-2IFR for linux-arm-kernel@lists.infradead.org; Wed, 10 Jul 2024 15:50:29 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BC2F7106F; Wed, 10 Jul 2024 08:50:49 -0700 (PDT) Received: from [192.168.47.77] (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 58A873F762; Wed, 10 Jul 2024 08:50:19 -0700 (PDT) Message-ID: <88dd08fe-5a69-48b2-8838-8231928d29ab@arm.com> Date: Wed, 10 Jul 2024 10:50:17 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/11] usb: dwc2: Skip clock gating on Broadcom SoCs Content-Language: en-US To: Lukas Wunner Cc: Stefan Wahren , Florian Fainelli , Minas Harutyunyan , Greg Kroah-Hartman , Ray Jui , Scott Branden , Maxime Ripard , Thomas Gleixner , Jassi Brar , Ulf Hansson , Jiri Slaby , Dave Stevenson , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Peter Robinson , dri-devel@lists.freedesktop.org, bcm-kernel-feedback-list@broadcom.com, linux-pm@vger.kernel.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-list@raspberrypi.com References: <20240630153652.318882-1-wahrenst@gmx.net> <20240630153652.318882-10-wahrenst@gmx.net> <95762956-b46a-4dfa-b22f-bccbfa39558d@broadcom.com> <4502d826-d80c-4a98-a889-da7badfa698e@gmx.net> <43fa421c-5e5b-40a6-a546-d80e753586e3@gmx.net> <38e46b44-6248-45e8-bdf9-66008a2fe290@arm.com> From: Jeremy Linton In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240710_085027_675572_E0A23D1F X-CRM114-Status: GOOD ( 17.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 7/5/24 16:14, Lukas Wunner wrote: > On Fri, Jul 05, 2024 at 12:16:14PM -0500, Jeremy Linton wrote: >>> Am 05.07.24 um 17:03 schrieb Lukas Wunner: >>>> Careful there, the patch vaguely says... >>>> >>>> With that added and identified as "BCM2848", >>>> an id in use by other OSs for this device, the dw2 >>>> controller on the BCM2711 will work. >>>> >>>> ...which sounds like they copy-pasted the BCM2848 id from somewhere else. >>>> I would assume that BCM2848 is really a different SoC and not just >>>> a different name for the BCM2835, but hopefully BroadCom folks will >>>> be able to confirm or deny this (and thus the necessity of the quirk >>>> on BCM2848 and not just on BCM2835). >> >> This id comes from the edk2-platforms ACPI tables and is currently used by >> both the rpi3 and rpi4, and AFAIK nothing else as the rpi5-dev work is >> currently only exposing XHCI. >> >> The ID is strictly the USB controller not the SoC. Its a bit confusingly >> named, but something we inherited from the much older windows/edk2 port, >> where it appears that the peripheral HID's were just picked in numerical >> order. >> >> [0] https://github.com/tianocore/edk2-platforms/blob/12f68d29abdc9d703f67bd743fdec23ebb1e966e/Platform/RaspberryPi/AcpiTables/GpuDevs.asl#L15 > > So BCM2848, BCM2849, BCM2850 and so on are just made-up IDs > for a Windows/EDK2 port that got cargo-culted into the kernel? > Yikes! You could say that, but there was some due diligence a couple years ago to track down the owner of the pnp id/information at broadcom, and it didn't yield anything helpful. Whether they are legitimate seems to be lost in time. At this point they are widely/publicly known Ids, without apparent conflict. > > Has anyone checked whether they collide with actual Broadcom products?